{"id":813261,"url":"http://patchwork.ozlabs.org/api/covers/813261/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/cover/1505295366-25295-1-git-send-email-peterx@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505295366-25295-1-git-send-email-peterx@redhat.com>","list_archive_url":null,"date":"2017-09-13T09:36:02","name":"[0/4] qtest: fix \"device_del\" out-of-order events","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/?format=json","name":"Peter Xu","email":"peterx@redhat.com"},"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/cover/1505295366-25295-1-git-send-email-peterx@redhat.com/mbox/","series":[{"id":2853,"url":"http://patchwork.ozlabs.org/api/series/2853/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2853","date":"2017-09-13T09:36:02","name":"qtest: fix \"device_del\" out-of-order events","version":1,"mbox":"http://patchwork.ozlabs.org/series/2853/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/813261/comments/","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsc5332bvz9rxj\n\tfor ;\n\tWed, 13 Sep 2017 19:37:11 +1000 (AEST)","from localhost ([::1]:41200 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds46X-000140-Fo\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 05:37:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51029)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds45p-00011i-OU\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 05:36:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds45m-0007TK-J9\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 05:36:25 -0400","from mx1.redhat.com ([209.132.183.28]:46906)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1ds45m-0007St-Dx\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 05:36:22 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 811047F755\n\tfor ; Wed, 13 Sep 2017 09:36:21 +0000 (UTC)","from pxdev.xzpeter.org.com (dhcp-15-224.nay.redhat.com\n\t[10.66.15.224])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id CA30F19EFA;\n\tWed, 13 Sep 2017 09:36:11 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 811047F755","From":"Peter Xu ","To":"qemu-devel@nongnu.org","Date":"Wed, 13 Sep 2017 17:36:02 +0800","Message-Id":"<1505295366-25295-1-git-send-email-peterx@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 13 Sep 2017 09:36:21 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH 0/4] qtest: fix \"device_del\" out-of-order events","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fam Zheng , Markus Armbruster ,\n\tpeterx@redhat.com, Gerd Hoffmann ,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"It starts from a \"make check\" failure on one of my private tree. The\nproblem is that when we do \"device_del\" we normally looking for two\nthings: one response (which is mostly empty), and a REMOVE event. The\ntricky point is the event can either be there before/after the empty\nresponse. So I added qmp_device_del() to make sure the order does not\nmatter, then use it where proper.\n\nSince I'm at it, I also added the sister helper qmp_device_add(), it\nhelps to remove LOCs.\n\nI still don't 100% sure why my private tree can trigger this error,\nwhile the master cannot. Anyway, I think this is something we should\nhave, no matter what.\n\nPlease review. Thanks.\n\nPeter Xu (4):\n libqtest: add qmp_device_del()\n tests: use qmp_device_del() where proper\n libqtest: add qmp_device_add()\n tests: use qmp_device_add() where proper\n\n tests/libqos/pci.c | 15 +++--------\n tests/libqos/usb.c | 28 +++++----------------\n tests/libqtest.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++\n tests/libqtest.h | 17 +++++++++++++\n tests/usb-hcd-uhci-test.c | 28 +++------------------\n tests/usb-hcd-xhci-test.c | 52 ++++----------------------------------\n 6 files changed, 97 insertions(+), 106 deletions(-)"}