{"id":2226205,"url":"http://patchwork.ozlabs.org/api/covers/2226205/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/cover/bmm.hhub8n5f78.gcc.gcc-TEST.redi.15.1.0@forge-stage.sourceware.org/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<bmm.hhub8n5f78.gcc.gcc-TEST.redi.15.1.0@forge-stage.sourceware.org>","list_archive_url":null,"date":"2026-04-22T10:25:09","name":"[v1,00/12] WIP: libstdc++: Refactor hash table code","submitter":{"id":93210,"url":"http://patchwork.ozlabs.org/api/people/93210/?format=json","name":"Jonathan Wakely via Sourceware Forge","email":"forge-bot+redi@forge-stage.sourceware.org"},"mbox":"http://patchwork.ozlabs.org/project/gcc/cover/bmm.hhub8n5f78.gcc.gcc-TEST.redi.15.1.0@forge-stage.sourceware.org/mbox/","series":[{"id":500966,"url":"http://patchwork.ozlabs.org/api/series/500966/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=500966","date":"2026-04-22T10:25:11","name":"WIP: libstdc++: Refactor hash table code","version":1,"mbox":"http://patchwork.ozlabs.org/series/500966/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/2226205/comments/","headers":{"Return-Path":"<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0wl61phjz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 20:41:54 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 353FF4844FA1\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 10:41:49 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id CBCEC4BBCDB9\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 10:26:14 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id A79284059F\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 10:26:14 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 353FF4844FA1","OpenDKIM Filter v2.11.0 sourceware.org CBCEC4BBCDB9"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org CBCEC4BBCDB9","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org CBCEC4BBCDB9","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776853574; cv=none;\n b=ejzqwRMn7aF/fwX1BN8dEwNR2qrd8sVZLeDGHA0Pbbanl2vjQM/glT2fnLd414RDFzkG3lJpIvCZyxm9edx8qrzSh475yAs4ty21d6zicxwNcRdUu/U0AY1hwHM2XgOG3u0nhvF2ZyADhnr+vC9midRLcvRRp7N1hB93nxZHBms=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776853574; c=relaxed/simple;\n bh=2EBizfLaxbQeBch3wf8uHNd5shuT+Lvm9xawCi9lckI=;\n h=From:Date:Subject:MIME-Version:To:Message-ID;\n b=VLBITdmItUia4W5nendTBBiSbvpz8qKone1Cjw7Xvm00hQiQQE/gaRAizwpbanxoRgcFyUqy7TzOYq6zlJ77nDLEn1hMolgCoJZRMvK5qwDB5r1qlbkals0gEetjVSE+LNMmQxrcW/IrIeCTmgLEymc5ygVDzRXW3Vkup8oOz10=","ARC-Authentication-Results":"i=1; server2.sourceware.org","From":"Jonathan Wakely via Sourceware Forge\n <forge-bot+redi@forge-stage.sourceware.org>","Date":"Wed, 22 Apr 2026 10:25:09 +0000","Subject":"[PATCH v1 00/12] WIP: libstdc++: Refactor hash table code","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","To":"gcc-patches mailing list <gcc-patches@gcc.gnu.org>","Message-ID":"\n <bmm.hhub8n5f78.gcc.gcc-TEST.redi.15.1.0@forge-stage.sourceware.org>","X-Mailer":"batrachomyomachia","X-Requested-Reviewer":"fdumont","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/15","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list <gcc-patches.gcc.gnu.org>","List-Unsubscribe":"<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>","List-Archive":"<https://gcc.gnu.org/pipermail/gcc-patches/>","List-Post":"<mailto:gcc-patches@gcc.gnu.org>","List-Help":"<mailto:gcc-patches-request@gcc.gnu.org?subject=help>","List-Subscribe":"<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>","Reply-To":"gcc-patches mailing list <gcc-patches@gcc.gnu.org>, redi@gcc.gnu.org","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"Hi gcc-patches mailing list,\nJonathan Wakely via Sourceware Forge <forge-bot+redi@forge-stage.sourceware.org> has requested that the following forgejo pull request\nbe published on the mailing list.\n\nCreated on: 2024-11-01 21:23:45+00:00\nLatest update: 2025-08-13 07:23:55+00:00\nChanges: 0 changed files, 0 additions, 0 deletions\nHead revision: redi/gcc ref refs/pull/15/head commit 49b7f6d1492cc2aebc1454cbd5a2ff3f546d4cf4\nBase revision: gcc/gcc-TEST ref trunk commit 7e1d9f58858153bee4bcbab45aa862442859d958 r15-5047-g7e1d9f58858153\nMerge base: 7e1d9f58858153bee4bcbab45aa862442859d958\nFull diff url: https://forge.sourceware.org/gcc/gcc-TEST/pulls/15.diff\nDiscussion:  https://forge.sourceware.org/gcc/gcc-TEST/pulls/15\nRequested Reviewers: fdumont\n\nThis fixes [PR libstdc++/115285](https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115285) ~and also optimizes the [PR libstdc++/96088](https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96088) case (only for `std::string` keys), without the problems caused by the original solution.~\n\nIt might be easier to review the individual commits, as most of them make small incremental changes that are (mostly) independent of the other commits. \"Refactor _Hashtable insertion\" is the big one, ~although the \"Optimize string lookup\" on is quite complex too (but is an optional optimization, so not required for correctness and conformance).~\n\n\nChanged files:\n- M: libstdc++-v3/include/bits/hashtable.h\n- M: libstdc++-v3/include/bits/hashtable_policy.h\n- M: libstdc++-v3/include/bits/unordered_map.h\n- M: libstdc++-v3/include/bits/unordered_set.h\n- M: libstdc++-v3/testsuite/23_containers/unordered_map/96088.cc\n- M: libstdc++-v3/testsuite/23_containers/unordered_map/modifiers/merge.cc\n- M: libstdc++-v3/testsuite/23_containers/unordered_multimap/modifiers/merge.cc\n- M: libstdc++-v3/testsuite/23_containers/unordered_multiset/allocator/move_assign.cc\n- M: libstdc++-v3/testsuite/23_containers/unordered_multiset/modifiers/merge.cc\n- M: libstdc++-v3/testsuite/23_containers/unordered_set/96088.cc\n- M: libstdc++-v3/testsuite/23_containers/unordered_set/allocator/move_assign.cc\n- M: libstdc++-v3/testsuite/23_containers/unordered_set/modifiers/merge.cc\n\n\nJonathan Wakely (12):\n  libstdc++: Refactor\n    _Hashtable::operator=(initializer_list<value_type>)\n  libstdc++: Allow unordered_set assignment to assign to existing nodes\n  libstdc++: Refactor Hashtable insertion [PR115285]\n  libstdc++: Refactor Hashtable erasure\n  libstdc++: Add _Hashtable::_M_assign for the common case\n  libstdc++: Replace _Hashtable::__fwd_value_for with cast\n  libstdc++: Use RAII in _Hashtable\n  libstdc++: Remove _Insert base class from _Hashtable\n  libstdc++: Remove _Equality base class from _Hashtable\n  libstdc++: Remove _Hashtable_base::_S_equals\n  libstdc++: Simplify _Hashtable merge functions\n  libstdc++: Add _Hashtable::_M_locate(const key_type&)\n\n libstdc++-v3/include/bits/hashtable.h         | 1107 ++++++++++-------\n libstdc++-v3/include/bits/hashtable_policy.h  |  504 +-------\n libstdc++-v3/include/bits/unordered_map.h     |   19 +-\n libstdc++-v3/include/bits/unordered_set.h     |   19 +-\n .../23_containers/unordered_map/96088.cc      |   21 +-\n .../unordered_map/modifiers/merge.cc          |  130 ++\n .../unordered_multimap/modifiers/merge.cc     |  119 ++\n .../allocator/move_assign.cc                  |    5 +-\n .../unordered_multiset/modifiers/merge.cc     |  121 ++\n .../23_containers/unordered_set/96088.cc      |   14 +-\n .../unordered_set/allocator/move_assign.cc    |   10 +-\n .../unordered_set/modifiers/merge.cc          |  128 ++\n 12 files changed, 1244 insertions(+), 953 deletions(-)"}