{"id":2216024,"url":"http://patchwork.ozlabs.org/api/covers/2216024/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/cover/20260325165431.1027591-1-sjg@chromium.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260325165431.1027591-1-sjg@chromium.org>","list_archive_url":null,"date":"2026-03-25T16:54:09","name":"[00/13] boot: Make fit_image_load() easier to maintain","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/cover/20260325165431.1027591-1-sjg@chromium.org/mbox/","series":[{"id":497475,"url":"http://patchwork.ozlabs.org/api/series/497475/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=497475","date":"2026-03-25T16:54:09","name":"boot: Make fit_image_load() easier to maintain","version":1,"mbox":"http://patchwork.ozlabs.org/series/497475/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/2216024/comments/","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=MKIAz/Vu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"MKIAz/Vu\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgtMF4Q7qz1y1K\n\tfor ; Thu, 26 Mar 2026 03:55:37 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 5812783AAB;\n\tWed, 25 Mar 2026 17:55:35 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id C047F83A91; Wed, 25 Mar 2026 17:55:33 +0100 (CET)","from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com\n [IPv6:2607:f8b0:4864:20::22a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2056581E18\n for ; Wed, 25 Mar 2026 17:55:31 +0100 (CET)","by mail-oi1-x22a.google.com with SMTP id\n 5614622812f47-4673790ab85so3006715b6e.3\n for ; Wed, 25 Mar 2026 09:55:31 -0700 (PDT)","from chromium.org ([73.34.74.121]) by smtp.gmail.com with ESMTPSA id\n 5614622812f47-46a7099df08sm30481b6e.15.2026.03.25.09.55.27\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 25 Mar 2026 09:55:28 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1774457729; x=1775062529; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=6ZtOhdIYb7moHvHPIaOKUtQTQcWhiRvVx/3eNC6ae68=;\n b=MKIAz/Vuq4PHE4bWFVpQCHqdibS0i3ZGBcGF+i5R0jGYGZ5Na8L2+f//z1ntquVRuj\n JBDSk06+ldn84jj/ShtiG6kCqglX21z5/dLcmbek0RV8tFmVxEYblynKV6GVBqOt/3dk\n XVy8zgZOZg4W/zYufisaEj3o/F7pgzUzxWdOk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774457729; x=1775062529;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6ZtOhdIYb7moHvHPIaOKUtQTQcWhiRvVx/3eNC6ae68=;\n b=n4obILPUjJX8Dt30FT6LBzPCbsCR9Hl82MsiMANWKEeQs1b8zO8rx4Tgtwdyh9BP1S\n c2kGyl//sXrWJsE4mHRi+zPDsMnTSqSg8Mm/mcuh0ZFV4NnUbQIM2p5IdxDqy6N02ATA\n Iaulj3encRsJpEyv/C/vHysMY8tSKXPY31QZBUFH7+npxYw8IBMzcD8MHd44ZJXVmPm8\n FCpzV04SqRJpv8ftfKHUCYddBABCIO+TadfjqE2MXJgurGv4RpbhNxi2Ww/7AaLvLt90\n pQ98hrehRI3h8cuRqO6X0FMl7fO/MnJAJpDWT9pRRq08pJrN9UggElb9jy/iho+0fIq9\n zq+Q==","X-Gm-Message-State":"AOJu0YwOgoBQZmq3iz8xKzJqIXLUVcV8WS9E0GsaaLzrR+MBFfIP+Bc6\n ZBv/1Jyuv/8XQZqQ2UnB1qDZzuWK1ikUIE3cY3mdHbyYH8XgeAtO4q+ui/QVFQX2n3NGxzV4dED\n RTq0e+g==","X-Gm-Gg":"ATEYQzyHCnyKtyb0i0J9P71Y3ynpqENPZ76fC5wt2plylbKF3oQVuGaZyknlrIvrkuL\n hrmZR7KY34ZUILpTeVoroVYruW2MQWx+v64nr7lTJhC6FAfWgnj0pDxzml8xE8SND35tZYF66Ez\n 7G/Q5W9TKppstD1qFL02InkYAv+Oak4u2yyuKKqBKYZF1mpn0idSHNgFvsgp62WD0d+473DiIUY\n vOuEhhWPkWjkLCG9xkIyUFOzS3TdMW25t23CTEbv7hbKYdIFlC/MDj/86GtIhiUx7eCXnwtGFvo\n eb+qHbVOdf7BIH99CMQAgQ+yQa+jS8rA/rDA9cuGq2w97BXkAVZX4xTvuLBsv7+ekNs7th9OlPj\n vUzSInDYlr/zLjx//ooe757y82lDTzxIeBaJKD5YrhJogvefC48mCF+IaK1X9rGtPRTSlJOvvGi\n MPYYu/c2ss59Rq4T2KjQ==","X-Received":"by 2002:a05:6808:4f49:b0:467:f36d:a08a with SMTP id\n 5614622812f47-46a5c59bda0mr2106626b6e.5.1774457728732;\n Wed, 25 Mar 2026 09:55:28 -0700 (PDT)","From":"Simon Glass ","To":"u-boot@lists.denx.de","Cc":"Simon Glass ,\n James Hilliard ,\n Jonas Karlman ,\n Marek Vasut ,\n Mayuresh Chitale ,\n Neil Armstrong ,\n Quentin Schulz ,\n Shiji Yang , Tom Rini ,\n Wolfgang Wallner ","Subject":"[PATCH 00/13] boot: Make fit_image_load() easier to maintain","Date":"Wed, 25 Mar 2026 10:54:09 -0600","Message-ID":"<20260325165431.1027591-1-sjg@chromium.org>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Before fit_image_load() was created, the code to load kernels, ramdisks\nand devicetrees from a FIT was spread around many functions. By\ncombining most of the code in one place, it became possible to add more\nfeatures in a consistent way. The 'loadables' feature was much easier to\nplumb in, for example.\n\nWhile fit_image_load() was a substantial advance, it has never been a\nsvelte function and the passing years have not been entirely kind. With\na few new features on the horizon, this is a good time to improve the\nimplementation.\n\nThis series splits much of the code from fit_image_load() into a number\nof smaller functions. Most of the changes are fairly mechanical, with\njust a few renames and tweaks here and there.\n\nThis should make the function much easier to maintain. It may also\nencourage someone to take a look at its callers, which could also use\nsome attention.\n\nCode-size impact: about +8 bytes on aarch64 and +24-40 bytes on arm, due\nto the compiler's register allocation across the new helper functions.\n\n\nSimon Glass (13):\n boot: Split out the first part of fit_image_load()\n boot: Move call to fit_image_select() and rename it\n boot: Tidy up setting of the OS arch on host builds\n boot: Move type and OS checking into a new function\n boot: Move handling of the load_op into a separate function\n boot: Move obtaining data from a FIT image into a function\n boot: Check the image is allowed before setting os.arch\n boot: Move the architecture check into check_allowed()\n boot: Move image-decompression into a separate function\n boot: Move decomp_image() into handle_load_op()\n boot: Move setting the OS arch into check_allowed()\n boot: Drop unnecessary data variable\n boot: Tidy local variables in fit_image_load()\n\n boot/image-fit.c | 354 +++++++++++++++++++++++++++++++++++------------\n include/image.h | 11 +-\n 2 files changed, 273 insertions(+), 92 deletions(-)"}