{"id":949196,"url":"http://patchwork.ozlabs.org/api/1.2/patches/949196/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20180725133152.30898-12-miquel.raynal@bootlin.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/1.2/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20180725133152.30898-12-miquel.raynal@bootlin.com>","list_archive_url":null,"date":"2018-07-25T13:31:46","name":"[v5,11/17] mtd: rawnand: jz4740: convert driver to nand_scan()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5aa1c7ccb3808df04f33863fef088957f288a0f1","submitter":{"id":73368,"url":"http://patchwork.ozlabs.org/api/1.2/people/73368/?format=json","name":"Miquel Raynal","email":"miquel.raynal@bootlin.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20180725133152.30898-12-miquel.raynal@bootlin.com/mbox/","series":[{"id":57526,"url":"http://patchwork.ozlabs.org/api/1.2/series/57526/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=57526","date":"2018-07-25T13:31:36","name":"Allow dynamic allocations during NAND chip identification phase","version":5,"mbox":"http://patchwork.ozlabs.org/series/57526/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/949196/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/949196/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org\n\t(client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=bootlin.com","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"qLbhoBM/\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[IPv6:2607:7c80:54:e::133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41bGc32XGcz9s4c\n\tfor ;\n\tWed, 25 Jul 2018 23:41:55 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiK2y-0007oF-P7; Wed, 25 Jul 2018 13:41:44 +0000","from mail.bootlin.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiJu4-0000Kz-Tk\n\tfor linux-mtd@lists.infradead.org; Wed, 25 Jul 2018 13:32:36 +0000","by mail.bootlin.com (Postfix, from userid 110)\n\tid BA2B52099F; Wed, 25 Jul 2018 15:32:17 +0200 (CEST)","from localhost.localdomain\n\t(AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr [90.88.20.122])\n\tby mail.bootlin.com (Postfix) with ESMTPSA id 6616A2091A;\n\tWed, 25 Jul 2018 15:31:59 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=zRvz3/oLBQG/k+vomd8yVASI3e5j32SLC9oAvQNLKe8=;\n\tb=qLbhoBM/18a2N17IZ5W5fdt8i8\n\tGCvKwxbgMI14vI+VPkTh52UoH2f8sPBmvbH9yZpEXK8YNgKH30HS4FQEK3Q21/+mrUE1LVaebhKfo\n\toZBpDlDQ9jhN3EOzLKPChIdL+M1EWE/zYDywUUBLj/dpFixpauKbt4+CDj3oSWyUQb8Mrtkfz5M1U\n\tGk3Mf47bqx5FFnWS0CvgHPmNwvBY+coHq8rxIbOlOeJKQe3k8wlaOo1LJs0/yXHYySdqazfeKEQdG\n\tv5cwenZ2SiqMTFg+dOCMr/ZwnSQl7uuaznSwq2h9xCXBTWlRlIO8DcqwaYvnNqe56Qvlykb13o3wR\n\t4FMvbBmQ==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","From":"Miquel Raynal ","To":"Boris Brezillon ,\n\tRichard Weinberger ,\n\tDavid Woodhouse , \n\tBrian Norris ,\n\tMarek Vasut ","Subject":"[PATCH v5 11/17] mtd: rawnand: jz4740: convert driver to nand_scan()","Date":"Wed, 25 Jul 2018 15:31:46 +0200","Message-Id":"<20180725133152.30898-12-miquel.raynal@bootlin.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20180725133152.30898-1-miquel.raynal@bootlin.com>","References":"<20180725133152.30898-1-miquel.raynal@bootlin.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20180725_063233_476579_2470CF89 ","X-CRM114-Status":"GOOD ( 15.94 )","X-Spam-Score":"-0.0 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [62.4.15.54 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Lucas Stach , Wenyou Yang ,\n\tJosh Wu , Stefan Agner ,\n\tlinux-mtd@lists.infradead.org, Miquel Raynal ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"Two helpers have been added to the core to do all kind of controller\nside configuration/initialization between the detection phase and the\nfinal NAND scan. Implement these hooks so that we can convert the driver\nto just use nand_scan() instead of the nand_scan_ident() +\nnand_scan_tail() pair.\n\nSigned-off-by: Miquel Raynal \n---\n drivers/mtd/nand/raw/jz4740_nand.c | 32 ++++++++++++++++++++------------\n 1 file changed, 20 insertions(+), 12 deletions(-)","diff":"diff --git a/drivers/mtd/nand/raw/jz4740_nand.c b/drivers/mtd/nand/raw/jz4740_nand.c\nindex 09541608a45f..3816d56b0d01 100644\n--- a/drivers/mtd/nand/raw/jz4740_nand.c\n+++ b/drivers/mtd/nand/raw/jz4740_nand.c\n@@ -309,7 +309,6 @@ static int jz_nand_detect_bank(struct platform_device *pdev,\n \t\t\t size_t chipnr, uint8_t *nand_maf_id,\n \t\t\t uint8_t *nand_dev_id)\n {\n-\tstruct jz_nand_platform_data *pdata = dev_get_platdata(&pdev->dev);\n \tint ret;\n \tchar res_name[6];\n \tuint32_t ctrl;\n@@ -332,20 +331,10 @@ static int jz_nand_detect_bank(struct platform_device *pdev,\n \n \tif (chipnr == 0) {\n \t\t/* Detect first chip. */\n-\t\tret = nand_scan_ident(mtd, 1, NULL);\n+\t\tret = nand_scan(mtd, 1);\n \t\tif (ret)\n \t\t\tgoto notfound_id;\n \n-\t\tif (pdata && pdata->ident_callback)\n-\t\t\tpdata->ident_callback(pdev, mtd, &pdata->partitions,\n-\t\t\t\t\t &pdata->num_partitions);\n-\n-\t\tret = nand_scan_tail(mtd);\n-\t\tif (ret) {\n-\t\t\tdev_err(&pdev->dev, \"Failed to scan NAND\\n\");\n-\t\t\tgoto notfound_id;\n-\t\t}\n-\n \t\t/* Retrieve the IDs from the first chip. */\n \t\tchip->select_chip(mtd, 0);\n \n@@ -380,6 +369,24 @@ static int jz_nand_detect_bank(struct platform_device *pdev,\n \treturn ret;\n }\n \n+static int jz_nand_attach_chip(struct nand_chip *chip)\n+{\n+\tstruct mtd_info *mtd = nand_to_mtd(chip);\n+\tstruct device *dev = mtd->dev.parent;\n+\tstruct jz_nand_platform_data *pdata = dev_get_platdata(dev);\n+\tstruct platform_device *pdev = to_platform_device(dev);\n+\n+\tif (pdata && pdata->ident_callback)\n+\t\tpdata->ident_callback(pdev, mtd, &pdata->partitions,\n+\t\t\t\t &pdata->num_partitions);\n+\n+\treturn 0;\n+}\n+\n+static const struct nand_controller_ops jz_nand_controller_ops = {\n+\t.attach_chip = jz_nand_attach_chip,\n+};\n+\n static int jz_nand_probe(struct platform_device *pdev)\n {\n \tint ret;\n@@ -423,6 +430,7 @@ static int jz_nand_probe(struct platform_device *pdev)\n \tchip->chip_delay = 50;\n \tchip->cmd_ctrl = jz_nand_cmd_ctrl;\n \tchip->select_chip = jz_nand_select_chip;\n+\tchip->dummy_controller.ops = &jz_nand_controller_ops;\n \n \tif (nand->busy_gpio)\n \t\tchip->dev_ready = jz_nand_dev_ready;\n","prefixes":["v5","11/17"]}