{"id":949188,"url":"http://patchwork.ozlabs.org/api/1.2/patches/949188/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20180725133152.30898-9-miquel.raynal@bootlin.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/1.2/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20180725133152.30898-9-miquel.raynal@bootlin.com>","list_archive_url":null,"date":"2018-07-25T13:31:43","name":"[v5,08/17] mtd: rawnand: docg4: convert driver to nand_scan()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"cd4ca9f5152f876d2acf45da606b0002981db5c8","submitter":{"id":73368,"url":"http://patchwork.ozlabs.org/api/1.2/people/73368/?format=json","name":"Miquel Raynal","email":"miquel.raynal@bootlin.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20180725133152.30898-9-miquel.raynal@bootlin.com/mbox/","series":[{"id":57526,"url":"http://patchwork.ozlabs.org/api/1.2/series/57526/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=57526","date":"2018-07-25T13:31:36","name":"Allow dynamic allocations during NAND chip identification phase","version":5,"mbox":"http://patchwork.ozlabs.org/series/57526/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/949188/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/949188/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org\n\t(client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=bootlin.com","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"RiVjOoUM\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[IPv6:2607:7c80:54:e::133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41bGR55TXjz9s2M\n\tfor ;\n\tWed, 25 Jul 2018 23:34:09 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiJvV-0002Xl-PT; Wed, 25 Jul 2018 13:34:01 +0000","from mail.bootlin.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiJu4-0000Km-Tr\n\tfor linux-mtd@lists.infradead.org; Wed, 25 Jul 2018 13:32:43 +0000","by mail.bootlin.com (Postfix, from userid 110)\n\tid 3EFC120884; Wed, 25 Jul 2018 15:32:17 +0200 (CEST)","from localhost.localdomain\n\t(AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr [90.88.20.122])\n\tby mail.bootlin.com (Postfix) with ESMTPSA id 9DD4620893;\n\tWed, 25 Jul 2018 15:31:58 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=WiiscareZStdEhixRGTaB2Sx+SBl4NAMinil/RdgBLs=;\n\tb=RiVjOoUMAj58LiTESP7BmTXssB\n\tsD13PlpDARx3KzJFZ42iBXenXftGbGFeUV379GFHyYWIcNdL5Q2UrfUQRp7O2x1wPJS0R3bV0E3p9\n\tnXYsRMvgWrAJ/tfJji1bTbsA3rlFu9+03JWlnrFwe1TUugDUj0HtIpE/YiDH7/97aSOjKL/iwEF3M\n\tOdWj5JBmghSmn+K7/G3HukGSqcoBjUeVfaS5A4YO6gxMG7bIkg+8PhVz2D3QaJGvP2tYh+HyTmVOQ\n\tmmna+EvFU00Z/zAMm4Ur1I/wWEwEmOvythIuIJqnUsYaCsC0GZj3vkvZ3+QGMEMVQhIT6o1myu95w\n\tJZIBcjXg==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","From":"Miquel Raynal ","To":"Boris Brezillon ,\n\tRichard Weinberger ,\n\tDavid Woodhouse , \n\tBrian Norris ,\n\tMarek Vasut ","Subject":"[PATCH v5 08/17] mtd: rawnand: docg4: convert driver to nand_scan()","Date":"Wed, 25 Jul 2018 15:31:43 +0200","Message-Id":"<20180725133152.30898-9-miquel.raynal@bootlin.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20180725133152.30898-1-miquel.raynal@bootlin.com>","References":"<20180725133152.30898-1-miquel.raynal@bootlin.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20180725_063233_629285_F2E88E31 ","X-CRM114-Status":"GOOD ( 19.00 )","X-Spam-Score":"-0.0 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [62.4.15.54 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Lucas Stach , Wenyou Yang ,\n\tJosh Wu , Stefan Agner ,\n\tlinux-mtd@lists.infradead.org, Miquel Raynal ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"Two helpers have been added to the core to do all kind of controller\nside configuration/initialization between the detection phase and the\nfinal NAND scan. Implement these hooks so that we can convert the driver\nto just use nand_scan() instead of the nand_scan_ident() +\nnand_scan_tail() pair.\n\nSigned-off-by: Miquel Raynal \n---\n drivers/mtd/nand/raw/docg4.c | 70 ++++++++++++++++++++++++++++----------------\n 1 file changed, 45 insertions(+), 25 deletions(-)","diff":"diff --git a/drivers/mtd/nand/raw/docg4.c b/drivers/mtd/nand/raw/docg4.c\nindex 4dccdfba6140..b69a36842605 100644\n--- a/drivers/mtd/nand/raw/docg4.c\n+++ b/drivers/mtd/nand/raw/docg4.c\n@@ -1227,10 +1227,9 @@ static void __init init_mtd_structs(struct mtd_info *mtd)\n \t * required within a nand driver because they are performed by the nand\n \t * infrastructure code as part of nand_scan(). In this case they need\n \t * to be initialized here because we skip call to nand_scan_ident() (the\n-\t * first half of nand_scan()). The call to nand_scan_ident() is skipped\n-\t * because for this device the chip id is not read in the manner of a\n-\t * standard nand device. Unfortunately, nand_scan_ident() does other\n-\t * things as well, such as call nand_set_defaults().\n+\t * first half of nand_scan()). The call to nand_scan_ident() could be\n+\t * skipped because for this device the chip id is not read in the manner\n+\t * of a standard nand device.\n \t */\n \n \tstruct nand_chip *nand = mtd_to_nand(mtd);\n@@ -1315,6 +1314,40 @@ static int __init read_id_reg(struct mtd_info *mtd)\n \n static char const *part_probes[] = { \"cmdlinepart\", \"saftlpart\", NULL };\n \n+static int docg4_attach_chip(struct nand_chip *chip)\n+{\n+\tstruct mtd_info *mtd = nand_to_mtd(chip);\n+\tstruct docg4_priv *doc = (struct docg4_priv *)(chip + 1);\n+\tint ret;\n+\n+\tinit_mtd_structs(mtd);\n+\n+\t/* Initialize kernel BCH algorithm */\n+\tdoc->bch = init_bch(DOCG4_M, DOCG4_T, DOCG4_PRIMITIVE_POLY);\n+\tif (!doc->bch)\n+\t\treturn -EINVAL;\n+\n+\treset(mtd);\n+\n+\tret = read_id_reg(mtd);\n+\tif (ret)\n+\t\tfree_bch(doc->bch);\n+\n+\treturn ret;\n+}\n+\n+static void docg4_detach_chip(struct nand_chip *chip)\n+{\n+\tstruct docg4_priv *doc = (struct docg4_priv *)(chip + 1);\n+\n+\tfree_bch(doc->bch);\n+}\n+\n+static const struct nand_controller_ops docg4_controller_ops = {\n+\t.attach_chip = docg4_attach_chip,\n+\t.detach_chip = docg4_detach_chip,\n+};\n+\n static int __init probe_docg4(struct platform_device *pdev)\n {\n \tstruct mtd_info *mtd;\n@@ -1350,28 +1383,17 @@ static int __init probe_docg4(struct platform_device *pdev)\n \tmtd->dev.parent = &pdev->dev;\n \tdoc->virtadr = virtadr;\n \tdoc->dev = dev;\n-\n-\tinit_mtd_structs(mtd);\n-\n-\t/* initialize kernel bch algorithm */\n-\tdoc->bch = init_bch(DOCG4_M, DOCG4_T, DOCG4_PRIMITIVE_POLY);\n-\tif (doc->bch == NULL) {\n-\t\tretval = -EINVAL;\n-\t\tgoto free_nand;\n-\t}\n-\n \tplatform_set_drvdata(pdev, doc);\n \n-\treset(mtd);\n-\tretval = read_id_reg(mtd);\n-\tif (retval == -ENODEV) {\n-\t\tdev_warn(dev, \"No diskonchip G4 device found.\\n\");\n-\t\tgoto free_bch;\n-\t}\n-\n-\tretval = nand_scan_tail(mtd);\n+\t/*\n+\t * Running nand_scan() with maxchips == 0 will skip nand_scan_ident(),\n+\t * which is a specific operation with this driver and done in the\n+\t * ->attach_chip callback.\n+\t */\n+\tnand->dummy_controller.ops = &docg4_controller_ops;\n+\tretval = nand_scan(mtd, 0);\n \tif (retval)\n-\t\tgoto free_bch;\n+\t\tgoto free_nand;\n \n \tretval = read_factory_bbt(mtd);\n \tif (retval)\n@@ -1387,8 +1409,6 @@ static int __init probe_docg4(struct platform_device *pdev)\n \n cleanup_nand:\n \tnand_cleanup(nand);\n-free_bch:\n-\tfree_bch(doc->bch);\n free_nand:\n \tkfree(nand);\n unmap:\n","prefixes":["v5","08/17"]}