{"id":834146,"url":"http://patchwork.ozlabs.org/api/1.2/patches/834146/?format=json","web_url":"http://patchwork.ozlabs.org/project/lede/patch/1509753940-29058-1-git-send-email-greearb@candelatech.com/","project":{"id":54,"url":"http://patchwork.ozlabs.org/api/1.2/projects/54/?format=json","name":"LEDE development","link_name":"lede","list_id":"lede-dev.lists.infradead.org","list_email":"lede-dev@lists.infradead.org","web_url":"http://lede-project.org/","scm_url":"","webscm_url":"http://git.lede-project.org/","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1509753940-29058-1-git-send-email-greearb@candelatech.com>","list_archive_url":null,"date":"2017-11-04T00:05:38","name":"[LEDE-DEV,RFC,1/3] Update to latest ath10k-ct driver, enable AHB.","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"08b9f03a6278755cc9c033cd7cbf217b882c7418","submitter":{"id":852,"url":"http://patchwork.ozlabs.org/api/1.2/people/852/?format=json","name":"Ben Greear","email":"greearb@candelatech.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/lede/patch/1509753940-29058-1-git-send-email-greearb@candelatech.com/mbox/","series":[{"id":11860,"url":"http://patchwork.ozlabs.org/api/1.2/series/11860/?format=json","web_url":"http://patchwork.ozlabs.org/project/lede/list/?series=11860","date":"2017-11-04T00:05:39","name":"[LEDE-DEV,RFC,1/3] Update to latest ath10k-ct driver, enable AHB.","version":1,"mbox":"http://patchwork.ozlabs.org/series/11860/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/834146/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/834146/checks/","tags":{},"related":[],"headers":{"Return-Path":"<lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"W+ae/EtM\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yTJzP2KP3z9t1t\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat,  4 Nov 2017 11:07:13 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1eAlzT-0001mG-QR; Sat, 04 Nov 2017 00:07:11 +0000","from mail2.candelatech.com ([208.74.158.173])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1eAlyT-000196-RL\n\tfor lede-dev@lists.infradead.org; Sat, 04 Nov 2017 00:06:14 +0000","from ben-dt3.candelatech.com (firewall.candelatech.com\n\t[50.251.239.81])\n\tby mail2.candelatech.com (Postfix) with ESMTP id A6F01409E08;\n\tFri,  3 Nov 2017 17:05:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:\n\tDate:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=G9mS62RIqEhJZ9ltq+5iOjJ4Hc7gzwQS4v8bzeRQjPo=;\n\tb=W+ae/EtMjSqBfm\n\tM6AoSJ/IYOAdznJuOqFznrCyqhjLCBnl86YkBkZ5tyobEtvdhxLUrb5SKZ287pOQv4KCGmyM4IkQH\n\tXyW9OpYchxruLH0WB3DLktNxSHrjeMGe4uncN/4atRzetaokv6LFYWa+QbvZxQaMHNbi9TmDd1qgW\n\tEndYxB8vSTV8EvjnxvsVmEEZlwulvQY2tFxXZNLHbQi3ExX0FGtPCx9auby1Lb+mz9HAyMxRtnQuf\n\tZ1Cpx3kfilcKlGfcdD8JxltpP62z4DK3bdEtjJeQg6CFVpg8HVfkHqzxTIBrppwwVw4/FKEgxiEES\n\txuepCQiqG1NLPjN9Nxyw==;","From":"greearb@candelatech.com","To":"lede-dev@lists.infradead.org","Date":"Fri,  3 Nov 2017 17:05:38 -0700","Message-Id":"<1509753940-29058-1-git-send-email-greearb@candelatech.com>","X-Mailer":"git-send-email 2.4.11","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171103_170610_060892_17287798 ","X-CRM114-Status":"GOOD (  12.53  )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","Subject":"[LEDE-DEV] [RFC 1/3] Update to latest ath10k-ct driver, enable AHB.","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<lede-dev.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/lede-dev/>","List-Post":"<mailto:lede-dev@lists.infradead.org>","List-Help":"<mailto:lede-dev-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=subscribe>","Cc":"Ben Greear <greearb@candelatech.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" <lede-dev-bounces@lists.infradead.org>","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"From: Ben Greear <greearb@candelatech.com>\n\nThe driver updates include:\n\nath10k driver backport to fix WPA 'pn' related security bugs\n(4.13 based driver only currently),\na fix for off-channel TX for CT wave-1 firmware, a likely\nfix for napi related crashes, and a backport of the firmware fetch\npatch.\n\nAHB is needed for the IPQ4019 platform radios.\n\nSigned-off-by: Ben Greear <greearb@candelatech.com>\n---\n package/kernel/ath10k-ct/Makefile                  | 12 +++++---\n ...ctivate-user-space-firmware-loading-again.patch | 36 ----------------------\n 2 files changed, 7 insertions(+), 41 deletions(-)\n delete mode 100644 package/kernel/ath10k-ct/patches/130-ath10k-activate-user-space-firmware-loading-again.patch","diff":"diff --git a/package/kernel/ath10k-ct/Makefile b/package/kernel/ath10k-ct/Makefile\nindex 82d7664..5669a9f 100644\n--- a/package/kernel/ath10k-ct/Makefile\n+++ b/package/kernel/ath10k-ct/Makefile\n@@ -9,7 +9,7 @@ PKG_LICENSE_FILES:=\n PKG_SOURCE_URL:=https://github.com/greearb/ath10k-ct.git\n PKG_SOURCE_PROTO:=git\n PKG_SOURCE_DATE:=2017-06-13\n-PKG_SOURCE_VERSION:=bded1823912549017d819d1796273b3134c3de20\n+PKG_SOURCE_VERSION:=df29a72a16b54ce337b80ccc1ca0389bc1f77a6f\n PKG_MIRROR_HASH:=616174650e12a82edb6b6bd18ac186e2c6a48fdad0082df9d2011ab20940814b\n \n PKG_MAINTAINER:=Ben Greear <greearb@candelatech.com>\n@@ -29,7 +29,7 @@ include $(INCLUDE_DIR)/package.mk\n define KernelPackage/ath10k-ct\n   SUBMENU:=Wireless Drivers\n   TITLE:=ath10k-ct driver optimized for CT ath10k firmware\n-  DEPENDS:=+kmod-mac80211 +kmod-ath +@DRIVER_11N_SUPPORT +@DRIVER_11AC_SUPPORT @PCI_SUPPORT +@KERNEL_RELAY +kmod-hwmon-core\n+  DEPENDS:= @PCI_SUPPORT +kmod-ath +@DRIVER_11N_SUPPORT +@DRIVER_11AC_SUPPORT +@DRIVER_11W_SUPPORT +@KERNEL_RELAY +kmod-hwmon-core\n   FILES:=\\\n \t$(PKG_BUILD_DIR)/ath10k$(CT_KVER)/ath10k_pci.ko \\\n \t$(PKG_BUILD_DIR)/ath10k$(CT_KVER)/ath10k_core.ko\n@@ -50,9 +50,11 @@ ifdef CONFIG_PACKAGE_MAC80211_MESH\n endif\n \n CT_MAKEDEFS += CONFIG_ATH10K=m CONFIG_ATH10K_PCI=m\n-# No AHB support enabled yet.  Could conditionally enable it later.\n-#CT_MAKEDEFS += CONFIG_ATH10K_AHB=y\n-#NOSTDINC_FLAGS += -DCONFIG_ATH10K_AHB\n+\n+# This AHB logic is needed for IPQ4019 radios\n+CT_MAKEDEFS += CONFIG_ATH10K_AHB=m\n+NOSTDINC_FLAGS += -DCONFIG_ATH10K_AHB\n+\n NOSTDINC_FLAGS += -DSTANDALONE_CT\n \n ifdef CONFIG_PACKAGE_MAC80211_DEBUGFS\ndiff --git a/package/kernel/ath10k-ct/patches/130-ath10k-activate-user-space-firmware-loading-again.patch b/package/kernel/ath10k-ct/patches/130-ath10k-activate-user-space-firmware-loading-again.patch\ndeleted file mode 100644\nindex dc02a9d..0000000\n--- a/package/kernel/ath10k-ct/patches/130-ath10k-activate-user-space-firmware-loading-again.patch\n+++ /dev/null\n@@ -1,36 +0,0 @@\n-From c0cc00f250e19c717fc9cdbdb7f55aaa569c7498 Mon Sep 17 00:00:00 2001\n-From: Hauke Mehrtens <hauke@hauke-m.de>\n-Date: Thu, 24 Aug 2017 23:06:41 +0200\n-Subject: [PATCH] ath10k: activate user space firmware loading again\n-\n-In commit 9f5bcfe93315 (\"ath10k: silence firmware file probing\n-warnings\") the firmware loading was changed from request_firmware() to\n-request_firmware_direct() to silence some warnings in case it fails.\n-request_firmware_direct() directly searches in the file system only and\n-does not send a hotplug event to user space in case it could not find\n-the firmware directly.\n-In LEDE we use a user space script to extract the calibration data from\n-the flash memory which gets triggered by the hotplug event. This way the\n-firmware gets extracted from some vendor specific partition when the\n-driver requests this firmware. This mechanism does not work any more\n-after this change.\n-\n-Fixes: 9f5bcfe93315 (\"ath10k: silence firmware file probing warnings\")\n-Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>\n-Cc: Michal Kazior <michal.kazior@tieto.com>\n-Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>\n----\n- ath10k-4.13/core.c | 2 +-\n- 1 file changed, 1 insertion(+), 1 deletion(-)\n-\n---- a/ath10k-4.13/core.c\n-+++ b/ath10k-4.13/core.c\n-@@ -556,7 +556,7 @@ static const struct firmware *ath10k_fet\n- \t\tdir = \".\";\n- \n- \tsnprintf(filename, sizeof(filename), \"%s/%s\", dir, file);\n--\tret = request_firmware_direct(&fw, filename, ar->dev);\n-+\tret = request_firmware(&fw, filename, ar->dev);\n- \tath10k_dbg(ar, ATH10K_DBG_BOOT, \"boot fw request '%s': %d\\n\",\n- \t\t   filename, ret);\n- \n","prefixes":["LEDE-DEV","RFC","1/3"]}