{"id":834104,"url":"http://patchwork.ozlabs.org/api/1.2/patches/834104/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171103205630.1083-4-jakub.kicinski@netronome.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171103205630.1083-4-jakub.kicinski@netronome.com>","list_archive_url":null,"date":"2017-11-03T20:56:18","name":"[net-next,v2,03/15] bpf: report offload info to user space","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"fcd3abcef9e80f5ab53784cd8229a327ceffd75a","submitter":{"id":67484,"url":"http://patchwork.ozlabs.org/api/1.2/people/67484/?format=json","name":"Jakub Kicinski","email":"jakub.kicinski@netronome.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171103205630.1083-4-jakub.kicinski@netronome.com/mbox/","series":[{"id":11839,"url":"http://patchwork.ozlabs.org/api/1.2/series/11839/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=11839","date":"2017-11-03T20:56:15","name":"bpf: add offload as a first class citizen","version":2,"mbox":"http://patchwork.ozlabs.org/series/11839/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/834104/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/834104/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=netronome-com.20150623.gappssmtp.com\n\theader.i=@netronome-com.20150623.gappssmtp.com\n\theader.b=\"gE//fy6L\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yTDn51zvbz9s7p\n\tfor ;\n\tSat, 4 Nov 2017 07:58:01 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756052AbdKCU5x (ORCPT );\n\tFri, 3 Nov 2017 16:57:53 -0400","from mail-pg0-f66.google.com ([74.125.83.66]:44158 \"EHLO\n\tmail-pg0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753080AbdKCU4s (ORCPT\n\t); Fri, 3 Nov 2017 16:56:48 -0400","by mail-pg0-f66.google.com with SMTP id j3so3463027pga.1\n\tfor ; Fri, 03 Nov 2017 13:56:47 -0700 (PDT)","from jkicinski-Precision-T1700.netronome.com ([75.53.12.129])\n\tby smtp.gmail.com with ESMTPSA id\n\to10sm9989029pgq.69.2017.11.03.13.56.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 03 Nov 2017 13:56:46 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=netronome-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=57D06QjIRz5jD4meXoRONDHEwTDEX2k1tlUAL7NPIPM=;\n\tb=gE//fy6LABIrVkmGomQ+OSgq80LYSm6QDa/Uiv6VaBua3ukoOUDdXt2EM1pYJi9GMg\n\tJ8Jv9V6b7D97VHl7XvbET+TmH8ZuJ6JX4mM14pmXmyNKy/cvID3TAsFPraPUSZ5iydWz\n\tv5c1dRE9BDSDbkpc8+jHnPSD90QcjqpaaKmJ1UrDPOganLGBjuvNVI/mlGBafc4XiEkH\n\tNRGViG9zYcQ9JR1DY27RHLrEJ3z7aufB8x0Nhaic5eznUN6JNtgqrEXjflI0CyM4hfhn\n\tmflSfnO84hU2Xb8y93bTDkJOP6HTteG1Ye/f3qo5PmvT+REOZJxRaiu3t9Ge+wFX8Ssw\n\ttpGA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=57D06QjIRz5jD4meXoRONDHEwTDEX2k1tlUAL7NPIPM=;\n\tb=DOn8J6tHbN4u/meQy5NzC1IaPjgg5UDZOdEcgBBsRI3kcOoGyEBnv92rV+uadaRNG7\n\tMmfWEdWsmj5ZXoZk6ziva+2Dg7Aa8VwqMrtIM0T3XjX41PgJ32v4AW0ETYF3hrcbRQPx\n\tgtjN8ELhccheSp0clOOk5W1/4cAxVN32svds5hWf+2miDaa1YQD17XD16hR/+Hq5CNli\n\tS+1QZexViUJcTWgnFliW2etdAI/RibBKxtE369TF97zd5ZBgu47RvWjespT1y2/RHckx\n\tdEFqCh2utTAMlIbAi2is56KUonjSmY9pA5o6Vt08q+QpeF3ZG3h5jYpAOKSoZxgMHqjB\n\tJqUw==","X-Gm-Message-State":"AMCzsaWRMz8xdXTTeA8WM/qrQ8QJ0B44QO9ORuTnEGjqrcl0zC+R0idB\n\tXHudCI/HeIFmzQ6xsZaf3T02+YmD","X-Google-Smtp-Source":"ABhQp+RQKtbOmBXyjycP1tAZoYDpAWTTqDCED2RaYPhXAdIsJ7oXFmPS5veohcE9Nv2VBP66JSE8WA==","X-Received":"by 10.98.131.68 with SMTP id h65mr8941413pfe.148.1509742607261; \n\tFri, 03 Nov 2017 13:56:47 -0700 (PDT)","From":"Jakub Kicinski ","To":"netdev@vger.kernel.org","Cc":"oss-drivers@netronome.com, alexei.starovoitov@gmail.com,\n\tdaniel@iogearbox.net, Jakub Kicinski ","Subject":"[PATCH net-next v2 03/15] bpf: report offload info to user space","Date":"Fri, 3 Nov 2017 13:56:18 -0700","Message-Id":"<20171103205630.1083-4-jakub.kicinski@netronome.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20171103205630.1083-1-jakub.kicinski@netronome.com>","References":"<20171103205630.1083-1-jakub.kicinski@netronome.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Extend struct bpf_prog_info to contain information about program\nbeing bound to a device. Since the netdev may get destroyed while\nprogram still exists we need a flag to indicate the program is\nloaded for a device, even if the device is gone.\n\nSigned-off-by: Jakub Kicinski \nReviewed-by: Simon Horman \nReviewed-by: Quentin Monnet \n---\n include/linux/bpf.h | 1 +\n include/uapi/linux/bpf.h | 6 ++++++\n kernel/bpf/offload.c | 12 ++++++++++++\n kernel/bpf/syscall.c | 5 +++++\n 4 files changed, 24 insertions(+)","diff":"diff --git a/include/linux/bpf.h b/include/linux/bpf.h\nindex e45d43f9ec92..98bacd0fa5cc 100644\n--- a/include/linux/bpf.h\n+++ b/include/linux/bpf.h\n@@ -506,6 +506,7 @@ static inline int cpu_map_enqueue(struct bpf_cpu_map_entry *rcpu,\n \n int bpf_prog_offload_compile(struct bpf_prog *prog);\n void bpf_prog_offload_destroy(struct bpf_prog *prog);\n+u32 bpf_prog_offload_ifindex(struct bpf_prog *prog);\n \n #if defined(CONFIG_NET) && defined(CONFIG_BPF_SYSCALL)\n int bpf_prog_offload_init(struct bpf_prog *prog, union bpf_attr *attr);\ndiff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h\nindex 727a3dba13e6..e92f62cf933a 100644\n--- a/include/uapi/linux/bpf.h\n+++ b/include/uapi/linux/bpf.h\n@@ -894,6 +894,10 @@ enum sk_action {\n \n #define BPF_TAG_SIZE\t8\n \n+enum bpf_prog_status {\n+\tBPF_PROG_STATUS_DEV_BOUND\t= (1 << 0),\n+};\n+\n struct bpf_prog_info {\n \t__u32 type;\n \t__u32 id;\n@@ -907,6 +911,8 @@ struct bpf_prog_info {\n \t__u32 nr_map_ids;\n \t__aligned_u64 map_ids;\n \tchar name[BPF_OBJ_NAME_LEN];\n+\t__u32 ifindex;\n+\t__u32 status;\n } __attribute__((aligned(8)));\n \n struct bpf_map_info {\ndiff --git a/kernel/bpf/offload.c b/kernel/bpf/offload.c\nindex 5553e0e2f8b1..2816feb38be1 100644\n--- a/kernel/bpf/offload.c\n+++ b/kernel/bpf/offload.c\n@@ -144,6 +144,18 @@ int bpf_prog_offload_compile(struct bpf_prog *prog)\n \treturn bpf_prog_offload_translate(prog);\n }\n \n+u32 bpf_prog_offload_ifindex(struct bpf_prog *prog)\n+{\n+\tstruct bpf_dev_offload *offload = prog->aux->offload;\n+\tu32 ifindex;\n+\n+\trtnl_lock();\n+\tifindex = offload->netdev ? offload->netdev->ifindex : 0;\n+\trtnl_unlock();\n+\n+\treturn ifindex;\n+}\n+\n const struct bpf_prog_ops bpf_offload_prog_ops = {\n };\n \ndiff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c\nindex 1574b9f0f24e..3217c20ea91b 100644\n--- a/kernel/bpf/syscall.c\n+++ b/kernel/bpf/syscall.c\n@@ -1592,6 +1592,11 @@ static int bpf_prog_get_info_by_fd(struct bpf_prog *prog,\n \t\t\treturn -EFAULT;\n \t}\n \n+\tif (bpf_prog_is_dev_bound(prog->aux)) {\n+\t\tinfo.status |= BPF_PROG_STATUS_DEV_BOUND;\n+\t\tinfo.ifindex = bpf_prog_offload_ifindex(prog);\n+\t}\n+\n done:\n \tif (copy_to_user(uinfo, &info, info_len) ||\n \t put_user(info_len, &uattr->info.info_len))\n","prefixes":["net-next","v2","03/15"]}