{"id":833722,"url":"http://patchwork.ozlabs.org/api/1.2/patches/833722/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171103090344.19444-16-jiri@resnulli.us/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171103090344.19444-16-jiri@resnulli.us>","list_archive_url":null,"date":"2017-11-03T09:03:43","name":"[net-next,15/16] mlxsw: spectrum_ipip: Handle underlay device change","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"065355115bbd2478cb29de35eb76233524f345eb","submitter":{"id":15321,"url":"http://patchwork.ozlabs.org/api/1.2/people/15321/?format=json","name":"Jiri Pirko","email":"jiri@resnulli.us"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171103090344.19444-16-jiri@resnulli.us/mbox/","series":[{"id":11677,"url":"http://patchwork.ozlabs.org/api/1.2/series/11677/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=11677","date":"2017-11-03T09:03:28","name":"mlxsw: Handle changes in GRE configuration","version":1,"mbox":"http://patchwork.ozlabs.org/series/11677/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/833722/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/833722/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"a2zV2BXs\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySwxN482rz9sNV\n\tfor ;\n\tFri, 3 Nov 2017 20:04:08 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932936AbdKCJEG (ORCPT );\n\tFri, 3 Nov 2017 05:04:06 -0400","from mail-wm0-f67.google.com ([74.125.82.67]:54342 \"EHLO\n\tmail-wm0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932672AbdKCJD6 (ORCPT\n\t); Fri, 3 Nov 2017 05:03:58 -0400","by mail-wm0-f67.google.com with SMTP id r68so6699wmr.3\n\tfor ; Fri, 03 Nov 2017 02:03:58 -0700 (PDT)","from localhost (ip-94-113-127-32.net.upcbroadband.cz.\n\t[94.113.127.32]) by smtp.gmail.com with ESMTPSA id\n\tn2sm4307991wmd.39.2017.11.03.02.03.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 03 Nov 2017 02:03:57 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Huu+l5HWnXCYfeEVUG1MiFXzpLLOtBgm193sAIv9DCI=;\n\tb=a2zV2BXsyiOmuff3cKve06RGRVzd19hjMsR1261m0mOF2m1gu6fDvkNYQqzlitwGXz\n\tkBaL7hgIUDitrZbr1t3k1Gc/ZCYVUKU1YT6clzkraiFjz6COI/uPD0tdlT1AxGWF/Lln\n\tfBuGgtapwIEhMkKfkOId9NBiotZuj0w66bj4uTadDQGFOCaHHxVKuu6AWHVxYznb4KER\n\tLOnTSa1gwPNhJgwhFqIWSfdyE9oWoWLA3wG1+u9OtybHo4qVT4MqAHn/xF4K/MPV0gsQ\n\tmv0KP8TW/Nq7OR+DhyOGf9Fmhjx6sO7CLw76HMKQvQe4jzorF8QiBmrq1LwIlICW6lf2\n\tiIFw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Huu+l5HWnXCYfeEVUG1MiFXzpLLOtBgm193sAIv9DCI=;\n\tb=hpUerAK68uGmlQV1DwjdOvMTSbDK5+pGINBGwKrtd7L5VygTF3xxAlYfRt/yuFlslE\n\t7oYxzUj7+G4rzzhjuQtjL24wUUUt1GF6mRC5M0/b8hfz/5yxkx9L+mRuuVt5WqE7WZJc\n\t4iuBWWzOUigqFxLNYqBgJoBM2+i5vDU6EoPFWsWEpZr3KnSfu9DhAG4v8Hy6/tOMowm4\n\tW3CbZSop5AVLmsGJGVJtCQfHfl0V6qHrOMTK4iUHRXl82QhjYXapoF8yuCt/Qv+r7O1a\n\tFdCcroI4nNCDWSEqyDYt69c9R5tYc7XGWZF17aDL/7JdAS00CBAhd1YOogtPsVLaBIbv\n\tdwYQ==","X-Gm-Message-State":"AMCzsaUCAOD8HY3Rr5xhgGdpDID9301QFatgpk78jhNjDEcdlhC1Nsfh\n\thC0ypJHhQ+OvWsRF4oSGyKrwHQ30","X-Google-Smtp-Source":"ABhQp+R1VjUQPIe/h0CAk0BFvi/l6/z4qAo43Ba5iMP41X6MuzpALztb3fSqsBW4bKYtTOyS46/Ctw==","X-Received":"by 10.28.10.68 with SMTP id 65mr3395935wmk.55.1509699837530;\n\tFri, 03 Nov 2017 02:03:57 -0700 (PDT)","From":"Jiri Pirko ","To":"netdev@vger.kernel.org","Cc":"davem@davemloft.net, petrm@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com","Subject":"[patch net-next 15/16] mlxsw: spectrum_ipip: Handle underlay device\n\tchange","Date":"Fri, 3 Nov 2017 10:03:43 +0100","Message-Id":"<20171103090344.19444-16-jiri@resnulli.us>","X-Mailer":"git-send-email 2.9.5","In-Reply-To":"<20171103090344.19444-1-jiri@resnulli.us>","References":"<20171103090344.19444-1-jiri@resnulli.us>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Petr Machata \n\nWhen a bound device of an IP-in-IP tunnel changes, such as through\n'ip tunnel change name $name dev $dev', the loopback backing the tunnel\nneeds to be recreated.\n\nSigned-off-by: Petr Machata \nReviewed-by: Ido Schimmel \nSigned-off-by: Jiri Pirko \n---\n drivers/net/ethernet/mellanox/mlxsw/spectrum_ipip.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_ipip.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_ipip.c\nindex 5f78fc5..7502e53 100644\n--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_ipip.c\n+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_ipip.c\n@@ -326,8 +326,9 @@ mlxsw_sp_ipip_ol_netdev_change_gre4(struct mlxsw_sp *mlxsw_sp,\n \t\t}\n \n \t\tupdate_tunnel = true;\n-\t} else if (mlxsw_sp_ipip_parms_okey(ipip_entry->parms) !=\n-\t\t mlxsw_sp_ipip_parms_okey(new_parms)) {\n+\t} else if ((mlxsw_sp_ipip_parms_okey(ipip_entry->parms) !=\n+\t\t mlxsw_sp_ipip_parms_okey(new_parms)) ||\n+\t\t ipip_entry->parms.link != new_parms.link) {\n \t\tupdate_tunnel = true;\n \t} else if (!mlxsw_sp_l3addr_eq(&new_daddr, &old_daddr)) {\n \t\tupdate_nhs = true;\n","prefixes":["net-next","15/16"]}