{"id":833370,"url":"http://patchwork.ozlabs.org/api/1.2/patches/833370/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20171102140501.87671-12-gwalbon@linux.vnet.ibm.com/","project":{"id":15,"url":"http://patchwork.ozlabs.org/api/1.2/projects/15/?format=json","name":"Ubuntu Kernel","link_name":"ubuntu-kernel","list_id":"kernel-team.lists.ubuntu.com","list_email":"kernel-team@lists.ubuntu.com","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171102140501.87671-12-gwalbon@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-11-02T14:05:00","name":"[Artful,11/12] powerpc/perf: Add ___GFP_NOWARN flag to alloc_pages_node()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"497e196178e6eff00e6c0f470024410cffc386fb","submitter":{"id":71662,"url":"http://patchwork.ozlabs.org/api/1.2/people/71662/?format=json","name":"Gustavo Walbon","email":"gwalbon@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20171102140501.87671-12-gwalbon@linux.vnet.ibm.com/mbox/","series":[{"id":11509,"url":"http://patchwork.ozlabs.org/api/1.2/series/11509/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/list/?series=11509","date":"2017-11-02T14:04:50","name":"Backport for Power9 Nest PMU Instrumentation","version":1,"mbox":"http://patchwork.ozlabs.org/series/11509/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/833370/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/833370/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySRgf4cSYz9t2f;\n\tFri, 3 Nov 2017 01:05:34 +1100 (AEDT)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1eAG7e-0002Qo-N3; Thu, 02 Nov 2017 14:05:30 +0000","from mx0b-001b2d01.pphosted.com ([148.163.158.5]\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2)\n\t(envelope-from ) id 1eAG7c-0002MT-Pr\n\tfor kernel-team@lists.ubuntu.com; Thu, 02 Nov 2017 14:05:28 +0000","from pps.filterd (m0098420.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tvA2E4T7f103120\n\tfor ; Thu, 2 Nov 2017 10:05:27 -0400","from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2e0264jymq-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 02 Nov 2017 10:05:27 -0400","from localhost\n\tby e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ; \n\tThu, 2 Nov 2017 10:05:26 -0400","from b01cxnp23032.gho.pok.ibm.com (9.57.198.27)\n\tby e11.ny.us.ibm.com (146.89.104.198) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 2 Nov 2017 10:05:25 -0400","from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com\n\t[9.57.199.110])\n\tby b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid vA2E5OC334603098; Thu, 2 Nov 2017 14:05:24 GMT","from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 43759AE054;\n\tThu, 2 Nov 2017 10:06:11 -0400 (EDT)","from localhost (unknown [9.85.138.60])\n\tby b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP id AE596AE052;\n\tThu, 2 Nov 2017 10:06:10 -0400 (EDT)"],"From":"Gustavo Walbon ","To":"kernel-team@lists.ubuntu.com","Subject":"[Artful][PATCH 11/12] powerpc/perf: Add ___GFP_NOWARN flag to\n\talloc_pages_node()","Date":"Thu, 2 Nov 2017 12:05:00 -0200","X-Mailer":"git-send-email 2.13.3","In-Reply-To":"<20171102140501.87671-1-gwalbon@linux.vnet.ibm.com>","References":"<20171102140501.87671-1-gwalbon@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17110214-2213-0000-0000-000002356DA6","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007997; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000239; SDB=6.00940090; UDB=6.00474019;\n\tIPR=6.00720346; \n\tBA=6.00005666; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017836;\n\tXFM=3.00000015; UTC=2017-11-02 14:05:26","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17110214-2214-0000-0000-0000580A8777","Message-Id":"<20171102140501.87671-12-gwalbon@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-11-02_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501\n\tmalwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0\n\tclxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0\n\tclassifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1707230000\n\tdefinitions=main-1711020178","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "},"content":"From: Anju T Sudhakar \n\nBugLink: https://bugs.launchpad.net/bugs/1481347\n\nStack trace output during a stress test:\n [ 4.310049] Freeing initrd memory: 22592K\n[ 4.310646] rtas_flash: no firmware flash support\n[ 4.313341] cpuhp/64: page allocation failure: order:0, mode:0x14480c0(GFP_KERNEL|__GFP_ZERO|__GFP_THISNODE), nodemask=(null)\n[ 4.313465] cpuhp/64 cpuset=/ mems_allowed=0\n[ 4.313521] CPU: 64 PID: 392 Comm: cpuhp/64 Not tainted 4.11.0-39.el7a.ppc64le #1\n[ 4.313588] Call Trace:\n[ 4.313622] [c000000f1fb1b8e0] [c000000000c09388] dump_stack+0xb0/0xf0 (unreliable)\n[ 4.313694] [c000000f1fb1b920] [c00000000030ef6c] warn_alloc+0x12c/0x1c0\n[ 4.313753] [c000000f1fb1b9c0] [c00000000030ff68] __alloc_pages_nodemask+0xea8/0x1000\n[ 4.313823] [c000000f1fb1bbb0] [c000000000113a8c] core_imc_mem_init+0xbc/0x1c0\n[ 4.313892] [c000000f1fb1bc00] [c000000000113cdc] ppc_core_imc_cpu_online+0x14c/0x170\n[ 4.313962] [c000000f1fb1bc90] [c000000000125758] cpuhp_invoke_callback+0x198/0x5d0\n[ 4.314031] [c000000f1fb1bd00] [c00000000012782c] cpuhp_thread_fun+0x8c/0x3d0\n[ 4.314101] [c000000f1fb1bd60] [c0000000001678d0] smpboot_thread_fn+0x290/0x2a0\n[ 4.314169] [c000000f1fb1bdc0] [c00000000015ee78] kthread+0x168/0x1b0\n[ 4.314229] [c000000f1fb1be30] [c00000000000b368] ret_from_kernel_thread+0x5c/0x74\n[ 4.314313] Mem-Info:\n[ 4.314356] active_anon:0 inactive_anon:0 isolated_anon:0\n\ncore_imc_mem_init() at system boot use alloc_pages_node() to get memory\nand alloc_pages_node() throws this stack dump when tried to allocate\nmemory from a node which has no memory behind it. Add a ___GFP_NOWARN\nflag in allocation request as a fix.\n\nSigned-off-by: Anju T Sudhakar \nReported-by: Michael Ellerman \nReported-by: Venkat R.B \nSigned-off-by: Michael Ellerman \n(cherry-picked from cd4f2b30e5ef7d4bde61eb515372d96e8aec1690)\nSigned-off-by: Gustavo Walbon \n---\n arch/powerpc/perf/imc-pmu.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/arch/powerpc/perf/imc-pmu.c b/arch/powerpc/perf/imc-pmu.c\nindex e3a1f65933b5..39a0203fd8a5 100644\n--- a/arch/powerpc/perf/imc-pmu.c\n+++ b/arch/powerpc/perf/imc-pmu.c\n@@ -537,8 +537,8 @@ static int core_imc_mem_init(int cpu, int size)\n \n \t/* We need only vbase for core counters */\n \tmem_info->vbase = page_address(alloc_pages_node(phys_id,\n-\t\t\t\t\t GFP_KERNEL | __GFP_ZERO | __GFP_THISNODE,\n-\t\t\t\t\t get_order(size)));\n+\t\t\t\t\t GFP_KERNEL | __GFP_ZERO | __GFP_THISNODE |\n+\t\t\t\t\t __GFP_NOWARN, get_order(size)));\n \tif (!mem_info->vbase)\n \t\treturn -ENOMEM;\n \n@@ -791,8 +791,8 @@ static int thread_imc_mem_alloc(int cpu_id, int size)\n \t\t * free the memory in cpu offline path.\n \t\t */\n \t\tlocal_mem = page_address(alloc_pages_node(phys_id,\n-\t\t\t\t GFP_KERNEL | __GFP_ZERO | __GFP_THISNODE,\n-\t\t\t\t get_order(size)));\n+\t\t\t\t GFP_KERNEL | __GFP_ZERO | __GFP_THISNODE |\n+\t\t\t\t __GFP_NOWARN, get_order(size)));\n \t\tif (!local_mem)\n \t\t\treturn -ENOMEM;\n \n","prefixes":["Artful","11/12"]}