{"id":833340,"url":"http://patchwork.ozlabs.org/api/1.2/patches/833340/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20171102124731.10484-2-wsa+renesas@sang-engineering.com/","project":{"id":35,"url":"http://patchwork.ozlabs.org/api/1.2/projects/35/?format=json","name":"Linux I2C development","link_name":"linux-i2c","list_id":"linux-i2c.vger.kernel.org","list_email":"linux-i2c@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171102124731.10484-2-wsa+renesas@sang-engineering.com>","list_archive_url":null,"date":"2017-11-02T12:47:27","name":"[RFT,1/5] i2c: sh_mobile: remove redundant initialization","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"33eb2d9ce1130918ca14e8af32ca6ea6161bf501","submitter":{"id":69646,"url":"http://patchwork.ozlabs.org/api/1.2/people/69646/?format=json","name":"Wolfram Sang","email":"wsa+renesas@sang-engineering.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20171102124731.10484-2-wsa+renesas@sang-engineering.com/mbox/","series":[{"id":11496,"url":"http://patchwork.ozlabs.org/api/1.2/series/11496/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/list/?series=11496","date":"2017-11-02T12:47:26","name":"i2c: sh_mobile: refactor HW init/deinit","version":1,"mbox":"http://patchwork.ozlabs.org/series/11496/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/833340/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/833340/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySPxw5lkqz9t2l\n\tfor ;\n\tThu, 2 Nov 2017 23:47:48 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754804AbdKBMrr (ORCPT );\n\tThu, 2 Nov 2017 08:47:47 -0400","from sauhun.de ([88.99.104.3]:33850 \"EHLO pokefinder.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752966AbdKBMrl (ORCPT );\n\tThu, 2 Nov 2017 08:47:41 -0400","from localhost (p54B33C39.dip0.t-ipconnect.de [84.179.60.57])\n\tby pokefinder.org (Postfix) with ESMTPSA id 20F872C3229;\n\tThu, 2 Nov 2017 13:47:40 +0100 (CET)"],"From":"Wolfram Sang ","To":"linux-i2c@vger.kernel.org","Cc":"linux-renesas-soc@vger.kernel.org,\n\tYoshihiro Shimoda ,\n\tJacopo Mondi ,\n\tWolfram Sang ","Subject":"[PATCH RFT 1/5] i2c: sh_mobile: remove redundant initialization","Date":"Thu, 2 Nov 2017 13:47:27 +0100","Message-Id":"<20171102124731.10484-2-wsa+renesas@sang-engineering.com>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20171102124731.10484-1-wsa+renesas@sang-engineering.com>","References":"<20171102124731.10484-1-wsa+renesas@sang-engineering.com>","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"},"content":"Following the documentation, we initialize the HW before each START in\nstart_ch(). No need to do the same in activate_ch().\n\nSigned-off-by: Wolfram Sang \n---\n drivers/i2c/busses/i2c-sh_mobile.c | 10 ----------\n 1 file changed, 10 deletions(-)","diff":"diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c\nindex 6f2aaeb7c4fa15..9d073e99c7e72d 100644\n--- a/drivers/i2c/busses/i2c-sh_mobile.c\n+++ b/drivers/i2c/busses/i2c-sh_mobile.c\n@@ -303,16 +303,6 @@ static void activate_ch(struct sh_mobile_i2c_data *pd)\n \t/* Wake up device and enable clock */\n \tpm_runtime_get_sync(pd->dev);\n \tclk_prepare_enable(pd->clk);\n-\n-\t/* Enable channel and configure rx ack */\n-\tiic_set_clr(pd, ICCR, ICCR_ICE, 0);\n-\n-\t/* Mask all interrupts */\n-\tiic_wr(pd, ICIC, 0);\n-\n-\t/* Set the clock */\n-\tiic_wr(pd, ICCL, pd->iccl & 0xff);\n-\tiic_wr(pd, ICCH, pd->icch & 0xff);\n }\n \n static void deactivate_ch(struct sh_mobile_i2c_data *pd)\n","prefixes":["RFT","1/5"]}