{"id":833308,"url":"http://patchwork.ozlabs.org/api/1.2/patches/833308/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ide/patch/20171102111952.4021454-1-arnd@arndb.de/","project":{"id":13,"url":"http://patchwork.ozlabs.org/api/1.2/projects/13/?format=json","name":"Linux IDE development","link_name":"linux-ide","list_id":"linux-ide.vger.kernel.org","list_email":"linux-ide@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171102111952.4021454-1-arnd@arndb.de>","list_archive_url":null,"date":"2017-11-02T11:19:32","name":"block: fix CDROM dependency on BLK_DEV","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"08b30265aebea8fd44fdff444d0f08540ebcbe0f","submitter":{"id":30,"url":"http://patchwork.ozlabs.org/api/1.2/people/30/?format=json","name":"Arnd Bergmann","email":"arnd@arndb.de"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/linux-ide/patch/20171102111952.4021454-1-arnd@arndb.de/mbox/","series":[{"id":11483,"url":"http://patchwork.ozlabs.org/api/1.2/series/11483/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ide/list/?series=11483","date":"2017-11-02T11:19:32","name":"block: fix CDROM dependency on BLK_DEV","version":1,"mbox":"http://patchwork.ozlabs.org/series/11483/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/833308/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/833308/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ide-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySN0x6pd8z9s8J\n\tfor ;\n\tThu, 2 Nov 2017 22:20:17 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755230AbdKBLUQ (ORCPT );\n\tThu, 2 Nov 2017 07:20:16 -0400","from mout.kundenserver.de ([217.72.192.75]:56302 \"EHLO\n\tmout.kundenserver.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752865AbdKBLUP (ORCPT\n\t); Thu, 2 Nov 2017 07:20:15 -0400","from wuerfel.lan ([109.193.157.232]) by mrelayeu.kundenserver.de\n\t(mreue105 [212.227.15.145]) with ESMTPA (Nemesis) id\n\t0LrKaC-1d9Ggy1B7M-013904; Thu, 02 Nov 2017 12:19:56 +0100"],"From":"Arnd Bergmann ","To":"Jens Axboe ","Cc":"Arnd Bergmann , \"David S. Miller\" ,\n\t\"James E.J. Bottomley\" ,\n\t\"Martin K. Petersen\" ,\n\tBart Van Assche ,\n\tHannes Reinecke , linux-ide@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org","Subject":"[PATCH] block: fix CDROM dependency on BLK_DEV","Date":"Thu, 2 Nov 2017 12:19:32 +0100","Message-Id":"<20171102111952.4021454-1-arnd@arndb.de>","X-Mailer":"git-send-email 2.9.0","X-Provags-ID":"V03:K0:oZFCru2LmMp7rkSgHsVHmG7fJ4295wQs1p5Vt19klhkgLRcZNhx\n\t++KP4XaFtwRN97wRVu1RP3ELjWLtp9L0kbPtPVroRMx9YWBxwBO9a08N7j2PVqdfvPq/F+b\n\tBOCdelY0mz76Ns2fS8iwZgsBofSts1xwWWTVC/QGA0Ncqst2hEtxICn4F2qEOcPMtL6BrVi\n\tG9OjlHlNYTfAu5W2tqAtA==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:ttSNPnIsqm8=:HNR37xmXoYqRTGbhOUX+94\n\tF95P3s0LBqhy1ORs5KWA05nPJmrPaL86ttbyu7J3cBv2+MDx7l9ppyebUmRruHIuDLxgYL2Ch\n\tAHQFdTCVgJAegPPoAGG8IbQFTHjqX5nerldJLjFtDtGXFllh7NwzTvWx+LgXR1lzVHQ4azmvQ\n\tM68s9JD+xUv5X7LSwOT8ZgN/daB6fNAWEh7uVRv7XJfRKXFVKwJgKoPFsOoS+hO338clIMX0Y\n\twJmFcneluJfg1B7IyAYCeP0kWFqY1dugwHLSFcpImbTNpyrcaF/KooohWhck1x5GqlGcY6Po2\n\tqmwhPUqlo1BydPT5TGJOFgw4V7ab1dU5vOpdxdOgr8Vm+8rAfFSPoT1ZkV+V5xqE3o+njTxwC\n\tBv4NtelIFAsd6UXd4f9MxcnVptuDC6U7WVR417Sqr3PtzUfbuVVNXBwsX4v8UxbAN7eBbslNW\n\tIiemQ5ifkMGWVnftZ4VBV+WAQ/iyUTgWjSFvZaGkD68PzELen3pM3MykKyqHgduYhJtNbXQl7\n\tQpMZ2vpZO/GyM06//Iq+QahXsi22VO3SYoWQ9zoKudsxLvVh5S5AxHZ9ozlTyYxqnOLK0giGY\n\tyuQjwbLZh3j0yLS7+JGO8PTIgI0MHWJvuhRoANUF1RUdP+R2SmUYoX3TDTRfTK012Qbl8u7Bd\n\tBwogPr8Kc/iW6HVpCzRZcVPHeO1OSl06iK39RQXx18wOXyGBB7BDkrSLcIPVSdAeIjcsrvXMP\n\txnz0QJ9EQMGVXlkHm4BaB+968Vn/wCxsF7XBLQ==","Sender":"linux-ide-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ide@vger.kernel.org"},"content":"After the cdrom cleanup, I get randconfig warnings for some configurations:\n\nwarning: (BLK_DEV_IDECD && BLK_DEV_SR) selects CDROM which has unmet direct dependencies (BLK_DEV)\n\nThis adds an explicit BLK_DEV dependency for both drivers. The other\ndrivers that select 'CDROM' already have this and don't need a change.\n\nFixes: 2a750166a5be (\"block: Rework drivers/cdrom/Makefile\")\nSigned-off-by: Arnd Bergmann \n---\n drivers/ide/Kconfig | 1 +\n drivers/scsi/Kconfig | 2 +-\n 2 files changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig\nindex 7b92c591e4c1..cf1fb3fb5d26 100644\n--- a/drivers/ide/Kconfig\n+++ b/drivers/ide/Kconfig\n@@ -117,6 +117,7 @@ config BLK_DEV_DELKIN\n \n config BLK_DEV_IDECD\n \ttristate \"Include IDE/ATAPI CDROM support\"\n+\tdepends on BLK_DEV\n \tselect IDE_ATAPI\n \tselect CDROM\n \t---help---\ndiff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig\nindex 1f98f666d2ef..8a739b74cfb7 100644\n--- a/drivers/scsi/Kconfig\n+++ b/drivers/scsi/Kconfig\n@@ -130,7 +130,7 @@ config CHR_DEV_OSST\n \n config BLK_DEV_SR\n \ttristate \"SCSI CDROM support\"\n-\tdepends on SCSI\n+\tdepends on SCSI && BLK_DEV\n \tselect CDROM\n \t---help---\n \t If you want to use a CD or DVD drive attached to your computer\n","prefixes":[]}