{"id":833288,"url":"http://patchwork.ozlabs.org/api/1.2/patches/833288/?format=json","web_url":"http://patchwork.ozlabs.org/project/patchwork/patch/20171102102844.18931-4-stephen@that.guru/","project":{"id":16,"url":"http://patchwork.ozlabs.org/api/1.2/projects/16/?format=json","name":"Patchwork","link_name":"patchwork","list_id":"patchwork.lists.ozlabs.org","list_email":"patchwork@lists.ozlabs.org","web_url":"http://jk.ozlabs.org/projects/patchwork/","scm_url":"git://github.com/getpatchwork/patchwork","webscm_url":"https://github.com/getpatchwork/patchwork","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171102102844.18931-4-stephen@that.guru>","list_archive_url":null,"date":"2017-11-02T10:28:38","name":"[v2,3/9] trivial: noqa imports dotted through urls","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ef9c28f151e6512cf5bac155df9312073bb89f20","submitter":{"id":69991,"url":"http://patchwork.ozlabs.org/api/1.2/people/69991/?format=json","name":"Stephen Finucane","email":"stephen@that.guru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/patchwork/patch/20171102102844.18931-4-stephen@that.guru/mbox/","series":[{"id":11467,"url":"http://patchwork.ozlabs.org/api/1.2/series/11467/?format=json","web_url":"http://patchwork.ozlabs.org/project/patchwork/list/?series=11467","date":"2017-11-02T10:28:35","name":"Add support for Django 1.11","version":2,"mbox":"http://patchwork.ozlabs.org/series/11467/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/833288/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/833288/checks/","tags":{},"related":[],"headers":{"Return-Path":"<patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","patchwork@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ySM8Y1cJWz9t34\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu,  2 Nov 2017 21:41:49 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3ySM8X6pC6zDr6M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu,  2 Nov 2017 21:41:48 +1100 (AEDT)","from butterfly.maple.relay.mailchannels.net\n\t(butterfly.maple.relay.mailchannels.net [23.83.214.27])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3ySM4D1SDYzDr62\n\tfor <patchwork@lists.ozlabs.org>;\n\tThu,  2 Nov 2017 21:38:03 +1100 (AEDT)","from relay.mailchannels.net (localhost [127.0.0.1])\n\tby relay.mailchannels.net (Postfix) with ESMTP id 9D43E5C1A0D\n\tfor <patchwork@lists.ozlabs.org>;\n\tThu,  2 Nov 2017 10:29:03 +0000 (UTC)","from one.mxroute.com (unknown [100.96.149.26])\n\t(Authenticated sender: mxroute)\n\tby relay.mailchannels.net (Postfix) with ESMTPA id 3574B5C138F\n\tfor <patchwork@lists.ozlabs.org>;\n\tThu,  2 Nov 2017 10:29:03 +0000 (UTC)","from one.mxroute.com (one-outgoing.mxroute.com [172.20.113.32])\n\t(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)\n\tby 0.0.0.0:2500 (trex/5.9.14); Thu, 02 Nov 2017 10:29:03 +0000"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"pV7g/KpP\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"pV7g/KpP\"; dkim-atps=neutral","ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=that.guru\n\t(client-ip=23.83.214.27; helo=butterfly.maple.relay.mailchannels.net; \n\tenvelope-from=stephen@that.guru; receiver=<UNKNOWN>)","lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"pV7g/KpP\"; dkim-atps=neutral"],"X-Sender-Id":["mxroute|x-authuser|stephen@that.guru","mxroute|x-authuser|stephen@that.guru"],"X-MC-Relay":"Neutral","X-MailChannels-SenderId":"mxroute|x-authuser|stephen@that.guru","X-MailChannels-Auth-Id":"mxroute","X-Ruddy-Interest":"2f9ef4fc7dbd1554_1509618543457_4040562439","X-MC-Loop-Signature":"1509618543457:153424683","X-MC-Ingress-Time":"1509618543456","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=that.guru;\n\ts=default;\n\th=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:\n\tSender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:\n\tContent-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:\n\tResent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:\n\tList-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=243Q8rxRwtcgCfgfbkyzTXN6cHAUzo7I9V8NQ+W2JNs=;\n\tb=pV7g/KpP4wtaOr8PYH6BvrNc5w\n\tAisd9GgL6o8UOLkW2QidHEiDwr2bPxzlEw93yE8jZ88Jeon3DjH1rZ8gMvKo4jbHtFhMoUsp2Uevq\n\tzsM0cJ2phOzUjMXzfrehZ2mSFekkKarBeFWkCee3FSQJulauhdrOH3pybp3PeqLa1PKcDyPplXcx2\n\tvNXcjCBLVDVo5d/l+H5xxCUOpyK7Jyg+qBH+2iM/rfH4/l2Qq3Nl1qYatLq8EZ1flp3gMfD2VTljR\n\tmraloIFYSRjdcpcOTdgj3AXtPMhp8EbGSTZDmMp5Jur9nbBsTYrjpVjGGcN5eYqfeyddrilzxbH35\n\th0Hx8Tkg==;","From":"Stephen Finucane <stephen@that.guru>","To":"patchwork@lists.ozlabs.org","Subject":"[PATCH v2 3/9] trivial: noqa imports dotted through urls","Date":"Thu,  2 Nov 2017 10:28:38 +0000","Message-Id":"<20171102102844.18931-4-stephen@that.guru>","X-Mailer":"git-send-email 2.13.6","In-Reply-To":"<20171102102844.18931-1-stephen@that.guru>","References":"<20171102102844.18931-1-stephen@that.guru>","X-AuthUser":"stephen@that.guru","X-BeenThere":"patchwork@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Patchwork development <patchwork.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/patchwork>,\n\t<mailto:patchwork-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/patchwork/>","List-Post":"<mailto:patchwork@lists.ozlabs.org>","List-Help":"<mailto:patchwork-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/patchwork>,\n\t<mailto:patchwork-request@lists.ozlabs.org?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Patchwork\"\n\t<patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"},"content":"There are two imports not located in the top of the file due to how we\nuse them. 'noqa' these to prevent issues with static code analysers.\n\nSigned-off-by: Stephen Finucane <stephen@that.guru>\n---\n patchwork/urls.py | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)","diff":"diff --git a/patchwork/urls.py b/patchwork/urls.py\nindex b33b01c4..6d49d648 100644\n--- a/patchwork/urls.py\n+++ b/patchwork/urls.py\n@@ -188,7 +188,7 @@ urlpatterns += [\n ]\n \n if 'debug_toolbar' in settings.INSTALLED_APPS:\n-    import debug_toolbar\n+    import debug_toolbar  # noqa\n \n     urlpatterns += [\n         url(r'^__debug__/', include(debug_toolbar.urls)),\n@@ -211,16 +211,16 @@ if settings.ENABLE_REST_API:\n         raise RuntimeError(\n             'djangorestframework must be installed to enable the REST API.')\n \n-    from patchwork.api import bundle as api_bundle_views\n-    from patchwork.api import check as api_check_views\n-    from patchwork.api import cover as api_cover_views\n-    from patchwork.api import event as api_event_views\n-    from patchwork.api import index as api_index_views\n-    from patchwork.api import patch as api_patch_views\n-    from patchwork.api import person as api_person_views\n-    from patchwork.api import project as api_project_views\n-    from patchwork.api import series as api_series_views\n-    from patchwork.api import user as api_user_views\n+    from patchwork.api import bundle as api_bundle_views  # noqa\n+    from patchwork.api import check as api_check_views  # noqa\n+    from patchwork.api import cover as api_cover_views  # noqa\n+    from patchwork.api import event as api_event_views  # noqa\n+    from patchwork.api import index as api_index_views  # noqa\n+    from patchwork.api import patch as api_patch_views  # noqa\n+    from patchwork.api import person as api_person_views  # noqa\n+    from patchwork.api import project as api_project_views  # noqa\n+    from patchwork.api import series as api_series_views  # noqa\n+    from patchwork.api import user as api_user_views  # noqa\n \n     api_patterns = [\n         url(r'^$',\n","prefixes":["v2","3/9"]}