{"id":833270,"url":"http://patchwork.ozlabs.org/api/1.2/patches/833270/?format=json","web_url":"http://patchwork.ozlabs.org/project/devicetree-bindings/patch/20171102095918.7041-1-sakari.ailus@linux.intel.com/","project":{"id":37,"url":"http://patchwork.ozlabs.org/api/1.2/projects/37/?format=json","name":"Devicetree Bindings","link_name":"devicetree-bindings","list_id":"devicetree.vger.kernel.org","list_email":"devicetree@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171102095918.7041-1-sakari.ailus@linux.intel.com>","list_archive_url":null,"date":"2017-11-02T09:59:18","name":"[RESEND,1/1] of: Make return types of to_of_node and of_fwnode_handle macros consistent","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"2462449a13ae6a3ca99ba9e21bb0e00e69345aab","submitter":{"id":65485,"url":"http://patchwork.ozlabs.org/api/1.2/people/65485/?format=json","name":"Sakari Ailus","email":"sakari.ailus@linux.intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/devicetree-bindings/patch/20171102095918.7041-1-sakari.ailus@linux.intel.com/mbox/","series":[{"id":11464,"url":"http://patchwork.ozlabs.org/api/1.2/series/11464/?format=json","web_url":"http://patchwork.ozlabs.org/project/devicetree-bindings/list/?series=11464","date":"2017-11-02T09:59:18","name":"[RESEND,1/1] of: Make return types of to_of_node and of_fwnode_handle macros consistent","version":1,"mbox":"http://patchwork.ozlabs.org/series/11464/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/833270/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/833270/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySLCZ0CBBz9t2V\n\tfor ;\n\tThu, 2 Nov 2017 20:59:22 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752970AbdKBJ7U (ORCPT\n\t);\n\tThu, 2 Nov 2017 05:59:20 -0400","from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:52592 \"EHLO\n\thillosipuli.retiisi.org.uk\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1752237AbdKBJ7U (ORCPT\n\t); Thu, 2 Nov 2017 05:59:20 -0400","from lanttu.localdomain (unknown\n\t[IPv6:2001:1bc8:1a6:d3d5::e1:1002])\n\tby hillosipuli.retiisi.org.uk (Postfix) with ESMTP id C80F1600E4;\n\tThu, 2 Nov 2017 11:59:18 +0200 (EET)"],"From":"Sakari Ailus ","To":"devicetree@vger.kernel.org, mchehab@s-opensource.com","Cc":"linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com,\n\trobh@kernel.org, hyun.kwon@xilinx.com, soren.brinkmann@xilinx.com,\n\tlinux-arm-kernel@lists.infradead.org","Subject":"[RESEND PATCH 1/1] of: Make return types of to_of_node and\n\tof_fwnode_handle macros consistent","Date":"Thu, 2 Nov 2017 11:59:18 +0200","Message-Id":"<20171102095918.7041-1-sakari.ailus@linux.intel.com>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<2117711.dO2rQLXOup@avalon>","References":"<2117711.dO2rQLXOup@avalon>","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"},"content":"(Fixed Mauro's e-mail.)\n\nto_of_node() macro checks whether the fwnode_handle passed to it is not an\nOF node, and if so, returns NULL in order to be NULL-safe. Otherwise it\nreturns the pointer to the OF node which the fwnode_handle contains.\n\nThe problem with returning NULL is that its type was void *, which\nsometimes matters. Explicitly return struct device_node * instead.\n\nMake a similar change to of_fwnode_handle() as well.\n\nFixes: d20dc1493db4 (\"of: Support const and non-const use for to_of_node()\")\nFixes: debd3a3b27c7 (\"of: Make of_fwnode_handle() safer\")\nSigned-off-by: Sakari Ailus \n---\nHi Mauro,\n\nCould you check whether this addresses the smatch issue with the xilinx\ndriver?\n\nThanks.\n\n include/linux/of.h | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/include/linux/of.h b/include/linux/of.h\nindex b240ed69dc96..0651231c115e 100644\n--- a/include/linux/of.h\n+++ b/include/linux/of.h\n@@ -161,7 +161,7 @@ static inline bool is_of_node(const struct fwnode_handle *fwnode)\n \t\tis_of_node(__to_of_node_fwnode) ?\t\t\t\\\n \t\t\tcontainer_of(__to_of_node_fwnode,\t\t\\\n \t\t\t\t struct device_node, fwnode) :\t\\\n-\t\t\tNULL;\t\t\t\t\t\t\\\n+\t\t\t(struct device_node *)NULL;\t\t\t\\\n \t})\n \n #define of_fwnode_handle(node)\t\t\t\t\t\t\\\n@@ -169,7 +169,8 @@ static inline bool is_of_node(const struct fwnode_handle *fwnode)\n \t\ttypeof(node) __of_fwnode_handle_node = (node);\t\t\\\n \t\t\t\t\t\t\t\t\t\\\n \t\t__of_fwnode_handle_node ?\t\t\t\t\\\n-\t\t\t&__of_fwnode_handle_node->fwnode : NULL;\t\\\n+\t\t\t&__of_fwnode_handle_node->fwnode :\t\t\\\n+\t\t\t(struct fwnode_handle *)NULL;\t\t\t\\\n \t})\n \n static inline bool of_have_populated_dt(void)\n","prefixes":["RESEND","1/1"]}