{"id":833268,"url":"http://patchwork.ozlabs.org/api/1.2/patches/833268/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/patch/1e446a0e-3928-d4b5-d916-b25ae3d4b6f5@users.sourceforge.net/","project":{"id":9,"url":"http://patchwork.ozlabs.org/api/1.2/projects/9/?format=json","name":"Linux RTC development","link_name":"rtc-linux","list_id":"linux-rtc.vger.kernel.org","list_email":"linux-rtc@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1e446a0e-3928-d4b5-d916-b25ae3d4b6f5@users.sourceforge.net>","list_archive_url":null,"date":"2017-11-02T09:50:08","name":"rtc-ds1302: Use common error handling code in ds1302_probe()","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"fc9d9c04c968e25e59048349762892d4d53035a8","submitter":{"id":65077,"url":"http://patchwork.ozlabs.org/api/1.2/people/65077/?format=json","name":"SF Markus Elfring","email":"elfring@users.sourceforge.net"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/rtc-linux/patch/1e446a0e-3928-d4b5-d916-b25ae3d4b6f5@users.sourceforge.net/mbox/","series":[{"id":11462,"url":"http://patchwork.ozlabs.org/api/1.2/series/11462/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/list/?series=11462","date":"2017-11-02T09:50:08","name":"rtc-ds1302: Use common error handling code in ds1302_probe()","version":1,"mbox":"http://patchwork.ozlabs.org/series/11462/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/833268/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/833268/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySL1B23Xfz9t30\n\tfor ;\n\tThu, 2 Nov 2017 20:50:22 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755193AbdKBJuV (ORCPT );\n\tThu, 2 Nov 2017 05:50:21 -0400","from mout.web.de ([212.227.15.14]:49763 \"EHLO mout.web.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752560AbdKBJuU (ORCPT );\n\tThu, 2 Nov 2017 05:50:20 -0400","from [192.168.1.3] ([78.49.200.43]) by smtp.web.de (mrweb003\n\t[213.165.67.108]) with ESMTPSA (Nemesis) id 0M09eO-1dI5W92AFI-00uK8b;\n\tThu, 02 Nov 2017 10:50:09 +0100"],"To":"linux-rtc@vger.kernel.org, Alessandro Zummo ,\n\tAlexandre Belloni ","Cc":"LKML , kernel-janitors@vger.kernel.org","From":"SF Markus Elfring ","Subject":"[PATCH] rtc-ds1302: Use common error handling code in ds1302_probe()","Message-ID":"<1e446a0e-3928-d4b5-d916-b25ae3d4b6f5@users.sourceforge.net>","Date":"Thu, 2 Nov 2017 10:50:08 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","X-Provags-ID":"V03:K0:jnGoTDP7OiCq+cmFc8FxSL2w8NZ4GtNVxap3EwSYG4BPW3N3igW\n\tWnlbAGw+TqN5eTmh0cU3CM/VpirJCZI9/5mrN01+BFIC7vheUfrLcDFKiXPgTSAOTh0LKj2\n\tPyI1PHT0w/z+u/sEGAUFWVmMMuJpswEu7E3QLy52q0dIG6mmV9xxQdIy/OqavHdt+yDq27Y\n\tiHCGskHvr/0BuC3D8jUPA==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:McTL86oO6k4=:M/Vlf8Oy9Rd7c2b6L8x/1E\n\tdraMPIwKBmvzaEXs3tR6oFHnbWI8JQVYUlkhq5OIgkW1UCb4gjRS9zN/PgcXPuRc1HjgdUFnA\n\tnDP6MgExP6dFFyE3ZWmBFjLWjPowUGNM4ew9IZ2YdoPqgNkL0HhRRyRlEPaxKVXDkYRy4r1/s\n\t5WGyOTavyf/usw30x4ThUCWYvbZxV/U6ICDSsCuZsjmfUCFuHcAoEus+Fk5CDQRRWMfnrqjGs\n\tTt1s3ede0bLOjeADznid7XELZOO/pX7kEHH0ErO2M9gZehdHcuwW3nBAOd7lZMYrxzOebumY8\n\tpbcvuoXDJCcP0jyWBUOxJiOPksINe4dcYYtR00ugQtH6Cff6dHRV1x4oguN0P9wNfEpbe/xeZ\n\tkEPxBWNwxf8Maf/ybnbPhFX7qhp1p6sO7EtnaS1BONrkR9qte4hbDH6b5EBr8QMCOxFsZ5kQP\n\tdudaX8c9Djh2JdjFlOCZTjHSujuMqkJdK8K4ZC6cuAX3n21e/ZOB+CC4CUPiRcUz/4QPl+whh\n\tAZpPQhtnMXW6LME24jlSaRxfPzSXhUJ+EkyiU0t66Y72AlfApm0DiEdtHf89ypyMdt3qoSEoe\n\tRpRt7KtmI/k9rrinnpIVgaWifTs7aXuIas8CFiyYTUCy9KcgFBYL+ZKZVBoQ2j1hffe9yg7FC\n\tgy4oCibopt9CY/JKO3S5N5e+pEhsbqTmsD34dHECY9rIXGwYrC4AxXp9mZYC1NwWwqrbQ2Y51\n\tY9yIHBHRxtCl/qDEZlBBgzHYZbS2mOgZ1zDlSNm4YEBjcLNFGkdxWrHsp/LaOoCyZ+iLzB+iL\n\tyd86EJ9shjZGQ2hFi4magGJ6EDhYtTwzOPuPx+KBNUotK7vlR0=","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"},"content":"From: Markus Elfring \nDate: Thu, 2 Nov 2017 10:45:08 +0100\n\n* Add a jump target so that a specific error message is stored only once\n at the end of this function implementation.\n\n* Replace two calls of the function \"dev_err\" by goto statements.\n\n* Adjust two condition checks.\n\nThis issue was detected by using the Coccinelle software.\n\nSigned-off-by: Markus Elfring \n---\n drivers/rtc/rtc-ds1302.c | 18 ++++++++----------\n 1 file changed, 8 insertions(+), 10 deletions(-)","diff":"diff --git a/drivers/rtc/rtc-ds1302.c b/drivers/rtc/rtc-ds1302.c\nindex 0ec4be62322b..06ef64736ac3 100644\n--- a/drivers/rtc/rtc-ds1302.c\n+++ b/drivers/rtc/rtc-ds1302.c\n@@ -132,19 +132,13 @@ static int ds1302_probe(struct spi_device *spi)\n \n \taddr = RTC_ADDR_CTRL << 1 | RTC_CMD_READ;\n \tstatus = spi_write_then_read(spi, &addr, sizeof(addr), buf, 1);\n-\tif (status < 0) {\n-\t\tdev_err(&spi->dev, \"control register read error %d\\n\",\n-\t\t\t\tstatus);\n-\t\treturn status;\n-\t}\n+\tif (status)\n+\t\tgoto report_read_failure;\n \n \tif ((buf[0] & ~RTC_CMD_WRITE_DISABLE) != 0) {\n \t\tstatus = spi_write_then_read(spi, &addr, sizeof(addr), buf, 1);\n-\t\tif (status < 0) {\n-\t\t\tdev_err(&spi->dev, \"control register read error %d\\n\",\n-\t\t\t\t\tstatus);\n-\t\t\treturn status;\n-\t\t}\n+\t\tif (status)\n+\t\t\tgoto report_read_failure;\n \n \t\tif ((buf[0] & ~RTC_CMD_WRITE_DISABLE) != 0) {\n \t\t\tdev_err(&spi->dev, \"junk in control register\\n\");\n@@ -189,6 +183,10 @@ static int ds1302_probe(struct spi_device *spi)\n \t}\n \n \treturn 0;\n+\n+report_read_failure:\n+\tdev_err(&spi->dev, \"control register read error %d\\n\", status);\n+\treturn status;\n }\n \n static int ds1302_remove(struct spi_device *spi)\n","prefixes":[]}