{"id":833260,"url":"http://patchwork.ozlabs.org/api/1.2/patches/833260/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/patch/8733cf61-1c1a-cc3b-a6e9-37b9a5f8cc70@users.sourceforge.net/","project":{"id":9,"url":"http://patchwork.ozlabs.org/api/1.2/projects/9/?format=json","name":"Linux RTC development","link_name":"rtc-linux","list_id":"linux-rtc.vger.kernel.org","list_email":"linux-rtc@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<8733cf61-1c1a-cc3b-a6e9-37b9a5f8cc70@users.sourceforge.net>","list_archive_url":null,"date":"2017-11-02T09:16:39","name":"rtc-da9063: Use common error handling code in da9063_rtc_probe()","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"9c1a86d65352c109c229747bb9a3b976829d99fb","submitter":{"id":65077,"url":"http://patchwork.ozlabs.org/api/1.2/people/65077/?format=json","name":"SF Markus Elfring","email":"elfring@users.sourceforge.net"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/rtc-linux/patch/8733cf61-1c1a-cc3b-a6e9-37b9a5f8cc70@users.sourceforge.net/mbox/","series":[{"id":11456,"url":"http://patchwork.ozlabs.org/api/1.2/series/11456/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/list/?series=11456","date":"2017-11-02T09:16:39","name":"rtc-da9063: Use common error handling code in da9063_rtc_probe()","version":1,"mbox":"http://patchwork.ozlabs.org/series/11456/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/833260/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/833260/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySKGb2CMHz9sNw\n\tfor ;\n\tThu, 2 Nov 2017 20:16:55 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754859AbdKBJQy (ORCPT );\n\tThu, 2 Nov 2017 05:16:54 -0400","from mout.web.de ([212.227.15.3]:64502 \"EHLO mout.web.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752560AbdKBJQx (ORCPT );\n\tThu, 2 Nov 2017 05:16:53 -0400","from [192.168.1.3] ([78.49.200.43]) by smtp.web.de (mrweb003\n\t[213.165.67.108]) with ESMTPSA (Nemesis) id 0MfYoV-1dlfVb3gFf-00P6YO;\n\tThu, 02 Nov 2017 10:16:41 +0100"],"To":"linux-rtc@vger.kernel.org, support.opensource@diasemi.com,\n\tAlessandro Zummo ,\n\tAlexandre Belloni ","Cc":"LKML , kernel-janitors@vger.kernel.org","From":"SF Markus Elfring ","Subject":"[PATCH] rtc-da9063: Use common error handling code in\n\tda9063_rtc_probe()","Message-ID":"<8733cf61-1c1a-cc3b-a6e9-37b9a5f8cc70@users.sourceforge.net>","Date":"Thu, 2 Nov 2017 10:16:39 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","X-Provags-ID":"V03:K0:rHt1MpBsBAGk41om9mCBjgTHCkefAqXwNd71eThCjWgDLnLolLV\n\tCcB0wyKSEtrP6XGAzAGWB7S+zBSdqEexoI6M1eakku9Bxkqz1sDXPdCksDVjwN20gkw1CHO\n\tZxwkXK4jjoFcIAFdckvfIHXQZGt80YelxgJ71k7D9IaqG8BObZx8pJIyM/Lz+aJEQxPnVKW\n\tzVlAhACxpLy0zl85F9e3g==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:6eTNhxI263M=:hu8idQEZOFg1v4JFf+omyu\n\tjgyZ7Cgig3aZcdXRTfmjZMhRUH4Cf9Z/I8SkqT0dgrnS4OW6GZNDuPx5iRWUCgqjNLHLCqj7z\n\tnN/rbbzQpCe2IBDDcqfLgmSRtqjCktvvyt3Q9f/Xqk1y/hfp/UEy1yXWac8xppA7X1Eif/mYs\n\tldMggA4YQOLHd8WsfnToM7h/zMCkSUDCGmMLRDKyTog8sdnJXL9SD7AL2/KH1zP6Ms7ZwRm18\n\tgbrMpOZq0tIp/1ye9dvXEQdCKc2iYfG4naLJkfupdpgiWjfTRrA/stjiorm6KxPu2IpCUjKyg\n\tMVJpBqNSvgXm2RMn6o7zE/0pDBCY3QQ0YASNRmb0Sg5g4GRyQ08Joo2YnwzBW/vzm6kOy+du1\n\tVuqdUVMr7Is/MJcTs0TJ82xSF17p+32zOIGUFpcegwEWxMTfLHQQhJIPhZ4BWzvKH/ufIRnia\n\tOeODkvT8NkfVGgiL9d4Jk9eCXiuF9NcO0DjI0yUqPc2EE55aUYg+YYYOSBIk8NgEEfrxLakGh\n\tQ68pUdqJ7Uy3A2jBGIYv78pNU3IfxSR9jm7i4eSZAYbpSBrzgR7CCKD1D+IEQPLP638xEc9hF\n\tryEpp6AWPrN32U8Fk0tdhVsC7zVYuktuHQ+kBUE+9eHKtAKKNjyYRqK9hx7dIj0tzfcrMnf7p\n\tSLJ4gRaN1ltUEtwwc3Y6J5IhtXY3a+L/36zloJpXJQ5OpnQPcIZ0m5hTEvlvW4N0M3Wkyl6IJ\n\t/CyOcsbci3W2Vobg9x1U1xEPZatVA70YTWbGRgt/VfO8+dh7XhARGvr72SuYcfgDqdMtFO69K\n\tn1mk3kzJCig///3ZpRtrRg6RAUh7wwWfZqkFcCohD9cvUqcyL0=","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"},"content":"From: Markus Elfring \nDate: Thu, 2 Nov 2017 09:45:46 +0100\n\n* Add a jump target so that a specific error message is stored only once\n at the end of this function implementation.\n\n* Replace two calls of the function \"dev_err\" by goto statements.\n\n* Adjust two condition checks.\n\nThis issue was detected by using the Coccinelle software.\n\nSigned-off-by: Markus Elfring \n---\n drivers/rtc/rtc-da9063.c | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c\nindex f85cae240f12..c5cbd40666aa 100644\n--- a/drivers/rtc/rtc-da9063.c\n+++ b/drivers/rtc/rtc-da9063.c\n@@ -436,19 +436,15 @@ static int da9063_rtc_probe(struct platform_device *pdev)\n \t\t\t\t config->rtc_alarm_secs_reg,\n \t\t\t\t config->rtc_alarm_status_mask,\n \t\t\t\t 0);\n-\tif (ret < 0) {\n-\t\tdev_err(&pdev->dev, \"Failed to access RTC alarm register\\n\");\n-\t\treturn ret;\n-\t}\n+\tif (ret)\n+\t\tgoto report_access_failure;\n \n \tret = regmap_update_bits(rtc->regmap,\n \t\t\t\t config->rtc_alarm_secs_reg,\n \t\t\t\t DA9063_ALARM_STATUS_ALARM,\n \t\t\t\t DA9063_ALARM_STATUS_ALARM);\n-\tif (ret < 0) {\n-\t\tdev_err(&pdev->dev, \"Failed to access RTC alarm register\\n\");\n-\t\treturn ret;\n-\t}\n+\tif (ret)\n+\t\tgoto report_access_failure;\n \n \tret = regmap_update_bits(rtc->regmap,\n \t\t\t\t config->rtc_alarm_year_reg,\n@@ -490,6 +486,10 @@ static int da9063_rtc_probe(struct platform_device *pdev)\n \t\t\tirq_alarm, ret);\n \n \treturn ret;\n+\n+report_access_failure:\n+\tdev_err(&pdev->dev, \"Failed to access RTC alarm register\\n\");\n+\treturn ret;\n }\n \n static struct platform_driver da9063_rtc_driver = {\n","prefixes":[]}