{"id":833248,"url":"http://patchwork.ozlabs.org/api/1.2/patches/833248/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171102080945.7436-1-bhole_prashant_q7@lab.ntt.co.jp/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171102080945.7436-1-bhole_prashant_q7@lab.ntt.co.jp>","list_archive_url":null,"date":"2017-11-02T08:09:45","name":"[net-next] tools: bpf: handle long path in jit disasm","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"0f9fbfdd37be37c403b20095c3b30b9bbe83131f","submitter":{"id":72702,"url":"http://patchwork.ozlabs.org/api/1.2/people/72702/?format=json","name":"Prashant Bhole","email":"bhole_prashant_q7@lab.ntt.co.jp"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171102080945.7436-1-bhole_prashant_q7@lab.ntt.co.jp/mbox/","series":[{"id":11452,"url":"http://patchwork.ozlabs.org/api/1.2/series/11452/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=11452","date":"2017-11-02T08:09:45","name":"[net-next] tools: bpf: handle long path in jit disasm","version":1,"mbox":"http://patchwork.ozlabs.org/series/11452/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/833248/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/833248/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySHpr0D1Cz9t2f\n\tfor ;\n\tThu, 2 Nov 2017 19:11:16 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S933145AbdKBILM (ORCPT );\n\tThu, 2 Nov 2017 04:11:12 -0400","from tama50.ecl.ntt.co.jp ([129.60.39.147]:43574 \"EHLO\n\ttama50.ecl.ntt.co.jp\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S933120AbdKBILJ (ORCPT\n\t); Thu, 2 Nov 2017 04:11:09 -0400","from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154])\n\tby tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id vA28Aqhk017894; \n\tThu, 2 Nov 2017 17:10:52 +0900","from vc2.ecl.ntt.co.jp (localhost [127.0.0.1])\n\tby vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 994A260293;\n\tThu, 2 Nov 2017 17:10:52 +0900 (JST)","from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp\n\t[129.60.87.134])\n\tby vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 8C64660292;\n\tThu, 2 Nov 2017 17:10:52 +0900 (JST)","from jcms-pop21.ecl.ntt.co.jp (unknown [129.60.241.220])\n\tby jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 871D1400A80;\n\tThu, 2 Nov 2017 17:10:52 +0900 (JST)"],"From":"Prashant Bhole ","Subject":"[PATCH net-next] tools: bpf: handle long path in jit disasm","Date":"Thu, 2 Nov 2017 17:09:45 +0900","Message-Id":"<20171102080945.7436-1-bhole_prashant_q7@lab.ntt.co.jp>","X-Mailer":"git-send-email 2.14.2","To":"\"David S . Miller\" ","Cc":"Prashant Bhole ,\n\tnetdev@vger.kernel.org, Alexei Starovoitov ,\n\tDaniel Borkmann ","X-TM-AS-MML":"disable","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use PATH_MAX instead of hardcoded array size 256\n\nSigned-off-by: Prashant Bhole \n---\n tools/bpf/bpf_jit_disasm.c | 3 ++-\n tools/bpf/bpftool/jit_disasm.c | 3 ++-\n 2 files changed, 4 insertions(+), 2 deletions(-)","diff":"diff --git a/tools/bpf/bpf_jit_disasm.c b/tools/bpf/bpf_jit_disasm.c\nindex 422d9abd666a..75bf526a0168 100644\n--- a/tools/bpf/bpf_jit_disasm.c\n+++ b/tools/bpf/bpf_jit_disasm.c\n@@ -27,6 +27,7 @@\n #include \n #include \n #include \n+#include \n \n #define CMD_ACTION_SIZE_BUFFER\t\t10\n #define CMD_ACTION_READ_ALL\t\t3\n@@ -51,7 +52,7 @@ static void get_exec_path(char *tpath, size_t size)\n static void get_asm_insns(uint8_t *image, size_t len, int opcodes)\n {\n \tint count, i, pc = 0;\n-\tchar tpath[256];\n+\tchar tpath[PATH_MAX];\n \tstruct disassemble_info info;\n \tdisassembler_ftype disassemble;\n \tbfd *bfdf;\ndiff --git a/tools/bpf/bpftool/jit_disasm.c b/tools/bpf/bpftool/jit_disasm.c\nindex 5937e134e408..1551d3918d4c 100644\n--- a/tools/bpf/bpftool/jit_disasm.c\n+++ b/tools/bpf/bpftool/jit_disasm.c\n@@ -21,6 +21,7 @@\n #include \n #include \n #include \n+#include \n \n #include \"json_writer.h\"\n #include \"main.h\"\n@@ -80,7 +81,7 @@ void disasm_print_insn(unsigned char *image, ssize_t len, int opcodes)\n \tdisassembler_ftype disassemble;\n \tstruct disassemble_info info;\n \tint count, i, pc = 0;\n-\tchar tpath[256];\n+\tchar tpath[PATH_MAX];\n \tbfd *bfdf;\n \n \tif (!len)\n","prefixes":["net-next"]}