{"id":833244,"url":"http://patchwork.ozlabs.org/api/1.2/patches/833244/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171102075917.2780-2-bhole_prashant_q7@lab.ntt.co.jp/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171102075917.2780-2-bhole_prashant_q7@lab.ntt.co.jp>","list_archive_url":null,"date":"2017-11-02T07:59:15","name":"[net-next,V2,1/3] tools: bpftool: open pinned object without type check","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"d9e06ae394f8778eee96097041f8346c1f89809a","submitter":{"id":72702,"url":"http://patchwork.ozlabs.org/api/1.2/people/72702/?format=json","name":"Prashant Bhole","email":"bhole_prashant_q7@lab.ntt.co.jp"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171102075917.2780-2-bhole_prashant_q7@lab.ntt.co.jp/mbox/","series":[{"id":11451,"url":"http://patchwork.ozlabs.org/api/1.2/series/11451/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=11451","date":"2017-11-02T07:59:15","name":"tools: bpftool: show filenames of pinned objects","version":2,"mbox":"http://patchwork.ozlabs.org/series/11451/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/833244/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/833244/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySHbL63FFz9t2f\n\tfor ;\n\tThu, 2 Nov 2017 19:01:18 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755629AbdKBIBP (ORCPT );\n\tThu, 2 Nov 2017 04:01:15 -0400","from tama500.ecl.ntt.co.jp ([129.60.39.148]:33062 \"EHLO\n\ttama500.ecl.ntt.co.jp\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755601AbdKBIBM (ORCPT\n\t); Thu, 2 Nov 2017 04:01:12 -0400","from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154])\n\tby tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id vA280r1c021323;\n\tThu, 2 Nov 2017 17:00:53 +0900","from vc2.ecl.ntt.co.jp (localhost [127.0.0.1])\n\tby vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 848DA60283;\n\tThu, 2 Nov 2017 17:00:53 +0900 (JST)","from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp\n\t[129.60.87.134])\n\tby vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 775395F69F;\n\tThu, 2 Nov 2017 17:00:53 +0900 (JST)","from jcms-pop21.ecl.ntt.co.jp (unknown [129.60.241.220])\n\tby jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 713D6400A80;\n\tThu, 2 Nov 2017 17:00:53 +0900 (JST)"],"From":"Prashant Bhole ","Subject":"[PATCH net-next V2 1/3] tools: bpftool: open pinned object without\n\ttype check","Date":"Thu, 2 Nov 2017 16:59:15 +0900","Message-Id":"<20171102075917.2780-2-bhole_prashant_q7@lab.ntt.co.jp>","X-Mailer":"git-send-email 2.14.2","In-Reply-To":"<20171102075917.2780-1-bhole_prashant_q7@lab.ntt.co.jp>","References":"<20171102075917.2780-1-bhole_prashant_q7@lab.ntt.co.jp>","To":"\"David S . Miller\" ","Cc":"Prashant Bhole ,\n\tnetdev@vger.kernel.org, Alexei Starovoitov ,\n\tDaniel Borkmann ,\n\tQuentin Monnet ,\n\tJakub Kicinski ","X-TM-AS-MML":"disable","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"This was needed for opening any file in bpf-fs without knowing\nits object type\n\nSigned-off-by: Prashant Bhole \n---\n tools/bpf/bpftool/common.c | 15 +++++++++++++--\n tools/bpf/bpftool/main.h | 1 +\n 2 files changed, 14 insertions(+), 2 deletions(-)","diff":"diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c\nindex f0288269dae8..4556947709ee 100644\n--- a/tools/bpf/bpftool/common.c\n+++ b/tools/bpf/bpftool/common.c\n@@ -91,9 +91,8 @@ static int mnt_bpffs(const char *target, char *buff, size_t bufflen)\n \treturn 0;\n }\n \n-int open_obj_pinned_any(char *path, enum bpf_obj_type exp_type)\n+int open_obj_pinned(char *path)\n {\n-\tenum bpf_obj_type type;\n \tint fd;\n \n \tfd = bpf_obj_get(path);\n@@ -105,6 +104,18 @@ int open_obj_pinned_any(char *path, enum bpf_obj_type exp_type)\n \t\treturn -1;\n \t}\n \n+\treturn fd;\n+}\n+\n+int open_obj_pinned_any(char *path, enum bpf_obj_type exp_type)\n+{\n+\tenum bpf_obj_type type;\n+\tint fd;\n+\n+\tfd = open_obj_pinned(path);\n+\tif (fd < 0)\n+\t\treturn -1;\n+\n \ttype = get_fd_type(fd);\n \tif (type < 0) {\n \t\tclose(fd);\ndiff --git a/tools/bpf/bpftool/main.h b/tools/bpf/bpftool/main.h\nindex d315d01be645..4b5685005cb0 100644\n--- a/tools/bpf/bpftool/main.h\n+++ b/tools/bpf/bpftool/main.h\n@@ -86,6 +86,7 @@ int cmd_select(const struct cmd *cmds, int argc, char **argv,\n int get_fd_type(int fd);\n const char *get_fd_type_name(enum bpf_obj_type type);\n char *get_fdinfo(int fd, const char *key);\n+int open_obj_pinned(char *path);\n int open_obj_pinned_any(char *path, enum bpf_obj_type exp_type);\n int do_pin_any(int argc, char **argv, int (*get_fd_by_id)(__u32));\n \n","prefixes":["net-next","V2","1/3"]}