{"id":833228,"url":"http://patchwork.ozlabs.org/api/1.2/patches/833228/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20171102070312.18903-17-lsahlber@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.2/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171102070312.18903-17-lsahlber@redhat.com>","list_archive_url":null,"date":"2017-11-02T07:03:09","name":"[16/19] cifs: remove rfc1002 header from smb2_set_info_req","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"35fdfce465e9d749b7cc4df22de3f7c004a4d329","submitter":{"id":72324,"url":"http://patchwork.ozlabs.org/api/1.2/people/72324/?format=json","name":"Ronnie Sahlberg","email":"lsahlber@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20171102070312.18903-17-lsahlber@redhat.com/mbox/","series":[{"id":11445,"url":"http://patchwork.ozlabs.org/api/1.2/series/11445/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=11445","date":"2017-11-02T07:03:12","name":"cifs: remove rfc1002 header from all smb2 requests","version":1,"mbox":"http://patchwork.ozlabs.org/series/11445/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/833228/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/833228/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=lsahlber@redhat.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySGLM01vFz9sRW\n\tfor ;\n\tThu, 2 Nov 2017 18:04:59 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752865AbdKBHE5 (ORCPT );\n\tThu, 2 Nov 2017 03:04:57 -0400","from mx1.redhat.com ([209.132.183.28]:57256 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1754513AbdKBHEz (ORCPT );\n\tThu, 2 Nov 2017 03:04:55 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6140B883A2;\n\tThu, 2 Nov 2017 07:04:55 +0000 (UTC)","from test1190.test.redhat.com (vpn2-54-17.bne.redhat.com\n\t[10.64.54.17])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 226DE60602;\n\tThu, 2 Nov 2017 07:04:53 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6140B883A2","From":"Ronnie Sahlberg ","To":"linux-cifs ","Cc":"Steve French ","Subject":"[PATCH 16/19] cifs: remove rfc1002 header from smb2_set_info_req","Date":"Thu, 2 Nov 2017 18:03:09 +1100","Message-Id":"<20171102070312.18903-17-lsahlber@redhat.com>","In-Reply-To":"<20171102070312.18903-1-lsahlber@redhat.com>","References":"<20171102070312.18903-1-lsahlber@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tThu, 02 Nov 2017 07:04:55 +0000 (UTC)","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"},"content":"Signed-off-by: Ronnie Sahlberg \n---\n fs/cifs/smb2pdu.c | 18 ++++++++----------\n fs/cifs/smb2pdu.h | 2 +-\n 2 files changed, 9 insertions(+), 11 deletions(-)","diff":"diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c\nindex 9a1b8e3d8704..d85f60067c02 100644\n--- a/fs/cifs/smb2pdu.c\n+++ b/fs/cifs/smb2pdu.c\n@@ -3116,6 +3116,7 @@ send_set_info(const unsigned int xid, struct cifs_tcon *tcon,\n \tunsigned int i;\n \tstruct cifs_ses *ses = tcon->ses;\n \tint flags = 0;\n+\tunsigned int total_len;\n \n \tif (!ses || !(ses->server))\n \t\treturn -EIO;\n@@ -3127,7 +3128,7 @@ send_set_info(const unsigned int xid, struct cifs_tcon *tcon,\n \tif (!iov)\n \t\treturn -ENOMEM;\n \n-\trc = small_smb2_init(SMB2_SET_INFO, tcon, (void **) &req);\n+\trc = smb2_plain_req_init(SMB2_SET_INFO, tcon, (void **) &req, &total_len);\n \tif (rc) {\n \t\tkfree(iov);\n \t\treturn rc;\n@@ -3136,7 +3137,7 @@ send_set_info(const unsigned int xid, struct cifs_tcon *tcon,\n \tif (encryption_required(tcon))\n \t\tflags |= CIFS_TRANSFORM_REQ;\n \n-\treq->hdr.sync_hdr.ProcessId = cpu_to_le32(pid);\n+\treq->sync_hdr.ProcessId = cpu_to_le32(pid);\n \n \treq->InfoType = info_type;\n \treq->FileInfoClass = info_class;\n@@ -3144,27 +3145,24 @@ send_set_info(const unsigned int xid, struct cifs_tcon *tcon,\n \treq->VolatileFileId = volatile_fid;\n \treq->AdditionalInformation = cpu_to_le32(additional_info);\n \n-\t/* 4 for RFC1001 length and 1 for Buffer */\n+\t/* 1 for Buffer */\n \treq->BufferOffset =\n-\t\t\tcpu_to_le16(sizeof(struct smb2_set_info_req) - 1 - 4);\n+\t\t\tcpu_to_le16(sizeof(struct smb2_set_info_req) - 1);\n \treq->BufferLength = cpu_to_le32(*size);\n \n-\tinc_rfc1001_len(req, *size - 1 /* Buffer */);\n-\n \tmemcpy(req->Buffer, *data, *size);\n+\ttotal_len += *size;\n \n \tiov[0].iov_base = (char *)req;\n-\t/* 4 for RFC1001 length */\n-\tiov[0].iov_len = get_rfc1002_length(req) + 4;\n+\tiov[0].iov_len = total_len;\n \n \tfor (i = 1; i < num; i++) {\n-\t\tinc_rfc1001_len(req, size[i]);\n \t\tle32_add_cpu(&req->BufferLength, size[i]);\n \t\tiov[i].iov_base = (char *)data[i];\n \t\tiov[i].iov_len = size[i];\n \t}\n \n-\trc = SendReceive2(xid, ses, iov, num, &resp_buftype, flags, &rsp_iov);\n+\trc = SendReceive3(xid, ses, iov, num, &resp_buftype, flags, &rsp_iov);\n \tcifs_small_buf_release(req);\n \trsp = (struct smb2_set_info_rsp *)rsp_iov.iov_base;\n \ndiff --git a/fs/cifs/smb2pdu.h b/fs/cifs/smb2pdu.h\nindex 7f2a7639ea15..f0d6e637b95f 100644\n--- a/fs/cifs/smb2pdu.h\n+++ b/fs/cifs/smb2pdu.h\n@@ -1013,7 +1013,7 @@ struct smb2_query_info_rsp {\n } __packed;\n \n struct smb2_set_info_req {\n-\tstruct smb2_hdr hdr;\n+\tstruct smb2_sync_hdr sync_hdr;\n \t__le16 StructureSize; /* Must be 33 */\n \t__u8 InfoType;\n \t__u8 FileInfoClass;\n","prefixes":["16/19"]}