{"id":833218,"url":"http://patchwork.ozlabs.org/api/1.2/patches/833218/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20171102070312.18903-12-lsahlber@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.2/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171102070312.18903-12-lsahlber@redhat.com>","list_archive_url":null,"date":"2017-11-02T07:03:04","name":"[11/19] cifs: remove rfc1002 header from smb2_flush_req","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4e2dc737a03c681fa589af4a2a030a532340f718","submitter":{"id":72324,"url":"http://patchwork.ozlabs.org/api/1.2/people/72324/?format=json","name":"Ronnie Sahlberg","email":"lsahlber@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20171102070312.18903-12-lsahlber@redhat.com/mbox/","series":[{"id":11445,"url":"http://patchwork.ozlabs.org/api/1.2/series/11445/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=11445","date":"2017-11-02T07:03:12","name":"cifs: remove rfc1002 header from all smb2 requests","version":1,"mbox":"http://patchwork.ozlabs.org/series/11445/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/833218/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/833218/checks/","tags":{},"related":[],"headers":{"Return-Path":"<linux-cifs-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=lsahlber@redhat.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySGK42zY5z9sRW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu,  2 Nov 2017 18:03:52 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752966AbdKBHDu (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tThu, 2 Nov 2017 03:03:50 -0400","from mx1.redhat.com ([209.132.183.28]:56176 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1755356AbdKBHDo (ORCPT <rfc822;linux-cifs@vger.kernel.org>);\n\tThu, 2 Nov 2017 03:03:44 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D1C95883B8;\n\tThu,  2 Nov 2017 07:03:43 +0000 (UTC)","from test1190.test.redhat.com (vpn2-54-17.bne.redhat.com\n\t[10.64.54.17])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C7D246061B;\n\tThu,  2 Nov 2017 07:03:42 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D1C95883B8","From":"Ronnie Sahlberg <lsahlber@redhat.com>","To":"linux-cifs <linux-cifs@vger.kernel.org>","Cc":"Steve French <smfrench@gmail.com>","Subject":"[PATCH 11/19] cifs: remove rfc1002 header from smb2_flush_req","Date":"Thu,  2 Nov 2017 18:03:04 +1100","Message-Id":"<20171102070312.18903-12-lsahlber@redhat.com>","In-Reply-To":"<20171102070312.18903-1-lsahlber@redhat.com>","References":"<20171102070312.18903-1-lsahlber@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tThu, 02 Nov 2017 07:03:44 +0000 (UTC)","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-cifs.vger.kernel.org>","X-Mailing-List":"linux-cifs@vger.kernel.org"},"content":"Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>\n---\n fs/cifs/smb2pdu.c | 8 ++++----\n fs/cifs/smb2pdu.h | 2 +-\n 2 files changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c\nindex 1e012713d79b..b49e0028cf4f 100644\n--- a/fs/cifs/smb2pdu.c\n+++ b/fs/cifs/smb2pdu.c\n@@ -2425,13 +2425,14 @@ SMB2_flush(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid,\n \tint resp_buftype;\n \tint rc = 0;\n \tint flags = 0;\n+\tunsigned int total_len;\n \n \tcifs_dbg(FYI, \"Flush\\n\");\n \n \tif (!ses || !(ses->server))\n \t\treturn -EIO;\n \n-\trc = small_smb2_init(SMB2_FLUSH, tcon, (void **) &req);\n+\trc = smb2_plain_req_init(SMB2_FLUSH, tcon, (void **) &req, &total_len);\n \tif (rc)\n \t\treturn rc;\n \n@@ -2442,10 +2443,9 @@ SMB2_flush(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid,\n \treq->VolatileFileId = volatile_fid;\n \n \tiov[0].iov_base = (char *)req;\n-\t/* 4 for rfc1002 length field */\n-\tiov[0].iov_len = get_rfc1002_length(req) + 4;\n+\tiov[0].iov_len = total_len;\n \n-\trc = SendReceive2(xid, ses, iov, 1, &resp_buftype, flags, &rsp_iov);\n+\trc = SendReceive3(xid, ses, iov, 1, &resp_buftype, flags, &rsp_iov);\n \tcifs_small_buf_release(req);\n \n \tif (rc != 0)\ndiff --git a/fs/cifs/smb2pdu.h b/fs/cifs/smb2pdu.h\nindex 6e1874a81014..a8102e5f4ebb 100644\n--- a/fs/cifs/smb2pdu.h\n+++ b/fs/cifs/smb2pdu.h\n@@ -812,7 +812,7 @@ struct smb2_close_rsp {\n } __packed;\n \n struct smb2_flush_req {\n-\tstruct smb2_hdr hdr;\n+\tstruct smb2_sync_hdr sync_hdr;\n \t__le16 StructureSize;\t/* Must be 24 */\n \t__le16 Reserved1;\n \t__le32 Reserved2;\n","prefixes":["11/19"]}