{"id":833144,"url":"http://patchwork.ozlabs.org/api/1.2/patches/833144/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1509580792-4096-1-git-send-email-yihung.wei@gmail.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.2/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1509580792-4096-1-git-send-email-yihung.wei@gmail.com>","list_archive_url":null,"date":"2017-11-01T23:59:52","name":"[ovs-dev,v2] ofproto/trace: Fix memory leak in oftrace_push_ct_state()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5f720d21f7f483c263c882566e96446a8aac34d6","submitter":{"id":70435,"url":"http://patchwork.ozlabs.org/api/1.2/people/70435/?format=json","name":"Yi-Hung Wei","email":"yihung.wei@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1509580792-4096-1-git-send-email-yihung.wei@gmail.com/mbox/","series":[{"id":11413,"url":"http://patchwork.ozlabs.org/api/1.2/series/11413/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=11413","date":"2017-11-01T23:59:52","name":"[ovs-dev,v2] ofproto/trace: Fix memory leak in oftrace_push_ct_state()","version":2,"mbox":"http://patchwork.ozlabs.org/series/11413/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/833144/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/833144/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"LJY2J/cG\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yS4zV4DZVz9t4Z\n\tfor ;\n\tThu, 2 Nov 2017 11:03:02 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 2118BAD5;\n\tThu, 2 Nov 2017 00:03:01 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id F0865A7B\n\tfor ; Thu, 2 Nov 2017 00:02:59 +0000 (UTC)","from mail-pg0-f67.google.com (mail-pg0-f67.google.com\n\t[74.125.83.67])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id A503B1DF\n\tfor ; Thu, 2 Nov 2017 00:02:59 +0000 (UTC)","by mail-pg0-f67.google.com with SMTP id 15so3449927pgc.12\n\tfor ; Wed, 01 Nov 2017 17:02:59 -0700 (PDT)","from vm-01.eng.vmware.com ([208.91.1.34])\n\tby smtp.gmail.com with ESMTPSA id\n\ti187sm2800845pfc.96.2017.11.01.17.02.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 01 Nov 2017 17:02:58 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=AZIollRT8ZhRgsZzwk0DEKr4Fpj1F9/zje7lel1XQVk=;\n\tb=LJY2J/cGNO6Z7mL6PPZNuPPUi+LTYjf5KsOnwSX1vE+PFTh31ChaZFwDDek304Upt7\n\tSlzunuk1mdQoPAsmxG2LIucnYz2DwonpN3BFAj1D0ZnjkzYMRZNh2uCoT+MiJOZocr1C\n\twk6o9AhUtIZheKkP8O+cKxd1WQt1cpfCdCyfgTuNgUmBoCP6OxDKXWMKp+IK1Lc8caZn\n\tenFTxv2PXsXQ44oLG8Q7Azx5bfgyOu2c0TinQrD7lEitsOyzqq96fR8IpkXFWN95EeQJ\n\t9ee7y1By6IWEppyfRC2y3chiyagL0CVwmRpGJMvdmCy8WlzAxKEZgWhTy3chHjmsK9ut\n\tfDhg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=AZIollRT8ZhRgsZzwk0DEKr4Fpj1F9/zje7lel1XQVk=;\n\tb=e9/VpCeIZ274KltQCWLhKYmdIg7I/aLFluxRyIDjxfZKGmnDGaA7zYJCWOP0jPfHrl\n\thZ901S87e+FoykjkCXA1/jtYu4qyZyZJapsu7za/FVIPUqcQ7qvxLi8319B6oq9wg4DP\n\ttXkN1xX7i8y9y3jHSGoXU2UZzRKNkQ8FrCOGo9lq487jr2JYsFqxwxXVJzQC6eFoWnH8\n\tEdBn9aJIh8y9cHYSRkXTkhj8xL/N5cgkzChv9rdquoTWRgepBNycipsXDrlyWbSfRxX5\n\tsu0Ub+DJFdqH50T1yXjI0hSEeuo766pkUpY/TcbmqAw4II3zOQuviSPL5pxkCOPljDyn\n\t7VcQ==","X-Gm-Message-State":"AMCzsaXmoE+TTg7egUVXLLApjA8aKFsAz5xiOf5iLNdY3E74bM+iGvny\n\tdvTBtTgrxYyrd+xidH9Pn3Hz425e","X-Google-Smtp-Source":"ABhQp+SNGqwbgUebDJ5dOzve7Trt7oaGlkITl7e/JpTjxUevcqAd4u3RmKwn8SR0WnF9EuEgHj+WMQ==","X-Received":"by 10.159.253.9 with SMTP id p9mr1252336pls.344.1509580978859;\n\tWed, 01 Nov 2017 17:02:58 -0700 (PDT)","From":"Yi-Hung Wei ","To":"dev@openvswitch.org","Date":"Wed, 1 Nov 2017 16:59:52 -0700","Message-Id":"<1509580792-4096-1-git-send-email-yihung.wei@gmail.com>","X-Mailer":"git-send-email 2.7.4","X-Spam-Status":"No, score=0.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"[ovs-dev] [PATCH v2] ofproto/trace: Fix memory leak in\n\toftrace_push_ct_state()","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"Free the allocated memory in the pop function.\n\nFixes: 0f2f05bbcf743 (\"ofproto/trace: Add --ct-next option to ofproto/trace\")\nSigned-off-by: Yi-Hung Wei \n---\n ofproto/ofproto-dpif-trace.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/ofproto/ofproto-dpif-trace.c b/ofproto/ofproto-dpif-trace.c\nindex d8a559ab6394..d5da48e326bb 100644\n--- a/ofproto/ofproto-dpif-trace.c\n+++ b/ofproto/ofproto-dpif-trace.c\n@@ -135,7 +135,9 @@ oftrace_pop_ct_state(struct ovs_list *next_ct_states)\n {\n struct oftrace_next_ct_state *s;\n LIST_FOR_EACH_POP (s, node, next_ct_states) {\n- return s->state;\n+ uint32_t state = s->state;\n+ free(s);\n+ return state;\n }\n OVS_NOT_REACHED();\n }\n","prefixes":["ovs-dev","v2"]}