{"id":832958,"url":"http://patchwork.ozlabs.org/api/1.2/patches/832958/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1509547642-51110-10-git-send-email-lipeng321@huawei.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1509547642-51110-10-git-send-email-lipeng321@huawei.com>","list_archive_url":null,"date":"2017-11-01T14:47:22","name":"[net-next,9/9] net: hns3: hns3:fix a bug about statistic counter in reset process","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"54bb410dc6878dccf4d1661d490c4621fad32ceb","submitter":{"id":71468,"url":"http://patchwork.ozlabs.org/api/1.2/people/71468/?format=json","name":"lipeng (Y)","email":"lipeng321@huawei.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1509547642-51110-10-git-send-email-lipeng321@huawei.com/mbox/","series":[{"id":11334,"url":"http://patchwork.ozlabs.org/api/1.2/series/11334/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=11334","date":"2017-11-01T14:47:14","name":"net: hns3: add support for reset","version":1,"mbox":"http://patchwork.ozlabs.org/series/11334/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/832958/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/832958/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yRr5z511zz9sRn\n\tfor ;\n\tThu, 2 Nov 2017 01:22:47 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754726AbdKAOVN (ORCPT );\n\tWed, 1 Nov 2017 10:21:13 -0400","from szxga06-in.huawei.com ([45.249.212.32]:38430 \"EHLO huawei.com\"\n\trhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1754687AbdKAOVM (ORCPT );\n\tWed, 1 Nov 2017 10:21:12 -0400","from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59])\n\tby Forcepoint Email with ESMTP id 07E58E78DD692;\n\tWed, 1 Nov 2017 22:20:59 +0800 (CST)","from linux-ioko.site (10.71.200.31) by\n\tDGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP\n\tServer id 14.3.361.1; Wed, 1 Nov 2017 22:19:52 +0800"],"From":"Lipeng ","To":"","CC":", ,\n\t, ,\n\t, ","Subject":"[PATCH net-next 9/9] net: hns3: hns3:fix a bug about statistic\n\tcounter in reset process","Date":"Wed, 1 Nov 2017 22:47:22 +0800","Message-ID":"<1509547642-51110-10-git-send-email-lipeng321@huawei.com>","X-Mailer":"git-send-email 1.9.1","In-Reply-To":"<1509547642-51110-1-git-send-email-lipeng321@huawei.com>","References":"<1509547642-51110-1-git-send-email-lipeng321@huawei.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-Originating-IP":"[10.71.200.31]","X-CFilter-Loop":"Reflected","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: qumingguang \n\nAll member of Struct hdev->hw_stats is initialized 0 as hdev is alloced by\ndevm_kzalloc. But in reset process, hdev will not be alloced again, so need\nclear hdev->hw_stats in reset process, otherwise the statistic will be\nwrong after reset. This patch set all of the statistic counters to zero\nafter reset.\n\nSigned-off-by: qumingguang \nSigned-off-by: Lipeng \n---\n drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c\nindex 141c758..dff9cbd 100644\n--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c\n+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c\n@@ -4838,6 +4838,11 @@ static int hclge_init_ae_dev(struct hnae3_ae_dev *ae_dev)\n \treturn ret;\n }\n \n+static void hclge_stats_clear(struct hclge_dev *hdev)\n+{\n+\tmemset(&hdev->hw_stats, 0, sizeof(hdev->hw_stats));\n+}\n+\n static int hclge_reset_ae_dev(struct hnae3_ae_dev *ae_dev)\n {\n \tstruct hclge_dev *hdev = ae_dev->priv;\n@@ -4846,6 +4851,8 @@ static int hclge_reset_ae_dev(struct hnae3_ae_dev *ae_dev)\n \n \tset_bit(HCLGE_STATE_DOWN, &hdev->state);\n \n+\thclge_stats_clear(hdev);\n+\n \tret = hclge_cmd_init(hdev);\n \tif (ret) {\n \t\tdev_err(&pdev->dev, \"Cmd queue init failed\\n\");\n","prefixes":["net-next","9/9"]}