{"id":831254,"url":"http://patchwork.ozlabs.org/api/1.2/patches/831254/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/patch/20171027110947.12803-1-alexandre.belloni@free-electrons.com/","project":{"id":9,"url":"http://patchwork.ozlabs.org/api/1.2/projects/9/?format=json","name":"Linux RTC development","link_name":"rtc-linux","list_id":"linux-rtc.vger.kernel.org","list_email":"linux-rtc@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171027110947.12803-1-alexandre.belloni@free-electrons.com>","list_archive_url":null,"date":"2017-10-27T11:09:47","name":"rtc: ds1390: Add OF device ID table","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d805d7eecb40ca2c6ebb8515253c0383624de199","submitter":{"id":26276,"url":"http://patchwork.ozlabs.org/api/1.2/people/26276/?format=json","name":"Alexandre Belloni","email":"alexandre.belloni@free-electrons.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/rtc-linux/patch/20171027110947.12803-1-alexandre.belloni@free-electrons.com/mbox/","series":[{"id":10558,"url":"http://patchwork.ozlabs.org/api/1.2/series/10558/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/list/?series=10558","date":"2017-10-27T11:09:47","name":"rtc: ds1390: Add OF device ID table","version":1,"mbox":"http://patchwork.ozlabs.org/series/10558/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/831254/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/831254/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNh3l31rHz9sNx\n\tfor ;\n\tFri, 27 Oct 2017 22:09:55 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752161AbdJ0LJx (ORCPT );\n\tFri, 27 Oct 2017 07:09:53 -0400","from mail.free-electrons.com ([62.4.15.54]:47898 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752151AbdJ0LJw (ORCPT\n\t); Fri, 27 Oct 2017 07:09:52 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 2903920870; Fri, 27 Oct 2017 13:09:50 +0200 (CEST)","from localhost (unknown [88.191.26.124])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id E91252086B;\n\tFri, 27 Oct 2017 13:09:49 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","From":"Alexandre Belloni ","To":"linux-rtc@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org,\n\tAlexandre Belloni ","Subject":"[PATCH] rtc: ds1390: Add OF device ID table","Date":"Fri, 27 Oct 2017 13:09:47 +0200","Message-Id":"<20171027110947.12803-1-alexandre.belloni@free-electrons.com>","X-Mailer":"git-send-email 2.15.0.rc2","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"},"content":"The driver doesn't have a struct of_device_id table but supported devices\nare registered via Device Trees. Worse, the compatible is documented but\ndoesn't currently match the driver.\n\nAdd the proper compatible to the driver.\n\nSigned-off-by: Alexandre Belloni \n---\n drivers/rtc/rtc-ds1390.c | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c\nindex aa0d2c6f1edc..4d5b007d7fc6 100644\n--- a/drivers/rtc/rtc-ds1390.c\n+++ b/drivers/rtc/rtc-ds1390.c\n@@ -216,9 +216,16 @@ static int ds1390_probe(struct spi_device *spi)\n \treturn res;\n }\n \n+static const struct of_device_id ds1390_of_match[] = {\n+\t{ .compatible = \"dallas,ds1390\" },\n+\t{}\n+};\n+MODULE_DEVICE_TABLE(of, ds1390_of_match);\n+\n static struct spi_driver ds1390_driver = {\n \t.driver = {\n \t\t.name\t= \"rtc-ds1390\",\n+\t\t.of_match_table = of_match_ptr(ds1390_of_match),\n \t},\n \t.probe\t= ds1390_probe,\n };\n","prefixes":[]}