{"id":831222,"url":"http://patchwork.ozlabs.org/api/1.2/patches/831222/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20171027104546.8582-1-eblake@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171027104546.8582-1-eblake@redhat.com>","list_archive_url":null,"date":"2017-10-27T10:45:46","name":"[RFC,v6,13/12] tweak test 83 verbosity","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"77741823ac02016c8ad9344bf0dddac8d87e38d1","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/1.2/people/6591/?format=json","name":"Eric Blake","email":"eblake@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20171027104546.8582-1-eblake@redhat.com/mbox/","series":[{"id":10552,"url":"http://patchwork.ozlabs.org/api/1.2/series/10552/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=10552","date":"2017-10-27T10:40:27","name":"nbd minimal structured read","version":6,"mbox":"http://patchwork.ozlabs.org/series/10552/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/831222/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/831222/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yNgkB4k0pz9rxj\n\tfor ;\n\tFri, 27 Oct 2017 21:54:42 +1100 (AEDT)","from localhost ([::1]:56600 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e82Hg-0002Al-K7\n\tfor incoming@patchwork.ozlabs.org; Fri, 27 Oct 2017 06:54:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59045)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e829R-0005k0-Aw\n\tfor qemu-devel@nongnu.org; Fri, 27 Oct 2017 06:46:10 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e829Q-0001X1-IC\n\tfor qemu-devel@nongnu.org; Fri, 27 Oct 2017 06:46:09 -0400","from mx1.redhat.com ([209.132.183.28]:54482)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e829D-0001Lr-W9; Fri, 27 Oct 2017 06:45:56 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C87AEC049E31;\n\tFri, 27 Oct 2017 10:45:54 +0000 (UTC)","from red.redhat.com (ovpn-120-166.rdu2.redhat.com [10.10.120.166])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 233575C54A;\n\tFri, 27 Oct 2017 10:45:52 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C87AEC049E31","From":"Eric Blake ","To":"qemu-devel@nongnu.org","Date":"Fri, 27 Oct 2017 12:45:46 +0200","Message-Id":"<20171027104546.8582-1-eblake@redhat.com>","In-Reply-To":"<20171027104037.8319-1-eblake@redhat.com>","References":"<20171027104037.8319-1-eblake@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tFri, 27 Oct 2017 10:45:54 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [RFC PATCH v6 13/12] tweak test 83 verbosity","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , pbonzini@redhat.com,\n\tvsementsov@virtuozzo.com, qemu-block@nongnu.org,\n\tMax Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Commenting these two lines is enough to avoid the change to 083.out\nin 12/12. That is evidence that we may want these two lines to be\ntrace points rather than error messages; or maybe we really do like\nthe extra verbosity in the case of an unexpected communication break.\n\nThis patch does not meet coding guidelines, and I'm not proud enough\nof it to give S-o-b, but I'm posting it for conversation.\n\n---\n block/nbd-client.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/block/nbd-client.c b/block/nbd-client.c\nindex b44d4d4a01..e063b3fbc0 100644\n--- a/block/nbd-client.c\n+++ b/block/nbd-client.c\n@@ -654,7 +654,8 @@ static int nbd_co_request(BlockDriverState *bs, NBDRequest *request,\n\n ret = nbd_co_receive_return_code(client, request->handle, &local_err);\n if (local_err) {\n- error_report_err(local_err);\n+ assert(ret < 0);\n+// error_report_err(local_err);\n }\n return ret;\n }\n@@ -682,7 +683,7 @@ int nbd_client_co_preadv(BlockDriverState *bs, uint64_t offset,\n ret = nbd_co_receive_cmdread_reply(client, request.handle, offset, qiov,\n &local_err);\n if (ret < 0) {\n- error_report_err(local_err);\n+ //error_report_err(local_err);\n }\n return ret;\n }\n","prefixes":["RFC","v6","13/12"]}