{"id":831110,"url":"http://patchwork.ozlabs.org/api/1.2/patches/831110/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171027064020.aq52ue4kfp5htrb5@mwanda/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171027064020.aq52ue4kfp5htrb5@mwanda>","list_archive_url":null,"date":"2017-10-27T06:40:20","name":"[net-next] qed: Set error code for allocation failures","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"e0d567aa56a2bb2b580ecad74858942dcb2bb0fd","submitter":{"id":9327,"url":"http://patchwork.ozlabs.org/api/1.2/people/9327/?format=json","name":"Dan Carpenter","email":"dan.carpenter@oracle.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171027064020.aq52ue4kfp5htrb5@mwanda/mbox/","series":[{"id":10513,"url":"http://patchwork.ozlabs.org/api/1.2/series/10513/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=10513","date":"2017-10-27T06:40:20","name":"[net-next] qed: Set error code for allocation failures","version":1,"mbox":"http://patchwork.ozlabs.org/series/10513/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/831110/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/831110/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNZ506h2Zz9t30\n\tfor ;\n\tFri, 27 Oct 2017 17:40:36 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752086AbdJ0Gkd (ORCPT );\n\tFri, 27 Oct 2017 02:40:33 -0400","from userp1040.oracle.com ([156.151.31.81]:28326 \"EHLO\n\tuserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751072AbdJ0Gka (ORCPT\n\t); Fri, 27 Oct 2017 02:40:30 -0400","from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71])\n\tby userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id v9R6eRw9014912\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Fri, 27 Oct 2017 06:40:28 GMT","from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235])\n\tby userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv9R6eREf028501\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Fri, 27 Oct 2017 06:40:27 GMT","from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24])\n\tby aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tv9R6eRvE029473; Fri, 27 Oct 2017 06:40:27 GMT","from mwanda (/129.205.6.86)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Thu, 26 Oct 2017 23:40:26 -0700"],"Date":"Fri, 27 Oct 2017 09:40:20 +0300","From":"Dan Carpenter ","To":"Ariel Elior ","Cc":"everest-linux-l2@cavium.com, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org","Subject":"[PATCH net-next] qed: Set error code for allocation failures","Message-ID":"<20171027064020.aq52ue4kfp5htrb5@mwanda>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","X-Mailer":"git-send-email haha only kidding","User-Agent":"NeoMutt/20170609 (1.8.3)","X-Source-IP":"userv0021.oracle.com [156.151.31.71]","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"There are several places where we accidentally return success when\nkcalloc() fails.\n\nFixes: fcb39f6c10b2 (\"qed: Add mpa buffer descriptors for storing and processing mpa fpdus\")\nSigned-off-by: Dan Carpenter ","diff":"diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\nindex 409041eab189..6366f2ef82b7 100644\n--- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\n+++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\n@@ -2585,7 +2585,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,\n \tstruct qed_ll2_cbs cbs;\n \tu32 mpa_buff_size;\n \tu16 n_ooo_bufs;\n-\tint rc = 0;\n+\tint rc;\n \tint i;\n \n \tiwarp_info = &p_hwfn->p_rdma_info->iwarp;\n@@ -2696,6 +2696,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,\n \tif (rc)\n \t\tgoto err;\n \n+\trc = -ENOMEM;\n \tiwarp_info->partial_fpdus = kcalloc((u16)p_hwfn->p_rdma_info->num_qps,\n \t\t\t\t\t sizeof(*iwarp_info->partial_fpdus),\n \t\t\t\t\t GFP_KERNEL);\n@@ -2724,7 +2725,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn,\n \tfor (i = 0; i < data.input.rx_num_desc; i++)\n \t\tlist_add_tail(&iwarp_info->mpa_bufs[i].list_entry,\n \t\t\t &iwarp_info->mpa_buf_list);\n-\treturn rc;\n+\treturn 0;\n err:\n \tqed_iwarp_ll2_stop(p_hwfn, p_ptt);\n \n","prefixes":["net-next"]}