{"id":831104,"url":"http://patchwork.ozlabs.org/api/1.2/patches/831104/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/1509084261-16126-2-git-send-email-yamada.masahiro@socionext.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1509084261-16126-2-git-send-email-yamada.masahiro@socionext.com>","list_archive_url":null,"date":"2017-10-27T06:04:21","name":"[U-Boot,2/2] tools: image: fix message when fail to add verification data for config","commit_ref":"76b9cbab25f832a25e51c50a221c0f1ff3632b7c","pull_url":null,"state":"accepted","archived":false,"hash":"266c9bb07c6196429667c752b99ac7366c8bc3ee","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/1.2/people/65882/?format=json","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.2/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1509084261-16126-2-git-send-email-yamada.masahiro@socionext.com/mbox/","series":[{"id":10510,"url":"http://patchwork.ozlabs.org/api/1.2/series/10510/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=10510","date":"2017-10-27T06:04:21","name":"[U-Boot,1/2] tools: image: allow to sign image nodes without -K option","version":1,"mbox":"http://patchwork.ozlabs.org/series/10510/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/831104/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/831104/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"ojATF2tQ\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNYJf0X7hz9t2d\n\tfor ;\n\tFri, 27 Oct 2017 17:05:36 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid C05F6C21DB5; Fri, 27 Oct 2017 06:05:27 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 086D4C21C34;\n\tFri, 27 Oct 2017 06:05:25 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 47C25C21C46; Fri, 27 Oct 2017 06:05:23 +0000 (UTC)","from conuserg-07.nifty.com (conuserg-07.nifty.com [210.131.2.74])\n\tby lists.denx.de (Postfix) with ESMTPS id AA394C21C29\n\tfor ; Fri, 27 Oct 2017 06:05:21 +0000 (UTC)","from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp\n\t[153.142.97.92]) (authenticated)\n\tby conuserg-07.nifty.com with ESMTP id v9R64Ogv013972;\n\tFri, 27 Oct 2017 15:04:25 +0900"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=T_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Filter":"OpenDKIM Filter v2.10.3 conuserg-07.nifty.com v9R64Ogv013972","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1509084265;\n\tbh=5crAyMSgKwDv8tk6vOxqBuvlhKts9hN25c8A32Agnm0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ojATF2tQeqHBSW4XttpO230mR8/yvEpQcj1LKFBZX5Wc/hIueVKDW3w2SVozVrsxf\n\tAtdUU0ImdEnAWNvFNY5KoDRKQYI9ecz13QJgLgWyPofWJa9ewhGC99qZTx3FkM7bRW\n\tlucnp3e5CeWyULMKeSQSfFfgrveYEJ4oXCwpsxFKdtRZPJGWe/EoKY5fJ5HEjv0dqO\n\tF/luUarpiYgMFEYFpk1t/HddzVbqvT/NtmpVdN0/Nn6Ld44YIR3aK714lQy374PtbN\n\tH6PWUjW9tGC6rTRv3j5lqF4CFImzZxvj1FCIExfp9hsJ5y++dmY0KJPlhOFzD85YG7\n\tBaJyatgT/jQ0w==","X-Nifty-SrcIP":"[153.142.97.92]","From":"Masahiro Yamada ","To":"u-boot@lists.denx.de","Date":"Fri, 27 Oct 2017 15:04:21 +0900","Message-Id":"<1509084261-16126-2-git-send-email-yamada.masahiro@socionext.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1509084261-16126-1-git-send-email-yamada.masahiro@socionext.com>","References":"<1509084261-16126-1-git-send-email-yamada.masahiro@socionext.com>","Cc":"Tom Rini ","Subject":"[U-Boot] [PATCH 2/2] tools: image: fix message when fail to add\n\tverification data for config","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"This function is called when signing configuration nodes. Adjust\nthe error message.\n\nI do not know why we do not need to show the error message in case of\nENOSPC. Remove the if-conditional that seems unnecessary.\n\nSigned-off-by: Masahiro Yamada \n---\n\n tools/image-host.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/tools/image-host.c b/tools/image-host.c\nindex d42c1ca..2c0030b 100644\n--- a/tools/image-host.c\n+++ b/tools/image-host.c\n@@ -626,10 +626,8 @@ static int fit_config_process_sig(const char *keydir, void *keydest,\n \t/* Write the public key into the supplied FDT file */\n \tif (keydest) {\n \t\tret = info.crypto->add_verify_data(&info, keydest);\n-\t\tif (ret == -ENOSPC)\n-\t\t\treturn -ENOSPC;\n \t\tif (ret) {\n-\t\t\tprintf(\"Failed to add verification data for '%s' signature node in '%s' image node\\n\",\n+\t\t\tprintf(\"Failed to add verification data for '%s' signature node in '%s' configuration node\\n\",\n \t\t\t node_name, conf_name);\n \t\t}\n \t\treturn ret;\n","prefixes":["U-Boot","2/2"]}