{"id":831059,"url":"http://patchwork.ozlabs.org/api/1.2/patches/831059/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20171027040833.3644-17-aneesh.kumar@linux.vnet.ibm.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.2/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20171027040833.3644-17-aneesh.kumar@linux.vnet.ibm.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20171027040833.3644-17-aneesh.kumar@linux.vnet.ibm.com/","date":"2017-10-27T04:08:33","name":"[16/16] powerpc/mm/pseries: Use HASH_BULK_REMOVE hcall in guest","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"d50d1e8b321fb19dd807106792370a3c43d962a8","submitter":{"id":664,"url":"http://patchwork.ozlabs.org/api/1.2/people/664/?format=json","name":"Aneesh Kumar K.V","email":"aneesh.kumar@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20171027040833.3644-17-aneesh.kumar@linux.vnet.ibm.com/mbox/","series":[{"id":10486,"url":"http://patchwork.ozlabs.org/api/1.2/series/10486/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=10486","date":"2017-10-27T04:08:17","name":"Remove hash page table slot tracking from linux PTE","version":1,"mbox":"http://patchwork.ozlabs.org/series/10486/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/831059/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/831059/checks/","tags":{},"related":[],"headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yNWCg74WSz9t2d\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 27 Oct 2017 15:31:11 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3yNWCg6DWRzDt0L\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 27 Oct 2017 15:31:11 +1100 (AEDT)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3yNVlX6q7zzDrcf\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tFri, 27 Oct 2017 15:10:16 +1100 (AEDT)","from pps.filterd (m0098413.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv9R492IH036380\n\tfor <linuxppc-dev@lists.ozlabs.org>; Fri, 27 Oct 2017 00:10:14 -0400","from e34.co.us.ibm.com (e34.co.us.ibm.com [32.97.110.152])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2duuqmvm58-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <linuxppc-dev@lists.ozlabs.org>; Fri, 27 Oct 2017 00:10:14 -0400","from localhost\n\tby e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <linuxppc-dev@lists.ozlabs.org> from\n\t<aneesh.kumar@linux.vnet.ibm.com>; Thu, 26 Oct 2017 22:10:13 -0600","from b03cxnp07028.gho.boulder.ibm.com (9.17.130.15)\n\tby e34.co.us.ibm.com (192.168.1.134) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 26 Oct 2017 22:10:12 -0600","from b03ledav001.gho.boulder.ibm.com\n\t(b03ledav001.gho.boulder.ibm.com [9.17.130.232])\n\tby b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v9R4ACrF5112212; Thu, 26 Oct 2017 21:10:12 -0700","from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 0AE396E179;\n\tThu, 26 Oct 2017 22:10:12 -0600 (MDT)","from skywalker.ibmmodules.com (unknown [9.85.199.61])\n\tby b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP id 932636E17A;\n\tThu, 26 Oct 2017 22:10:07 -0600 (MDT)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=aneesh.kumar@linux.vnet.ibm.com; receiver=<UNKNOWN>)","From":"\"Aneesh Kumar K.V\" <aneesh.kumar@linux.vnet.ibm.com>","To":"benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au","Subject":"[PATCH 16/16] powerpc/mm/pseries: Use HASH_BULK_REMOVE hcall in\n\tguest","Date":"Fri, 27 Oct 2017 09:38:33 +0530","X-Mailer":"git-send-email 2.13.6","In-Reply-To":"<20171027040833.3644-1-aneesh.kumar@linux.vnet.ibm.com>","References":"<20171027040833.3644-1-aneesh.kumar@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17102704-0016-0000-0000-000007B76FA9","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007958; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000239; SDB=6.00937035; UDB=6.00472245;\n\tIPR=6.00717297; \n\tBA=6.00005660; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017735;\n\tXFM=3.00000015; UTC=2017-10-27 04:10:13","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17102704-0017-0000-0000-00003C048B4E","Message-Id":"<20171027040833.3644-17-aneesh.kumar@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-10-27_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501\n\tmalwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0\n\tclxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0\n\tclassifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1707230000\n\tdefinitions=main-1710270053","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>","Cc":"linuxppc-dev@lists.ozlabs.org,\n\t\"Aneesh Kumar K.V\" <aneesh.kumar@linux.vnet.ibm.com>","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"},"content":"Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>\n---\n arch/powerpc/platforms/pseries/lpar.c | 40 ++++++++++++++++++++++++++++-------\n 1 file changed, 32 insertions(+), 8 deletions(-)","diff":"diff --git a/arch/powerpc/platforms/pseries/lpar.c b/arch/powerpc/platforms/pseries/lpar.c\nindex 4ea9224cbeb6..6dffdf654a28 100644\n--- a/arch/powerpc/platforms/pseries/lpar.c\n+++ b/arch/powerpc/platforms/pseries/lpar.c\n@@ -684,19 +684,43 @@ static void pSeries_lpar_flush_hash_range(unsigned long number, int local)\n \tfor (i = 0; i < number; i++) {\n \t\tvpn = batch->vpn[i];\n \t\tpte_iterate_hashed_subpages(vpn, psize, index, shift) {\n-\t\t\tlong slot;\n-\n-\t\t\tslot = pSeries_lpar_hpte_find(vpn, psize, ssize);\n-\t\t\tif (slot < 0)\n-\t\t\t\tcontinue;\n-\t\t\tpix = plpar_bluk_remove(param, pix, slot, vpn,\n-\t\t\t\t\t\tpsize, ssize, local);\n+\t\t\tif (!firmware_has_feature(FW_FEATURE_HASH_API)) {\n+\t\t\t\tlong slot;\n+\n+\t\t\t\tslot = pSeries_lpar_hpte_find(vpn, psize, ssize);\n+\t\t\t\tif (slot < 0)\n+\t\t\t\t\tcontinue;\n+\t\t\t\tpix = plpar_bluk_remove(param, pix, slot, vpn,\n+\t\t\t\t\t\t\t  psize, ssize, local);\n+\t\t\t} else {\n+\t\t\t\tunsigned long hash;\n+\t\t\t\thash = hpt_hash(vpn, mmu_psize_defs[psize].shift, ssize);\n+\t\t\t\t/* trim the top bits, we overload them below */\n+\t\t\t\thash &= MAX_HTAB_MASK;\n+\t\t\t\tparam[pix] = HBR_REQUEST | HBR_AVPN | hash;\n+\t\t\t\tparam[pix+1] = hpte_encode_avpn(vpn, psize, ssize);\n+\t\t\t\tpix += 2;\n+\t\t\t\tif (pix == 8) {\n+\t\t\t\t\trc = plpar_hcall9(H_HASH_BULK_REMOVE, param,\n+\t\t\t\t\t\t\t  param[0], param[1], param[2],\n+\t\t\t\t\t\t\t  param[3], param[4], param[5],\n+\t\t\t\t\t\t\t  param[6], param[7]);\n+\t\t\t\t\tBUG_ON(rc != H_SUCCESS);\n+\t\t\t\t\tpix = 0;\n+\t\t\t\t}\n+\t\t\t}\n \t\t} pte_iterate_hashed_end();\n \t}\n \tif (pix) {\n+\t\tunsigned long hcall;\n+\n \t\t/* We have a flush pending */\n \t\tparam[pix] = HBR_END;\n-\t\trc = plpar_hcall9(H_BULK_REMOVE, param, param[0], param[1],\n+\t\tif (!firmware_has_feature(FW_FEATURE_HASH_API))\n+\t\t\thcall = H_BULK_REMOVE;\n+\t\telse\n+\t\t\thcall = H_HASH_BULK_REMOVE;\n+\t\trc = plpar_hcall9(hcall, param, param[0], param[1],\n \t\t\t\t  param[2], param[3], param[4], param[5],\n \t\t\t\t  param[6], param[7]);\n \t\tBUG_ON(rc != H_SUCCESS);\n","prefixes":["16/16"]}