{"id":831055,"url":"http://patchwork.ozlabs.org/api/1.2/patches/831055/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/1509078321-7694-1-git-send-email-yamada.masahiro@socionext.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1509078321-7694-1-git-send-email-yamada.masahiro@socionext.com>","list_archive_url":null,"date":"2017-10-27T04:25:21","name":"[U-Boot] tools: image: fix \"algo\" property of public key for verified boot","commit_ref":"1d88a99d1b9175c41f015631311fd9e5966eb997","pull_url":null,"state":"accepted","archived":false,"hash":"42b25be7db28ca41c0910404818c5059346c3618","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/1.2/people/65882/?format=json","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.2/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1509078321-7694-1-git-send-email-yamada.masahiro@socionext.com/mbox/","series":[{"id":10489,"url":"http://patchwork.ozlabs.org/api/1.2/series/10489/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=10489","date":"2017-10-27T04:25:21","name":"[U-Boot] tools: image: fix \"algo\" property of public key for verified boot","version":1,"mbox":"http://patchwork.ozlabs.org/series/10489/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/831055/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/831055/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"NYqk2WtL\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNW6K73kgz9t2d\n\tfor ;\n\tFri, 27 Oct 2017 15:26:32 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 83E6CC21DCE; Fri, 27 Oct 2017 04:26:24 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id F0572C21C34;\n\tFri, 27 Oct 2017 04:26:21 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 288A1C21C34; Fri, 27 Oct 2017 04:26:21 +0000 (UTC)","from conuserg-07.nifty.com (conuserg-07.nifty.com [210.131.2.74])\n\tby lists.denx.de (Postfix) with ESMTPS id D5DA2C21C29\n\tfor ; Fri, 27 Oct 2017 04:26:19 +0000 (UTC)","from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp\n\t[153.142.97.92]) (authenticated)\n\tby conuserg-07.nifty.com with ESMTP id v9R4PRCB009776;\n\tFri, 27 Oct 2017 13:25:27 +0900"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=T_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Filter":"OpenDKIM Filter v2.10.3 conuserg-07.nifty.com v9R4PRCB009776","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1509078328;\n\tbh=ovLN2SYYNAuKBcb99nVmJm8N3R6kCwHnoCetkAZXGTQ=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=NYqk2WtLkMefBCKDXCIsxJs6lI4QHh4WomK6gm9nYWmzSF+qiNiamjrxduP3oE+EE\n\tpCS1Nmnexnrue7hGm/1/ld71WZN+Ll4iIRsi3Pz9AodyixaHUwJACkUS3iiLthvpcd\n\t52HWYZfZBYZvL14Q/4PLaAXdNUWoTu4B2xtEz4QmmAMypk6yOLatME7TZJNCkc3dox\n\t3QewR2MzyGR9O6zqH7u4qK0iioKiVQRx0jjpr0hE2djxBSrkLRBsWcNH3sQHnLqSV4\n\t2w16OcFLFFWO2GqPZShAV8DeajNka9Zt1ApFXgZI5yiloiMANM/KKZMYeh25dGaONH\n\tbaG0LS/7CYOkA==","X-Nifty-SrcIP":"[153.142.97.92]","From":"Masahiro Yamada ","To":"u-boot@lists.denx.de","Date":"Fri, 27 Oct 2017 13:25:21 +0900","Message-Id":"<1509078321-7694-1-git-send-email-yamada.masahiro@socionext.com>","X-Mailer":"git-send-email 2.7.4","Cc":"Tom Rini ","Subject":"[U-Boot] [PATCH] tools: image: fix \"algo\" property of public key\n\tfor verified boot","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"The \"algo_name\" points to a property in a blob being edited. The\npointer becomes stale when fit_image_write_sig() inserts signatures.\nThen crypto->add_verify_data() writes wrong data to the public key\ndestination.\n\nSigned-off-by: Masahiro Yamada \n---\n\n tools/image-host.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/tools/image-host.c b/tools/image-host.c\nindex c60d4ad..ad9a73a 100644\n--- a/tools/image-host.c\n+++ b/tools/image-host.c\n@@ -166,7 +166,7 @@ static int fit_image_setup_sig(struct image_sign_info *info,\n \tinfo->keyname = fdt_getprop(fit, noffset, \"key-name-hint\", NULL);\n \tinfo->fit = fit;\n \tinfo->node_offset = noffset;\n-\tinfo->name = algo_name;\n+\tinfo->name = strdup(algo_name);\n \tinfo->checksum = image_get_checksum_algo(algo_name);\n \tinfo->crypto = image_get_crypto_algo(algo_name);\n \tinfo->require_keys = require_keys;\n","prefixes":["U-Boot"]}