{"id":831042,"url":"http://patchwork.ozlabs.org/api/1.2/patches/831042/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171027041002.GA13506@embeddedor.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171027041002.GA13506@embeddedor.com>","list_archive_url":null,"date":"2017-10-27T04:10:35","name":"ipv6: exthdrs: use swap macro in ipv6_dest_hao","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"92882d4f4e81937aa5e21a09fcbb761f17bcb903","submitter":{"id":71553,"url":"http://patchwork.ozlabs.org/api/1.2/people/71553/?format=json","name":"Gustavo A. R. Silva","email":"garsilva@embeddedor.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171027041002.GA13506@embeddedor.com/mbox/","series":[{"id":10487,"url":"http://patchwork.ozlabs.org/api/1.2/series/10487/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=10487","date":"2017-10-27T04:10:35","name":"ipv6: exthdrs: use swap macro in ipv6_dest_hao","version":1,"mbox":"http://patchwork.ozlabs.org/series/10487/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/831042/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/831042/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNVmC6b69z9s8J\n\tfor ;\n\tFri, 27 Oct 2017 15:10:51 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751530AbdJ0EKl (ORCPT );\n\tFri, 27 Oct 2017 00:10:41 -0400","from gateway31.websitewelcome.com ([192.185.143.40]:33180 \"EHLO\n\tgateway31.websitewelcome.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1750795AbdJ0EKj (ORCPT\n\t); Fri, 27 Oct 2017 00:10:39 -0400","from cm14.websitewelcome.com (cm14.websitewelcome.com\n\t[100.42.49.7])\n\tby gateway31.websitewelcome.com (Postfix) with ESMTP id 3E5235F83E7\n\tfor ; Thu, 26 Oct 2017 23:10:38 -0500 (CDT)","from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP\n\tid 7vygezgYKHEIm7vyge6hmo; Thu, 26 Oct 2017 23:10:38 -0500","from [189.145.38.148] (port=56566 helo=embeddedor)\n\tby gator4166.hostgator.com with esmtpa (Exim 4.87)\n\t(envelope-from )\n\tid 1e7vyf-0013ft-OX; Thu, 26 Oct 2017 23:10:37 -0500"],"Date":"Thu, 26 Oct 2017 23:10:35 -0500","From":"\"Gustavo A. R. Silva\" ","To":"\"David S. Miller\" ,\n\tAlexey Kuznetsov ,\n\tHideaki YOSHIFUJI ","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\t\"Gustavo A. R. Silva\" ","Subject":"[PATCH] ipv6: exthdrs: use swap macro in ipv6_dest_hao","Message-ID":"<20171027041002.GA13506@embeddedor.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-AntiAbuse":["This header was added to track abuse,\n\tplease include it with any abuse report","Primary Hostname - gator4166.hostgator.com","Original Domain - vger.kernel.org","Originator/Caller UID/GID - [47 12] / [47 12]","Sender Address Domain - embeddedor.com"],"X-BWhitelist":"no","X-Source-IP":"189.145.38.148","X-Source-L":"No","X-Exim-ID":"1e7vyf-0013ft-OX","X-Source":"","X-Source-Args":"","X-Source-Dir":"","X-Source-Sender":"(embeddedor) [189.145.38.148]:56566","X-Source-Auth":"garsilva@embeddedor.com","X-Email-Count":"4","X-Source-Cap":"Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20=","X-Local-Domain":"yes","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"make use of the swap macro and remove unnecessary variable tmp_addr.\nThis makes the code easier to read and maintain.\n\nThis code was detected with the help of Coccinelle.\n\nSigned-off-by: Gustavo A. R. Silva \n---\n net/ipv6/exthdrs.c | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)","diff":"diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c\nindex 7835dea..9f918a7 100644\n--- a/net/ipv6/exthdrs.c\n+++ b/net/ipv6/exthdrs.c\n@@ -187,7 +187,6 @@ static bool ipv6_dest_hao(struct sk_buff *skb, int optoff)\n \tstruct ipv6_destopt_hao *hao;\n \tstruct inet6_skb_parm *opt = IP6CB(skb);\n \tstruct ipv6hdr *ipv6h = ipv6_hdr(skb);\n-\tstruct in6_addr tmp_addr;\n \tint ret;\n \n \tif (opt->dsthao) {\n@@ -229,9 +228,7 @@ static bool ipv6_dest_hao(struct sk_buff *skb, int optoff)\n \tif (skb->ip_summed == CHECKSUM_COMPLETE)\n \t\tskb->ip_summed = CHECKSUM_NONE;\n \n-\ttmp_addr = ipv6h->saddr;\n-\tipv6h->saddr = hao->addr;\n-\thao->addr = tmp_addr;\n+\tswap(ipv6h->saddr, hao->addr);\n \n \tif (skb->tstamp == 0)\n \t\t__net_timestamp(skb);\n","prefixes":[]}