{"id":831024,"url":"http://patchwork.ozlabs.org/api/1.2/patches/831024/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171027012443.3306-8-xiyou.wangcong@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171027012443.3306-8-xiyou.wangcong@gmail.com>","list_archive_url":null,"date":"2017-10-27T01:24:34","name":"[net,07/16] net_sched: use tcf_queue_work() in fw filter","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"a1c9372420139d290965ac5bced25dbd65ad72d4","submitter":{"id":211,"url":"http://patchwork.ozlabs.org/api/1.2/people/211/?format=json","name":"Cong Wang","email":"xiyou.wangcong@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171027012443.3306-8-xiyou.wangcong@gmail.com/mbox/","series":[{"id":10472,"url":"http://patchwork.ozlabs.org/api/1.2/series/10472/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=10472","date":"2017-10-27T01:24:27","name":"net_sched: fix races with RCU callbacks","version":1,"mbox":"http://patchwork.ozlabs.org/series/10472/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/831024/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/831024/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"dKjxCP+a\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNR6Q5w69z9t2h\n\tfor ;\n\tFri, 27 Oct 2017 12:26:22 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932518AbdJ0B0V (ORCPT );\n\tThu, 26 Oct 2017 21:26:21 -0400","from mail-pf0-f196.google.com ([209.85.192.196]:45023 \"EHLO\n\tmail-pf0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752003AbdJ0BZG (ORCPT\n\t); Thu, 26 Oct 2017 21:25:06 -0400","by mail-pf0-f196.google.com with SMTP id x7so3784249pfa.1\n\tfor ; Thu, 26 Oct 2017 18:25:06 -0700 (PDT)","from tw-172-25-30-113.office.twttr.net ([8.25.197.25])\n\tby smtp.gmail.com with ESMTPSA id\n\tb16sm13211973pfe.58.2017.10.26.18.25.04\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 26 Oct 2017 18:25:05 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=xK4k1EmadEvuL+CitHHxh3JXcXrgeCD65v85AwZ/2d4=;\n\tb=dKjxCP+aMuOpyslyYWqmUvdWSnkPvPU/gD9qWSPEFEnNq2Iz50reMTG+dRmqU5X+wi\n\tCi/9DJATC6AL16KNyJC96LMoRUKxbSMqJiy8CmIum3i0HzjAJTQt0oTHsrfHU08+d/B7\n\t02rQdbf1lpRin7zYAsa5tQed95ki1ALGFWZDL99WoENjOFiOqowcjtnPbIQi0QgHLV0H\n\tu9Ds2tgnNBiStAaVkOPWehQ1xGbg+Bdzh0aucpq7vQkewDEBl5JZBRGZjqAPJI7c4htK\n\tMSIG7VrG9sz4ncV4FLSObsm2+EXZyETiCIIHeqcWh5ooyLNjhmTAOCdZHYGgLLNNcexY\n\trFXA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=xK4k1EmadEvuL+CitHHxh3JXcXrgeCD65v85AwZ/2d4=;\n\tb=Sg6lkTAC9UzhkDBTTVhkvvtFx9URUM9cI1cMSCtRylAUa8/Tz11Kj5BATmg6NZvnOb\n\t/0m3nLjIOL8C1PRVWAcgnsoiUngjPCLUMWQizvqz/+slVy5s5Pgq82+G3FavTOb3nAsI\n\tWPnDSRgyPstcWcGLXPC7CNKWyKFccKqJI2do6DL5knORjmkinepjQQ6SjQUkCp0K5RSb\n\tT67vtP3HCXtplQ/08ruJqkyh0a5L9Ot/b9eliaSyqICs6Y226ZvFzwQTpUAYu0200aOL\n\tiHZsrlLx8ZRL5YLLHeGXj5gjFYgspAFwEUnZ1rKFk+d9PW8zVErqJMaoQ+0ea9dbMSsv\n\t7xHQ==","X-Gm-Message-State":"AMCzsaXiKjJvzr3unuHICb9aEoJya6L2xU8Rb3BnauIFY7hWjRx05z+n\n\tmxEFNyHFybTT0ZzcdNQI+rhHGnwc","X-Google-Smtp-Source":"ABhQp+RmxVk4nn2WNsjwn5GbQ+9FjsbN8Sc0yV580rNAnsNdTzqBg6yc7NEtkmKB9kOyqqo2tkRYKQ==","X-Received":"by 10.101.90.193 with SMTP id d1mr6549964pgt.423.1509067506042; \n\tThu, 26 Oct 2017 18:25:06 -0700 (PDT)","From":"Cong Wang ","To":"netdev@vger.kernel.org","Cc":"Chris Mi , Cong Wang ,\n\tDaniel Borkmann , Jiri Pirko ,\n\tJohn Fastabend ,\n\tJamal Hadi Salim ,\n\t\"Paul E. McKenney\" ","Subject":"[Patch net 07/16] net_sched: use tcf_queue_work() in fw filter","Date":"Thu, 26 Oct 2017 18:24:34 -0700","Message-Id":"<20171027012443.3306-8-xiyou.wangcong@gmail.com>","X-Mailer":"git-send-email 2.9.4","In-Reply-To":"<20171027012443.3306-1-xiyou.wangcong@gmail.com>","References":"<20171027012443.3306-1-xiyou.wangcong@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Defer the tcf_exts_destroy() in RCU callback to\ntc filter workqueue and get RTNL lock.\n\nReported-by: Chris Mi \nCc: Daniel Borkmann \nCc: Jiri Pirko \nCc: John Fastabend \nCc: Jamal Hadi Salim \nCc: \"Paul E. McKenney\" \nSigned-off-by: Cong Wang \n---\n net/sched/cls_fw.c | 19 ++++++++++++++++---\n 1 file changed, 16 insertions(+), 3 deletions(-)","diff":"diff --git a/net/sched/cls_fw.c b/net/sched/cls_fw.c\nindex 941245ad07fd..99183b8621ec 100644\n--- a/net/sched/cls_fw.c\n+++ b/net/sched/cls_fw.c\n@@ -46,7 +46,10 @@ struct fw_filter {\n #endif /* CONFIG_NET_CLS_IND */\n \tstruct tcf_exts\t\texts;\n \tstruct tcf_proto\t*tp;\n-\tstruct rcu_head\t\trcu;\n+\tunion {\n+\t\tstruct work_struct\twork;\n+\t\tstruct rcu_head\t\trcu;\n+\t};\n };\n \n static u32 fw_hash(u32 handle)\n@@ -119,12 +122,22 @@ static int fw_init(struct tcf_proto *tp)\n \treturn 0;\n }\n \n-static void fw_delete_filter(struct rcu_head *head)\n+static void fw_delete_filter_work(struct work_struct *work)\n {\n-\tstruct fw_filter *f = container_of(head, struct fw_filter, rcu);\n+\tstruct fw_filter *f = container_of(work, struct fw_filter, work);\n \n+\trtnl_lock();\n \ttcf_exts_destroy(&f->exts);\n \tkfree(f);\n+\trtnl_unlock();\n+}\n+\n+static void fw_delete_filter(struct rcu_head *head)\n+{\n+\tstruct fw_filter *f = container_of(head, struct fw_filter, rcu);\n+\n+\tINIT_WORK(&f->work, fw_delete_filter_work);\n+\ttcf_queue_work(&f->work);\n }\n \n static void fw_destroy(struct tcf_proto *tp)\n","prefixes":["net","07/16"]}