{"id":831018,"url":"http://patchwork.ozlabs.org/api/1.2/patches/831018/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171027012443.3306-12-xiyou.wangcong@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171027012443.3306-12-xiyou.wangcong@gmail.com>","list_archive_url":null,"date":"2017-10-27T01:24:38","name":"[net,11/16] net_sched: use tcf_queue_work() in rsvp filter","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"a0375abb0b8301ec1ee630de6eacbaf5e6cdc00e","submitter":{"id":211,"url":"http://patchwork.ozlabs.org/api/1.2/people/211/?format=json","name":"Cong Wang","email":"xiyou.wangcong@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171027012443.3306-12-xiyou.wangcong@gmail.com/mbox/","series":[{"id":10472,"url":"http://patchwork.ozlabs.org/api/1.2/series/10472/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=10472","date":"2017-10-27T01:24:27","name":"net_sched: fix races with RCU callbacks","version":1,"mbox":"http://patchwork.ozlabs.org/series/10472/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/831018/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/831018/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Q3eartQn\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNR5S2fB1z9t2h\n\tfor ;\n\tFri, 27 Oct 2017 12:25:32 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932472AbdJ0BZa (ORCPT );\n\tThu, 26 Oct 2017 21:25:30 -0400","from mail-pf0-f194.google.com ([209.85.192.194]:46887 \"EHLO\n\tmail-pf0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932381AbdJ0BZM (ORCPT\n\t); Thu, 26 Oct 2017 21:25:12 -0400","by mail-pf0-f194.google.com with SMTP id p87so3779128pfj.3\n\tfor ; Thu, 26 Oct 2017 18:25:12 -0700 (PDT)","from tw-172-25-30-113.office.twttr.net ([8.25.197.25])\n\tby smtp.gmail.com with ESMTPSA id\n\tb16sm13211973pfe.58.2017.10.26.18.25.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 26 Oct 2017 18:25:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=erAo4LI91sYAgHqKT33cGuxTXpC0fy1PFca0XWXmuv4=;\n\tb=Q3eartQnXGogTL2lC/KDRUQvnbnWy+zi3nkbA8LTdDZbgnujROUdVlQUdFBfgSxjHS\n\t8sqoEPTz1G/fMY1fXuEnzMAE+qVS14i4zBnL7a19e99GgHl2hHJH+dDC7gZ67zutz7AM\n\t82QKoAbkW87n2Mga96IDz+iH+YowKmgvQMCaK7ueiC/ilmmpKC2gXubLMSqIAYbPOhMb\n\t86ckX1EqsrCBu4RE7bZNTJIf0YeBOtG3WGS7vmEWUxL7hsFDZ8WMl1VgOetmxhdCcpuW\n\tVVjTtPmGnaVqZwHnRP1dpwvDoHV2rn5HldfIymB+FbIQLy7Yjm5l6WCdm0MsFWJAzpH+\n\ttBNA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=erAo4LI91sYAgHqKT33cGuxTXpC0fy1PFca0XWXmuv4=;\n\tb=EuLEm0o3sFbeQdGSJ4+RrFt50XoFPCjr5ot1MSPXRUOfBSVOYH4Jm40JjIy+zuSeIL\n\t/V3NxGweRGACX5si58NOyDdRNBg/EzHYbIJh7YFECFM1dVxFVgHx8bFXMtfpiuPIXTXa\n\t3h4nMFrcNiRa14GPPJdL0XK534haetdXRZq+M2unwrs2Ztst5Htl0cHmHlHxFHc4CQdu\n\tz8YiqhcQNM4aN8o1/orVx4yhlp4Jfx0+wX6slq/gjt7IZHjWwhwxGAeyDw4cfWbFiXEy\n\tEBeHXp8mGJ7MwLXJ+tRJAw5x2RHQdOcUSIzwmxttpCe1QqHKuK+ohjsii1TcWmMwV0+Q\n\tYT4g==","X-Gm-Message-State":"AMCzsaUEphxw6Yqh8B1aaI5RTyOCsyUZ7xijTs/hfvJc0WjblQcHXc/y\n\tSJtWI0mLRKaKmrVy8m7euWx8fhjk","X-Google-Smtp-Source":"ABhQp+R5zVVCL+TJUY4p1dhu+oqHm+d+pBiSHY/bp51YikLKXkLHEAINtbjZuNUWRWrkgz/mqXKCfA==","X-Received":"by 10.99.63.199 with SMTP id m190mr6623244pga.239.1509067511452; \n\tThu, 26 Oct 2017 18:25:11 -0700 (PDT)","From":"Cong Wang ","To":"netdev@vger.kernel.org","Cc":"Chris Mi , Cong Wang ,\n\tDaniel Borkmann , Jiri Pirko ,\n\tJohn Fastabend ,\n\tJamal Hadi Salim ,\n\t\"Paul E. McKenney\" ","Subject":"[Patch net 11/16] net_sched: use tcf_queue_work() in rsvp filter","Date":"Thu, 26 Oct 2017 18:24:38 -0700","Message-Id":"<20171027012443.3306-12-xiyou.wangcong@gmail.com>","X-Mailer":"git-send-email 2.9.4","In-Reply-To":"<20171027012443.3306-1-xiyou.wangcong@gmail.com>","References":"<20171027012443.3306-1-xiyou.wangcong@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Defer the tcf_exts_destroy() in RCU callback to\ntc filter workqueue and get RTNL lock.\n\nReported-by: Chris Mi \nCc: Daniel Borkmann \nCc: Jiri Pirko \nCc: John Fastabend \nCc: Jamal Hadi Salim \nCc: \"Paul E. McKenney\" \nSigned-off-by: Cong Wang \n---\n net/sched/cls_rsvp.h | 19 ++++++++++++++++---\n 1 file changed, 16 insertions(+), 3 deletions(-)","diff":"diff --git a/net/sched/cls_rsvp.h b/net/sched/cls_rsvp.h\nindex b1f6ed48bc72..bdbc541787f8 100644\n--- a/net/sched/cls_rsvp.h\n+++ b/net/sched/cls_rsvp.h\n@@ -97,7 +97,10 @@ struct rsvp_filter {\n \n \tu32\t\t\t\thandle;\n \tstruct rsvp_session\t\t*sess;\n-\tstruct rcu_head\t\t\trcu;\n+\tunion {\n+\t\tstruct work_struct\t\twork;\n+\t\tstruct rcu_head\t\t\trcu;\n+\t};\n };\n \n static inline unsigned int hash_dst(__be32 *dst, u8 protocol, u8 tunnelid)\n@@ -282,12 +285,22 @@ static int rsvp_init(struct tcf_proto *tp)\n \treturn -ENOBUFS;\n }\n \n-static void rsvp_delete_filter_rcu(struct rcu_head *head)\n+static void rsvp_delete_filter_work(struct work_struct *work)\n {\n-\tstruct rsvp_filter *f = container_of(head, struct rsvp_filter, rcu);\n+\tstruct rsvp_filter *f = container_of(work, struct rsvp_filter, work);\n \n+\trtnl_lock();\n \ttcf_exts_destroy(&f->exts);\n \tkfree(f);\n+\trtnl_unlock();\n+}\n+\n+static void rsvp_delete_filter_rcu(struct rcu_head *head)\n+{\n+\tstruct rsvp_filter *f = container_of(head, struct rsvp_filter, rcu);\n+\n+\tINIT_WORK(&f->work, rsvp_delete_filter_work);\n+\ttcf_queue_work(&f->work);\n }\n \n static void rsvp_delete_filter(struct tcf_proto *tp, struct rsvp_filter *f)\n","prefixes":["net","11/16"]}