{"id":831015,"url":"http://patchwork.ozlabs.org/api/1.2/patches/831015/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171027012443.3306-9-xiyou.wangcong@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171027012443.3306-9-xiyou.wangcong@gmail.com>","list_archive_url":null,"date":"2017-10-27T01:24:35","name":"[net,08/16] net_sched: use tcf_queue_work() in matchall filter","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"08395fca0128980fbd94f55fe38731c504d3b25b","submitter":{"id":211,"url":"http://patchwork.ozlabs.org/api/1.2/people/211/?format=json","name":"Cong Wang","email":"xiyou.wangcong@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171027012443.3306-9-xiyou.wangcong@gmail.com/mbox/","series":[{"id":10472,"url":"http://patchwork.ozlabs.org/api/1.2/series/10472/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=10472","date":"2017-10-27T01:24:27","name":"net_sched: fix races with RCU callbacks","version":1,"mbox":"http://patchwork.ozlabs.org/series/10472/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/831015/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/831015/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"aTBUEGW5\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNR5F6q9vz9t2h\n\tfor ;\n\tFri, 27 Oct 2017 12:25:21 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932444AbdJ0BZU (ORCPT );\n\tThu, 26 Oct 2017 21:25:20 -0400","from mail-pf0-f196.google.com ([209.85.192.196]:43880 \"EHLO\n\tmail-pf0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751947AbdJ0BZI (ORCPT\n\t); Thu, 26 Oct 2017 21:25:08 -0400","by mail-pf0-f196.google.com with SMTP id a8so3783453pfc.0\n\tfor ; Thu, 26 Oct 2017 18:25:07 -0700 (PDT)","from tw-172-25-30-113.office.twttr.net ([8.25.197.25])\n\tby smtp.gmail.com with ESMTPSA id\n\tb16sm13211973pfe.58.2017.10.26.18.25.06\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 26 Oct 2017 18:25:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=EIplVLK3kNuogyZ0xB6lza/Nk7vaEp7eqITkMsSfy6Y=;\n\tb=aTBUEGW5JjxRnRTXXt43htumvNNpXrPks5uQ0GBKGV2gv/Ta/rUmutUPTSAdVVT7yg\n\tihW5d79qdMQI+uS4ISlwHnpMecGfYmWvvcvD2hcTH0B3tDZN7N5mtP5nz8lu08xgyW0q\n\tiWBKFkJk4jajLaT8WkqEm951DQbq6rerkMcTTyHK5uoYVDL80jwie0JaXeEPwy22Lahe\n\tS2WJtNK355GvpsTviswBldvefVhhXAWWqhGaIdA62AgiOMG3Xsp28WPtOxY+7D64PH9r\n\t2AYITwB7KgHklpW1yBraSpU18R77me/wFOfuNVoKlkIDI23Tr2zssTWqGEL9o0ZY6Ys2\n\t6BRQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=EIplVLK3kNuogyZ0xB6lza/Nk7vaEp7eqITkMsSfy6Y=;\n\tb=KwDqPJLOXpWQ4yrRzV/mLNDACzYKfR+XUO1T7MQrRnKVJsiI2uHAC9yxEYn+jCx5J/\n\tT60NAtu+3JRkh5/xUz2V5uIyd+cYlsN1BATotVxZooCdcrmNFGaWWJOk2vt4347SrnOz\n\t2Kcdk/g/kEkrWPq4WgxvXAnZH2WCKAB3dL1HE8Ca7g0OerF3TuPnZL0LTE8KRiXjksD6\n\tgUHVNp1YnRVNqFkb0nVSQpXp7zbbSAmXROGtgXvk+XDR72mlsB1o/5L1+z4yiJn2cfzF\n\tklXpZJNbr91IJ1bPWIJjJdoITF5qbFIICXJismb6E1h8t5SLTHqbI1Se884uhs6wY8vH\n\tjEMQ==","X-Gm-Message-State":"AMCzsaUJgtVoZeo1dzRpEOTPm8wpq9/gdmEdRlBC2O6cwdQWDaQuKXnf\n\tf9aWKHok9H3H0YmQ8J8jzTRTGdzf","X-Google-Smtp-Source":"ABhQp+QV9u2YZVfBeHNglPj0rLkMh3iI6iR4+sj0AChcw9cR8HbLfSaBT13Dij6eK5+OSBXmV1WGEw==","X-Received":"by 10.99.37.193 with SMTP id l184mr6818870pgl.14.1509067507253; \n\tThu, 26 Oct 2017 18:25:07 -0700 (PDT)","From":"Cong Wang ","To":"netdev@vger.kernel.org","Cc":"Chris Mi , Cong Wang ,\n\tDaniel Borkmann , Jiri Pirko ,\n\tJohn Fastabend ,\n\tJamal Hadi Salim ,\n\t\"Paul E. McKenney\" ","Subject":"[Patch net 08/16] net_sched: use tcf_queue_work() in matchall filter","Date":"Thu, 26 Oct 2017 18:24:35 -0700","Message-Id":"<20171027012443.3306-9-xiyou.wangcong@gmail.com>","X-Mailer":"git-send-email 2.9.4","In-Reply-To":"<20171027012443.3306-1-xiyou.wangcong@gmail.com>","References":"<20171027012443.3306-1-xiyou.wangcong@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Defer the tcf_exts_destroy() in RCU callback to\ntc filter workqueue and get RTNL lock.\n\nReported-by: Chris Mi \nCc: Daniel Borkmann \nCc: Jiri Pirko \nCc: John Fastabend \nCc: Jamal Hadi Salim \nCc: \"Paul E. McKenney\" \nSigned-off-by: Cong Wang \n---\n net/sched/cls_matchall.c | 19 ++++++++++++++++---\n 1 file changed, 16 insertions(+), 3 deletions(-)","diff":"diff --git a/net/sched/cls_matchall.c b/net/sched/cls_matchall.c\nindex eeac606c95ab..c33f711b9019 100644\n--- a/net/sched/cls_matchall.c\n+++ b/net/sched/cls_matchall.c\n@@ -21,7 +21,10 @@ struct cls_mall_head {\n \tstruct tcf_result res;\n \tu32 handle;\n \tu32 flags;\n-\tstruct rcu_head\trcu;\n+\tunion {\n+\t\tstruct work_struct work;\n+\t\tstruct rcu_head\trcu;\n+\t};\n };\n \n static int mall_classify(struct sk_buff *skb, const struct tcf_proto *tp,\n@@ -41,13 +44,23 @@ static int mall_init(struct tcf_proto *tp)\n \treturn 0;\n }\n \n+static void mall_destroy_work(struct work_struct *work)\n+{\n+\tstruct cls_mall_head *head = container_of(work, struct cls_mall_head,\n+\t\t\t\t\t\t work);\n+\trtnl_lock();\n+\ttcf_exts_destroy(&head->exts);\n+\tkfree(head);\n+\trtnl_unlock();\n+}\n+\n static void mall_destroy_rcu(struct rcu_head *rcu)\n {\n \tstruct cls_mall_head *head = container_of(rcu, struct cls_mall_head,\n \t\t\t\t\t\t rcu);\n \n-\ttcf_exts_destroy(&head->exts);\n-\tkfree(head);\n+\tINIT_WORK(&head->work, mall_destroy_work);\n+\ttcf_queue_work(&head->work);\n }\n \n static int mall_replace_hw_filter(struct tcf_proto *tp,\n","prefixes":["net","08/16"]}