{"id":831014,"url":"http://patchwork.ozlabs.org/api/1.2/patches/831014/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171027012443.3306-7-xiyou.wangcong@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171027012443.3306-7-xiyou.wangcong@gmail.com>","list_archive_url":null,"date":"2017-10-27T01:24:33","name":"[net,06/16] net_sched: use tcf_queue_work() in flower filter","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"3cea479d552caac0d50bef6f183f6ea9e98e530e","submitter":{"id":211,"url":"http://patchwork.ozlabs.org/api/1.2/people/211/?format=json","name":"Cong Wang","email":"xiyou.wangcong@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171027012443.3306-7-xiyou.wangcong@gmail.com/mbox/","series":[{"id":10472,"url":"http://patchwork.ozlabs.org/api/1.2/series/10472/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=10472","date":"2017-10-27T01:24:27","name":"net_sched: fix races with RCU callbacks","version":1,"mbox":"http://patchwork.ozlabs.org/series/10472/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/831014/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/831014/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lG2o+zU7\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNR5C1fMcz9t2h\n\tfor ;\n\tFri, 27 Oct 2017 12:25:19 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932427AbdJ0BZQ (ORCPT );\n\tThu, 26 Oct 2017 21:25:16 -0400","from mail-pg0-f65.google.com ([74.125.83.65]:55297 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751932AbdJ0BZF (ORCPT\n\t); Thu, 26 Oct 2017 21:25:05 -0400","by mail-pg0-f65.google.com with SMTP id 15so4040899pgc.12\n\tfor ; Thu, 26 Oct 2017 18:25:05 -0700 (PDT)","from tw-172-25-30-113.office.twttr.net ([8.25.197.25])\n\tby smtp.gmail.com with ESMTPSA id\n\tb16sm13211973pfe.58.2017.10.26.18.25.03\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 26 Oct 2017 18:25:04 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=8p2FGTmYORuDrogNtDcfPm3sWhRQiVY+Rqe80UujhCA=;\n\tb=lG2o+zU7sHnX0N3yK8+k9U4g/4y48BVAf5LfDEDAGjNKwZtBuuJOI3f/C7Z+6ANXVn\n\tD8Lvq1ukT51gtl+gJpGIaxYP2LvSMZwzyK4Gt4EL6eqRlhPWOjjlKJhZVml1GaviD9EC\n\ts4FxO9vCS+QLRhi9t99m9+kIJH0zT1h6vo1ypkQq2dq9lz62JQCNp84qHsig7q0fcgIx\n\tEEfZHn3HTDAv2mv8vG6wLKHV5uqFMT/01cpEav6Befm9ejHa9+QxWhrwHPegYQE/s+4I\n\tEpHWXIrbKpgS1emNvJVykzt5wPLIoF05LiRNuPMWEH9P/7BZ4QPdclwEFcfizxEZgC0P\n\tLeYg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=8p2FGTmYORuDrogNtDcfPm3sWhRQiVY+Rqe80UujhCA=;\n\tb=k78wBv+mp3b8PYvfaRSpAscOQ6s2kq4amokQV1kHIAcTFeCvpVVfMN5ACFb8DK4L1j\n\tXlf06MR7GjneSJSIKKF+xGw+Pb/Uleh80MZ4DN+Nf/yEejgG9/+ajFjLRQ9lruTr50AR\n\tLx4Xj2n0gfz2vWXZgfPtwAWOLhNmJnFcAeVKTf29y7lqDacAwbKLxnLXbsIgRnwrPyyf\n\tx+OFO3/CeqW5GDnZlqFDRhv2U7lQ05H0nSjD9B/NArbSpcsita7YFDseL/c4+UPHJqz4\n\tQjGNuu4X3AAEc5W0TErUg88hLKndpH8JoWnCyMPa3eYZeD7r7tP3bnOncRcnn93dh/1W\n\tNTEA==","X-Gm-Message-State":"AMCzsaVktcAWzifqnbk9Vs3HyXPubBfrUfPZ1CT38FSchrXb80qAYwAM\n\tFRTfYiOyJHNiPMz9N6uGZfO7Opub","X-Google-Smtp-Source":"ABhQp+RVSmsjdCmXDKzrWFTa0kdjJiAWIcld+k+5FXlCLw5cm3VWCjFQuplr7BzttSTpsD7ZvXtkZg==","X-Received":"by 10.99.122.92 with SMTP id j28mr6539498pgn.154.1509067504928; \n\tThu, 26 Oct 2017 18:25:04 -0700 (PDT)","From":"Cong Wang ","To":"netdev@vger.kernel.org","Cc":"Chris Mi , Cong Wang ,\n\tDaniel Borkmann , Jiri Pirko ,\n\tJohn Fastabend ,\n\tJamal Hadi Salim ,\n\t\"Paul E. McKenney\" ","Subject":"[Patch net 06/16] net_sched: use tcf_queue_work() in flower filter","Date":"Thu, 26 Oct 2017 18:24:33 -0700","Message-Id":"<20171027012443.3306-7-xiyou.wangcong@gmail.com>","X-Mailer":"git-send-email 2.9.4","In-Reply-To":"<20171027012443.3306-1-xiyou.wangcong@gmail.com>","References":"<20171027012443.3306-1-xiyou.wangcong@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Defer the tcf_exts_destroy() in RCU callback to\ntc filter workqueue and get RTNL lock.\n\nReported-by: Chris Mi \nCc: Daniel Borkmann \nCc: Jiri Pirko \nCc: John Fastabend \nCc: Jamal Hadi Salim \nCc: \"Paul E. McKenney\" \nSigned-off-by: Cong Wang \n---\n net/sched/cls_flower.c | 19 ++++++++++++++++---\n 1 file changed, 16 insertions(+), 3 deletions(-)","diff":"diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c\nindex b480d7c792ba..5b5722c8b32c 100644\n--- a/net/sched/cls_flower.c\n+++ b/net/sched/cls_flower.c\n@@ -87,7 +87,10 @@ struct cls_fl_filter {\n \tstruct list_head list;\n \tu32 handle;\n \tu32 flags;\n-\tstruct rcu_head\trcu;\n+\tunion {\n+\t\tstruct work_struct work;\n+\t\tstruct rcu_head\trcu;\n+\t};\n \tstruct net_device *hw_dev;\n };\n \n@@ -215,12 +218,22 @@ static int fl_init(struct tcf_proto *tp)\n \treturn 0;\n }\n \n-static void fl_destroy_filter(struct rcu_head *head)\n+static void fl_destroy_filter_work(struct work_struct *work)\n {\n-\tstruct cls_fl_filter *f = container_of(head, struct cls_fl_filter, rcu);\n+\tstruct cls_fl_filter *f = container_of(work, struct cls_fl_filter, work);\n \n+\trtnl_lock();\n \ttcf_exts_destroy(&f->exts);\n \tkfree(f);\n+\trtnl_unlock();\n+}\n+\n+static void fl_destroy_filter(struct rcu_head *head)\n+{\n+\tstruct cls_fl_filter *f = container_of(head, struct cls_fl_filter, rcu);\n+\n+\tINIT_WORK(&f->work, fl_destroy_filter_work);\n+\ttcf_queue_work(&f->work);\n }\n \n static void fl_hw_destroy_filter(struct tcf_proto *tp, struct cls_fl_filter *f)\n","prefixes":["net","06/16"]}