{"id":831009,"url":"http://patchwork.ozlabs.org/api/1.2/patches/831009/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171027012443.3306-4-xiyou.wangcong@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171027012443.3306-4-xiyou.wangcong@gmail.com>","list_archive_url":null,"date":"2017-10-27T01:24:30","name":"[net,03/16] net_sched: use tcf_queue_work() in bpf filter","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"3c8fdf8276237ac3b8ecc8d4a35992511b08f5fa","submitter":{"id":211,"url":"http://patchwork.ozlabs.org/api/1.2/people/211/?format=json","name":"Cong Wang","email":"xiyou.wangcong@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171027012443.3306-4-xiyou.wangcong@gmail.com/mbox/","series":[{"id":10472,"url":"http://patchwork.ozlabs.org/api/1.2/series/10472/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=10472","date":"2017-10-27T01:24:27","name":"net_sched: fix races with RCU callbacks","version":1,"mbox":"http://patchwork.ozlabs.org/series/10472/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/831009/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/831009/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"KaUhcMha\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNR4z06d1z9t2h\n\tfor ;\n\tFri, 27 Oct 2017 12:25:07 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751990AbdJ0BZE (ORCPT );\n\tThu, 26 Oct 2017 21:25:04 -0400","from mail-pf0-f195.google.com ([209.85.192.195]:45732 \"EHLO\n\tmail-pf0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751932AbdJ0BZB (ORCPT\n\t); Thu, 26 Oct 2017 21:25:01 -0400","by mail-pf0-f195.google.com with SMTP id d28so3776422pfe.2\n\tfor ; Thu, 26 Oct 2017 18:25:01 -0700 (PDT)","from tw-172-25-30-113.office.twttr.net ([8.25.197.25])\n\tby smtp.gmail.com with ESMTPSA id\n\tb16sm13211973pfe.58.2017.10.26.18.25.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 26 Oct 2017 18:25:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=GgpM0cUr0qpnYfyidzHxBY0vpopQCPJxnumXC0aZH/Q=;\n\tb=KaUhcMhaopxQVutC/jgJSlgCVKfQyor2B78jpHz9CIse8jR1EfY7bdr47IyXV0feJO\n\tP421TEKQg4BkmarfUrHs0TsKrHgJOcXk7UqBLv4c6bTygknWVGOqWCRZ/fpsSzlEAqss\n\t6Ru1MpWtvID7lBgDRdVgiTLFlUosxlFN4/Isqn4u9dA0J/ydzj8VZzndWHgmm0Ejgdu/\n\t2VA6H3M4D38LJ84aDNl+hiUaJrERl+GkPhQlRsTBs7mO/iduYKSQLO9sJDPrNS0wuYmT\n\tG6qvKlsvs8bVZchozZloDBrABFR+6V5EoROhzWjYlX6eMeDb10NwI7ZcVDm5GgHrkfPn\n\tA9Tg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=GgpM0cUr0qpnYfyidzHxBY0vpopQCPJxnumXC0aZH/Q=;\n\tb=NKF9Q5KnZTWpeWhRwgl8pqyW5nTI/dWMfmQa8iccQfpR5a3zCxEExJ25AEpdOj4nhB\n\tauE0zRNokf3UIDmjASvUVYwC7df7dVQm6YieGNl6goNRL3aGzmY+wyCe64Vx9U3ZWThW\n\tQY7l7iv/yJkWmNenjE14Jgu9ydywTgpZdIOFme0jMdCbypb494MDqJN51fGstiG6rHF+\n\tGJ4xDU/KgpjjaigTnyRxfOObCbOcx4lCktgYe+taCdFdGABcvIbGHFbdl8JkciqMp3Fb\n\tMz/HRvmw4A93b4TOyXfJNTRE8Iq88xBBVfiLj86bqGyGO2rl4r9ZH8K2hbKmWnkm1JWY\n\tIvKA==","X-Gm-Message-State":"AMCzsaXWMwcuggzL4UqktOH8TCeeUTf3fppmxMEfBHTATjXpfrVJP+6N\n\tzDAkoLi3PFa3077c00AvtlwddSvd","X-Google-Smtp-Source":"ABhQp+T19DFN8SaFtKuV01JH1SuDRSKJ1ODaFPc4GL0HOOKyjAPBdGyQokrzS3mWsguF9WKTbh7b2w==","X-Received":"by 10.84.252.149 with SMTP id y21mr5902643pll.364.1509067501294; \n\tThu, 26 Oct 2017 18:25:01 -0700 (PDT)","From":"Cong Wang ","To":"netdev@vger.kernel.org","Cc":"Chris Mi , Cong Wang ,\n\tDaniel Borkmann , Jiri Pirko ,\n\tJohn Fastabend ,\n\tJamal Hadi Salim ,\n\t\"Paul E. McKenney\" ","Subject":"[Patch net 03/16] net_sched: use tcf_queue_work() in bpf filter","Date":"Thu, 26 Oct 2017 18:24:30 -0700","Message-Id":"<20171027012443.3306-4-xiyou.wangcong@gmail.com>","X-Mailer":"git-send-email 2.9.4","In-Reply-To":"<20171027012443.3306-1-xiyou.wangcong@gmail.com>","References":"<20171027012443.3306-1-xiyou.wangcong@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Defer the tcf_exts_destroy() in RCU callback to\ntc filter workqueue and get RTNL lock.\n\nReported-by: Chris Mi \nCc: Daniel Borkmann \nCc: Jiri Pirko \nCc: John Fastabend \nCc: Jamal Hadi Salim \nCc: \"Paul E. McKenney\" \nSigned-off-by: Cong Wang \n---\n net/sched/cls_bpf.c | 19 +++++++++++++++++--\n 1 file changed, 17 insertions(+), 2 deletions(-)","diff":"diff --git a/net/sched/cls_bpf.c b/net/sched/cls_bpf.c\nindex 520c5027646a..037a3ae86829 100644\n--- a/net/sched/cls_bpf.c\n+++ b/net/sched/cls_bpf.c\n@@ -49,7 +49,10 @@ struct cls_bpf_prog {\n \tstruct sock_filter *bpf_ops;\n \tconst char *bpf_name;\n \tstruct tcf_proto *tp;\n-\tstruct rcu_head rcu;\n+\tunion {\n+\t\tstruct work_struct work;\n+\t\tstruct rcu_head rcu;\n+\t};\n };\n \n static const struct nla_policy bpf_policy[TCA_BPF_MAX + 1] = {\n@@ -257,9 +260,21 @@ static void __cls_bpf_delete_prog(struct cls_bpf_prog *prog)\n \tkfree(prog);\n }\n \n+static void cls_bpf_delete_prog_work(struct work_struct *work)\n+{\n+\tstruct cls_bpf_prog *prog = container_of(work, struct cls_bpf_prog, work);\n+\n+\trtnl_lock();\n+\t__cls_bpf_delete_prog(prog);\n+\trtnl_unlock();\n+}\n+\n static void cls_bpf_delete_prog_rcu(struct rcu_head *rcu)\n {\n-\t__cls_bpf_delete_prog(container_of(rcu, struct cls_bpf_prog, rcu));\n+\tstruct cls_bpf_prog *prog = container_of(rcu, struct cls_bpf_prog, rcu);\n+\n+\tINIT_WORK(&prog->work, cls_bpf_delete_prog_work);\n+\ttcf_queue_work(&prog->work);\n }\n \n static void __cls_bpf_delete(struct tcf_proto *tp, struct cls_bpf_prog *prog)\n","prefixes":["net","03/16"]}