{"id":830995,"url":"http://patchwork.ozlabs.org/api/1.2/patches/830995/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171026233526.6155-14-edumazet@google.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171026233526.6155-14-edumazet@google.com>","list_archive_url":null,"date":"2017-10-26T23:35:24","name":"[net-next,13/15] tcp: Namespace-ify sysctl_tcp_app_win","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"a89b2e7b6fab9a2b9e43b3109c87a42bc7d20be4","submitter":{"id":13357,"url":"http://patchwork.ozlabs.org/api/1.2/people/13357/?format=json","name":"Eric Dumazet","email":"edumazet@google.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171026233526.6155-14-edumazet@google.com/mbox/","series":[{"id":10461,"url":"http://patchwork.ozlabs.org/api/1.2/series/10461/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=10461","date":"2017-10-26T23:35:11","name":"tcp: move 14 sysctls to namespaces","version":1,"mbox":"http://patchwork.ozlabs.org/series/10461/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/830995/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/830995/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"ea51o+Ep\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNNgW5ZBQz9t2S\n\tfor ;\n\tFri, 27 Oct 2017 10:36:23 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932502AbdJZXgW (ORCPT );\n\tThu, 26 Oct 2017 19:36:22 -0400","from mail-pg0-f66.google.com ([74.125.83.66]:55112 \"EHLO\n\tmail-pg0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932466AbdJZXgD (ORCPT\n\t); Thu, 26 Oct 2017 19:36:03 -0400","by mail-pg0-f66.google.com with SMTP id l24so3879271pgu.11\n\tfor ; Thu, 26 Oct 2017 16:36:03 -0700 (PDT)","from localhost ([2620:15c:2c4:201:c5be:583d:61a8:d070])\n\tby smtp.gmail.com with ESMTPSA id\n\tw5sm11498546pfw.51.2017.10.26.16.36.01\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tThu, 26 Oct 2017 16:36:01 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=4dU9mlJTdyEhFpVOOwoiop2CKpDxwfNoiV/V+gxIb5U=;\n\tb=ea51o+EpNbQ1uesW+AePOTJ1Lmpsxum6h+bRZ5CMv44mS5FGBC+v6asD5Drcmgzg4Q\n\tavQFlaZ7fcG31AsY5FIjrsZxI0xBRfRj6uAuqHZGPfZmJ8wauVlScuWVrbqMY15r+YeS\n\tfCvlZbx0PaI7p8k3kk5amvgYkieahJOQVpQIoOwJw7SStkQNjnhHpHpnao6d+V+fRSOw\n\tF4JGP/dKX2hhzqwCCi20v746xP5FwkcaX9OLFUkw4adGLI7Wnq9WnT3Y3NSGXFYRgJY0\n\t+5FC9IL28h1FvgMazU14+4ip3N9y2E0lrIXn8UFo0+AhxtKuzmNo7z7+svFq8mCBz522\n\tUrCA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=4dU9mlJTdyEhFpVOOwoiop2CKpDxwfNoiV/V+gxIb5U=;\n\tb=sz+6sl9Y1Oi9KzqW4YPtpptNeztZCtPZoHo61wSWxx+iesPuSlQNgACoS8rO+9kVNn\n\t97jZKIKupddlEFSyHCHV0EPjM0ntuUg86ndXrQETnaTBbowGiUWIDTsKSMr3kwtVBcue\n\tnQidRDCFz6OVsZLl/WIhy0gXD/jDBqp6ikbQmTGrMc7xQnZsqm6sAhTjuh30FsjpXT3a\n\tONZ05nU6yKjFESBW98SnxlHx95PP6W0K7tn7kejZYGh0nBSUfOR5qDGAgk2c1qZ4Teji\n\t62FEIyoZfoX3O3PcRk669p+xd2UBwLfK37tb4uV5Nnt8rHVWRAr0QhLRph1Ue8mGhWmw\n\todgA==","X-Gm-Message-State":"AMCzsaU0JOPTOSZqez+0vZ3caORzr34cVWZaZHRYvERmP+r1qciSOYED\n\tp/e3Yp3L4zpmUZrnYLXoGbhUXQ==","X-Google-Smtp-Source":"ABhQp+SC7MRiWn5WPN/9dlnyj1LFw/u8SSPUkT+RMn8jIzKRqoCfgPZWVd90LG3HcJnubttK+6xL9w==","X-Received":"by 10.98.141.209 with SMTP id p78mr6790966pfk.263.1509060962401; \n\tThu, 26 Oct 2017 16:36:02 -0700 (PDT)","From":"Eric Dumazet ","To":"\"David S . Miller\" ","Cc":"netdev , Eric Dumazet ,\n\tEric Dumazet ","Subject":"[PATCH net-next 13/15] tcp: Namespace-ify sysctl_tcp_app_win","Date":"Thu, 26 Oct 2017 16:35:24 -0700","Message-Id":"<20171026233526.6155-14-edumazet@google.com>","X-Mailer":"git-send-email 2.15.0.rc2.357.g7e34df9404-goog","In-Reply-To":"<20171026233526.6155-1-edumazet@google.com>","References":"<20171026233526.6155-1-edumazet@google.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Signed-off-by: Eric Dumazet \n---\n include/net/netns/ipv4.h | 1 +\n include/net/tcp.h | 1 -\n net/ipv4/sysctl_net_ipv4.c | 14 +++++++-------\n net/ipv4/tcp_input.c | 8 ++++----\n net/ipv4/tcp_ipv4.c | 1 +\n 5 files changed, 13 insertions(+), 12 deletions(-)","diff":"diff --git a/include/net/netns/ipv4.h b/include/net/netns/ipv4.h\nindex 956957a77db96ad3d231cc018c13503d615d8d2e..63f91d52cbc0ad35d8e04a8da0d9f57aa960bcb0 100644\n--- a/include/net/netns/ipv4.h\n+++ b/include/net/netns/ipv4.h\n@@ -139,6 +139,7 @@ struct netns_ipv4 {\n \tint sysctl_tcp_fack;\n \tint sysctl_tcp_max_reordering;\n \tint sysctl_tcp_dsack;\n+\tint sysctl_tcp_app_win;\n \tstruct inet_timewait_death_row tcp_death_row;\n \tint sysctl_max_syn_backlog;\n \tint sysctl_tcp_fastopen;\ndiff --git a/include/net/tcp.h b/include/net/tcp.h\nindex aba20c4828ee912d9f0f3ef49f3de5376729c022..c6bee85a3dec0dea6d4402d89184ade02a637a2e 100644\n--- a/include/net/tcp.h\n+++ b/include/net/tcp.h\n@@ -244,7 +244,6 @@ extern int sysctl_tcp_max_orphans;\n extern long sysctl_tcp_mem[3];\n extern int sysctl_tcp_wmem[3];\n extern int sysctl_tcp_rmem[3];\n-extern int sysctl_tcp_app_win;\n extern int sysctl_tcp_adv_win_scale;\n extern int sysctl_tcp_frto;\n extern int sysctl_tcp_nometrics_save;\ndiff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c\nindex 7652a9c2a65d3f1cfa0a75d1198e1d9d56761c35..e057788834a99cf99e141a602ddbe19b8e6fce3c 100644\n--- a/net/ipv4/sysctl_net_ipv4.c\n+++ b/net/ipv4/sysctl_net_ipv4.c\n@@ -437,13 +437,6 @@ static struct ctl_table ipv4_table[] = {\n \t\t.proc_handler\t= proc_dointvec_minmax,\n \t\t.extra1\t\t= &one,\n \t},\n-\t{\n-\t\t.procname\t= \"tcp_app_win\",\n-\t\t.data\t\t= &sysctl_tcp_app_win,\n-\t\t.maxlen\t\t= sizeof(int),\n-\t\t.mode\t\t= 0644,\n-\t\t.proc_handler\t= proc_dointvec\n-\t},\n \t{\n \t\t.procname\t= \"tcp_adv_win_scale\",\n \t\t.data\t\t= &sysctl_tcp_adv_win_scale,\n@@ -1145,6 +1138,13 @@ static struct ctl_table ipv4_net_table[] = {\n \t\t.mode\t\t= 0644,\n \t\t.proc_handler\t= proc_dointvec\n \t},\n+\t{\n+\t\t.procname\t= \"tcp_app_win\",\n+\t\t.data\t\t= &init_net.ipv4.sysctl_tcp_app_win,\n+\t\t.maxlen\t\t= sizeof(int),\n+\t\t.mode\t\t= 0644,\n+\t\t.proc_handler\t= proc_dointvec\n+\t},\n \t{ }\n };\n \ndiff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c\nindex db4798f99bb093b6d5a3e0fdd76efb83b88da49e..06a8c27e1a690e3b26cb6773320bafa31b06d3b3 100644\n--- a/net/ipv4/tcp_input.c\n+++ b/net/ipv4/tcp_input.c\n@@ -77,7 +77,6 @@\n #include \n #include \n \n-int sysctl_tcp_app_win __read_mostly = 31;\n int sysctl_tcp_adv_win_scale __read_mostly = 1;\n EXPORT_SYMBOL(sysctl_tcp_adv_win_scale);\n \n@@ -426,6 +425,7 @@ static void tcp_fixup_rcvbuf(struct sock *sk)\n */\n void tcp_init_buffer_space(struct sock *sk)\n {\n+\tint tcp_app_win = sock_net(sk)->ipv4.sysctl_tcp_app_win;\n \tstruct tcp_sock *tp = tcp_sk(sk);\n \tint maxwin;\n \n@@ -444,14 +444,14 @@ void tcp_init_buffer_space(struct sock *sk)\n \tif (tp->window_clamp >= maxwin) {\n \t\ttp->window_clamp = maxwin;\n \n-\t\tif (sysctl_tcp_app_win && maxwin > 4 * tp->advmss)\n+\t\tif (tcp_app_win && maxwin > 4 * tp->advmss)\n \t\t\ttp->window_clamp = max(maxwin -\n-\t\t\t\t\t (maxwin >> sysctl_tcp_app_win),\n+\t\t\t\t\t (maxwin >> tcp_app_win),\n \t\t\t\t\t 4 * tp->advmss);\n \t}\n \n \t/* Force reservation of one segment. */\n-\tif (sysctl_tcp_app_win &&\n+\tif (tcp_app_win &&\n \t tp->window_clamp > 2 * tp->advmss &&\n \t tp->window_clamp + tp->advmss > maxwin)\n \t\ttp->window_clamp = max(2 * tp->advmss, maxwin - tp->advmss);\ndiff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c\nindex d9d4d191e8f3c962a6ee68015ffe5a6e7fb8e9c1..189664ebd28e4cda7ef40a47591c3bd8cac3574b 100644\n--- a/net/ipv4/tcp_ipv4.c\n+++ b/net/ipv4/tcp_ipv4.c\n@@ -2490,6 +2490,7 @@ static int __net_init tcp_sk_init(struct net *net)\n \tnet->ipv4.sysctl_tcp_retrans_collapse = 1;\n \tnet->ipv4.sysctl_tcp_max_reordering = 300;\n \tnet->ipv4.sysctl_tcp_dsack = 1;\n+\tnet->ipv4.sysctl_tcp_app_win = 31;\n \n \tnet->ipv4.sysctl_tcp_fastopen = TFO_CLIENT_ENABLE;\n \tspin_lock_init(&net->ipv4.tcp_fastopen_ctx_lock);\n","prefixes":["net-next","13/15"]}