{"id":830994,"url":"http://patchwork.ozlabs.org/api/1.2/patches/830994/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171026233526.6155-8-edumazet@google.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171026233526.6155-8-edumazet@google.com>","list_archive_url":null,"date":"2017-10-26T23:35:18","name":"[net-next,07/15] tcp: Namespace-ify sysctl_tcp_rfc1337","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"3ad1b15398f5b27cd764fae01e3f0c8ac646f54a","submitter":{"id":13357,"url":"http://patchwork.ozlabs.org/api/1.2/people/13357/?format=json","name":"Eric Dumazet","email":"edumazet@google.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171026233526.6155-8-edumazet@google.com/mbox/","series":[{"id":10461,"url":"http://patchwork.ozlabs.org/api/1.2/series/10461/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=10461","date":"2017-10-26T23:35:11","name":"tcp: move 14 sysctls to namespaces","version":1,"mbox":"http://patchwork.ozlabs.org/series/10461/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/830994/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/830994/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"HK8mw60N\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNNgW0YL7z9sxR\n\tfor ;\n\tFri, 27 Oct 2017 10:36:23 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932460AbdJZXfz (ORCPT );\n\tThu, 26 Oct 2017 19:35:55 -0400","from mail-pg0-f66.google.com ([74.125.83.66]:55095 \"EHLO\n\tmail-pg0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932381AbdJZXfu (ORCPT\n\t); Thu, 26 Oct 2017 19:35:50 -0400","by mail-pg0-f66.google.com with SMTP id l24so3878914pgu.11\n\tfor ; Thu, 26 Oct 2017 16:35:49 -0700 (PDT)","from localhost ([2620:15c:2c4:201:c5be:583d:61a8:d070])\n\tby smtp.gmail.com with ESMTPSA id\n\tf85sm13169800pfj.5.2017.10.26.16.35.48\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tThu, 26 Oct 2017 16:35:48 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=bL8AV9wfGN9xZX/5qs0/0YOPuD104/dzDSgElZ92rZo=;\n\tb=HK8mw60NDUcByAVY/gjq9ONdZVyFUYkvfYXhJMRZZxoHGyEDHaa0l5FRej/RGtZVTB\n\tklRprDFmxCZNansraR+3J6kE7uvRT9v78nFko7xUA0pBBuknoNfKH9iTc/KfPHLNVrA6\n\tcMtjkGWCpSpiENCRsypFyJRyzAtVdgeAcTirDfZ7k+AHBc1dvfFlU/iXZqU5nZR+zmu7\n\tYNBw67vBLQW1EiYDP4s6SYKF+OR67HNHFQqIKQ5UREHozTJSRCpCqvlHDnvVWIDqn0Zl\n\tHr3z01p7jnMHCPr9ou13XJ5QJ+5NWxgC5kcN2TPdFWeoDrtnL9A0Hd4L2qP7igjL6BBn\n\t8jJw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=bL8AV9wfGN9xZX/5qs0/0YOPuD104/dzDSgElZ92rZo=;\n\tb=dVieqOhbX3SgCxW2lwytMJwYKlfYGvxRCJEejplBl6/EaYRcWYaHqSvmpFT5TBH7Bp\n\t0o72kn8dgkw9KHWs5wxN+gHoYZzifKGb8hoQc4s1AbQNOowQPAPBf/Z3haI7RQ79kAR1\n\trs05zlCkO5xIILNxHEolRNeg9fUzR9QPBB5KTuX3pJEPI3MuKG06uqPiT9/aGzCz/hGM\n\tQx9s6EAxMuWqJ0AIqxoXu5UulMC/VC8uCHwlHIWmEurNvTbntk34LALtwXHCiJtLYcci\n\traBvlAMroWrDst94dWS/C6TMP2LT6lXYZUwuQq4Zw2Q9Q08IXYhKZpAZcpL3zyxlJ4sy\n\tMAaQ==","X-Gm-Message-State":"AMCzsaWTAqjA736ss/k3mz3amdNOk7CAG2e5h3lIbPS6/GQ4rXN6S/qu\n\tgl1EGblqIoXLp4b8oiweTxIcZA==","X-Google-Smtp-Source":"ABhQp+ThH42QmgOoQ3oeh2J/oa1unAhYCzEqKJcRcNTCg0cD7Lwf7US2r65yrfqN8wJdc+lhtK6zXQ==","X-Received":"by 10.84.233.70 with SMTP id k6mr5708702plt.134.1509060948751;\n\tThu, 26 Oct 2017 16:35:48 -0700 (PDT)","From":"Eric Dumazet ","To":"\"David S . Miller\" ","Cc":"netdev , Eric Dumazet ,\n\tEric Dumazet ","Subject":"[PATCH net-next 07/15] tcp: Namespace-ify sysctl_tcp_rfc1337","Date":"Thu, 26 Oct 2017 16:35:18 -0700","Message-Id":"<20171026233526.6155-8-edumazet@google.com>","X-Mailer":"git-send-email 2.15.0.rc2.357.g7e34df9404-goog","In-Reply-To":"<20171026233526.6155-1-edumazet@google.com>","References":"<20171026233526.6155-1-edumazet@google.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Signed-off-by: Eric Dumazet \n---\n include/net/netns/ipv4.h | 1 +\n include/net/tcp.h | 1 -\n net/ipv4/sysctl_net_ipv4.c | 14 +++++++-------\n net/ipv4/tcp_input.c | 1 -\n net/ipv4/tcp_minisocks.c | 2 +-\n 5 files changed, 9 insertions(+), 10 deletions(-)","diff":"diff --git a/include/net/netns/ipv4.h b/include/net/netns/ipv4.h\nindex ffa2cf3dc747ca9443df3927dc7928c18357f872..968edce38eb5d3399724b3142277eab44f19f2fb 100644\n--- a/include/net/netns/ipv4.h\n+++ b/include/net/netns/ipv4.h\n@@ -134,6 +134,7 @@ struct netns_ipv4 {\n \tint sysctl_tcp_slow_start_after_idle;\n \tint sysctl_tcp_retrans_collapse;\n \tint sysctl_tcp_stdurg;\n+\tint sysctl_tcp_rfc1337;\n \tstruct inet_timewait_death_row tcp_death_row;\n \tint sysctl_max_syn_backlog;\n \tint sysctl_tcp_fastopen;\ndiff --git a/include/net/tcp.h b/include/net/tcp.h\nindex 0cf9de8506916c67369ce78833207ba648f34a10..7f88987bc62dd76206c15eb91f2990d4469e5421 100644\n--- a/include/net/tcp.h\n+++ b/include/net/tcp.h\n@@ -240,7 +240,6 @@ void tcp_time_wait(struct sock *sk, int state, int timeo);\n \n \n /* sysctl variables for tcp */\n-extern int sysctl_tcp_rfc1337;\n extern int sysctl_tcp_abort_on_overflow;\n extern int sysctl_tcp_max_orphans;\n extern int sysctl_tcp_fack;\ndiff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c\nindex a34bb75815c15afc077ba7ff36939b5abc9229f6..832e554235df37770809541ad8f9f1ca2f201739 100644\n--- a/net/ipv4/sysctl_net_ipv4.c\n+++ b/net/ipv4/sysctl_net_ipv4.c\n@@ -400,13 +400,6 @@ static struct ctl_table ipv4_table[] = {\n \t\t.mode\t\t= 0644,\n \t\t.proc_handler\t= proc_dointvec\n \t},\n-\t{\n-\t\t.procname\t= \"tcp_rfc1337\",\n-\t\t.data\t\t= &sysctl_tcp_rfc1337,\n-\t\t.maxlen\t\t= sizeof(int),\n-\t\t.mode\t\t= 0644,\n-\t\t.proc_handler\t= proc_dointvec\n-\t},\n \t{\n \t\t.procname\t= \"inet_peer_threshold\",\n \t\t.data\t\t= &inet_peer_threshold,\n@@ -1145,6 +1138,13 @@ static struct ctl_table ipv4_net_table[] = {\n \t\t.mode\t\t= 0644,\n \t\t.proc_handler\t= proc_dointvec\n \t},\n+\t{\n+\t\t.procname\t= \"tcp_rfc1337\",\n+\t\t.data\t\t= &init_net.ipv4.sysctl_tcp_rfc1337,\n+\t\t.maxlen\t\t= sizeof(int),\n+\t\t.mode\t\t= 0644,\n+\t\t.proc_handler\t= proc_dointvec\n+\t},\n \t{ }\n };\n \ndiff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c\nindex 6c3655b538f6b2315af7dc611acc574f7489bde6..d2d3f62387a98d7f955f8c9e27320b9722035b2a 100644\n--- a/net/ipv4/tcp_input.c\n+++ b/net/ipv4/tcp_input.c\n@@ -87,7 +87,6 @@ EXPORT_SYMBOL(sysctl_tcp_adv_win_scale);\n /* rfc5961 challenge ack rate limiting */\n int sysctl_tcp_challenge_ack_limit = 1000;\n \n-int sysctl_tcp_rfc1337 __read_mostly;\n int sysctl_tcp_max_orphans __read_mostly = NR_FILE;\n int sysctl_tcp_frto __read_mostly = 2;\n int sysctl_tcp_min_rtt_wlen __read_mostly = 300;\ndiff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c\nindex a952357054f4ddfbb98746ebcf323d1c45f7e951..2abaa4c1fe0108f2645d8e783ae6b48e87a82fb3 100644\n--- a/net/ipv4/tcp_minisocks.c\n+++ b/net/ipv4/tcp_minisocks.c\n@@ -180,7 +180,7 @@ tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb,\n \t\t\t * Oh well... nobody has a sufficient solution to this\n \t\t\t * protocol bug yet.\n \t\t\t */\n-\t\t\tif (sysctl_tcp_rfc1337 == 0) {\n+\t\t\tif (twsk_net(tw)->ipv4.sysctl_tcp_rfc1337 == 0) {\n kill:\n \t\t\t\tinet_twsk_deschedule_put(tw);\n \t\t\t\treturn TCP_TW_SUCCESS;\n","prefixes":["net-next","07/15"]}