{"id":830993,"url":"http://patchwork.ozlabs.org/api/1.2/patches/830993/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171026233526.6155-16-edumazet@google.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171026233526.6155-16-edumazet@google.com>","list_archive_url":null,"date":"2017-10-26T23:35:26","name":"[net-next,15/15] tcp: Namespace-ify sysctl_tcp_frto","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"0d347fdef1730646644f8b3cf19424500b9fd531","submitter":{"id":13357,"url":"http://patchwork.ozlabs.org/api/1.2/people/13357/?format=json","name":"Eric Dumazet","email":"edumazet@google.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171026233526.6155-16-edumazet@google.com/mbox/","series":[{"id":10461,"url":"http://patchwork.ozlabs.org/api/1.2/series/10461/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=10461","date":"2017-10-26T23:35:11","name":"tcp: move 14 sysctls to namespaces","version":1,"mbox":"http://patchwork.ozlabs.org/series/10461/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/830993/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/830993/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"C8rkH7XZ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNNgQ2M62z9sxR\n\tfor ;\n\tFri, 27 Oct 2017 10:36:18 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932497AbdJZXgQ (ORCPT );\n\tThu, 26 Oct 2017 19:36:16 -0400","from mail-pg0-f67.google.com ([74.125.83.67]:45654 \"EHLO\n\tmail-pg0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932442AbdJZXgI (ORCPT\n\t); Thu, 26 Oct 2017 19:36:08 -0400","by mail-pg0-f67.google.com with SMTP id b192so3900739pga.2\n\tfor ; Thu, 26 Oct 2017 16:36:08 -0700 (PDT)","from localhost ([2620:15c:2c4:201:c5be:583d:61a8:d070])\n\tby smtp.gmail.com with ESMTPSA id\n\to65sm9664623pga.71.2017.10.26.16.36.06\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tThu, 26 Oct 2017 16:36:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=8cGa+KXQZRGOkDapbpj9YAvt2LzG21FJ1oVH8rnMSU8=;\n\tb=C8rkH7XZOXorafQjscVxtpnjRDTB7a+Nb4DjIHHLdeoWPQUI+IYMcZAyXyoRDipwQJ\n\ttyewIZShRHXyN+nWICZv4CYJY7ROW7OUYSvGrtAld/k8eF5NFbPQjOdQEt6I8yLQT9wu\n\t1dI2S45Lc3YffxYrips+KVy4v0Lib9ykVEIKOfkFNoH5u7bUU+Glo6pNKbQT2cgpOQBg\n\tmF/h4z8uZ/frqXZmyX/3f5BauBPaknaGCOTEZOHM3QunMSlqJIh7nJuXEHb56zPO2lmO\n\t3hvs6x6ctFZxwS7gYRKQ/FyU1YmNmZaRz+AV9pQpuqAgVpiZEkx8kb7zUaRPNvYFxqNy\n\tPWDA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=8cGa+KXQZRGOkDapbpj9YAvt2LzG21FJ1oVH8rnMSU8=;\n\tb=D9663DI7twv46Zo1ajL6uwWL0ICCY26J/il+GbwAufUjg2bFPk+iik6rXAtoVchYOb\n\treZC91KTJQDQ+2SeIjV31qMoN0ZJC1vVuwD1DGdc/LCMW4YGPfyugXnKzYfVucNDVnHy\n\tQR6AibcXYxh5EHZilv8/TGPn57XHnKKKQJWpyFvNcuErAc8Xt9zSRa9s2KGw8T4x6BTo\n\tmuM36i5j9IReOMY00NmNBcjdBdxSZRgsNbR6lE/PzpJIVDebtvj/bIg1X5ZHhTFxoLCq\n\tabIedoA65ecN8DjMjemC6D7YbqNRkEIA7qPyv9C7dRu/JG+4Sxm7Q9mV43Eq+9yKs/mD\n\tVJkA==","X-Gm-Message-State":"AMCzsaVOyQ/DO6f5w9mbdfariWqtv/kgE4orwu+sBg+/0lAlSLgoUFWX\n\tKvnD3nj8RF6uUZ9fM8PNXh2Alg==","X-Google-Smtp-Source":"ABhQp+RepPHeDPt9sPeoyyTVsJUDOqLcSN0ZYud81Pf63chDPQo8DDVxgx7uSrZlVb9im7NYpJtiww==","X-Received":"by 10.84.253.144 with SMTP id a16mr5459845plm.177.1509060967591; \n\tThu, 26 Oct 2017 16:36:07 -0700 (PDT)","From":"Eric Dumazet ","To":"\"David S . Miller\" ","Cc":"netdev , Eric Dumazet ,\n\tEric Dumazet ","Subject":"[PATCH net-next 15/15] tcp: Namespace-ify sysctl_tcp_frto","Date":"Thu, 26 Oct 2017 16:35:26 -0700","Message-Id":"<20171026233526.6155-16-edumazet@google.com>","X-Mailer":"git-send-email 2.15.0.rc2.357.g7e34df9404-goog","In-Reply-To":"<20171026233526.6155-1-edumazet@google.com>","References":"<20171026233526.6155-1-edumazet@google.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Signed-off-by: Eric Dumazet \n---\n include/net/netns/ipv4.h | 1 +\n include/net/tcp.h | 1 -\n net/ipv4/sysctl_net_ipv4.c | 14 +++++++-------\n net/ipv4/tcp_input.c | 3 +--\n net/ipv4/tcp_ipv4.c | 1 +\n 5 files changed, 10 insertions(+), 10 deletions(-)","diff":"diff --git a/include/net/netns/ipv4.h b/include/net/netns/ipv4.h\nindex 9dbb07d4eff465428817831e55c6a4922b7208fb..f4622e28db3a1484553f51709b144ee769766a28 100644\n--- a/include/net/netns/ipv4.h\n+++ b/include/net/netns/ipv4.h\n@@ -141,6 +141,7 @@ struct netns_ipv4 {\n \tint sysctl_tcp_dsack;\n \tint sysctl_tcp_app_win;\n \tint sysctl_tcp_adv_win_scale;\n+\tint sysctl_tcp_frto;\n \tstruct inet_timewait_death_row tcp_death_row;\n \tint sysctl_max_syn_backlog;\n \tint sysctl_tcp_fastopen;\ndiff --git a/include/net/tcp.h b/include/net/tcp.h\nindex 2572b57682987dd5f3700ed47d63e7238946b9a8..19006a5d073c202995ba63199ab8cde814d6d869 100644\n--- a/include/net/tcp.h\n+++ b/include/net/tcp.h\n@@ -244,7 +244,6 @@ extern int sysctl_tcp_max_orphans;\n extern long sysctl_tcp_mem[3];\n extern int sysctl_tcp_wmem[3];\n extern int sysctl_tcp_rmem[3];\n-extern int sysctl_tcp_frto;\n extern int sysctl_tcp_nometrics_save;\n extern int sysctl_tcp_moderate_rcvbuf;\n extern int sysctl_tcp_tso_win_divisor;\ndiff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c\nindex a95123e1e7da706c88bf5553b7d8ef6c2653ab50..f1bcb9b7e082c6688fad12e15be9b872ebed8151 100644\n--- a/net/ipv4/sysctl_net_ipv4.c\n+++ b/net/ipv4/sysctl_net_ipv4.c\n@@ -437,13 +437,6 @@ static struct ctl_table ipv4_table[] = {\n \t\t.proc_handler\t= proc_dointvec_minmax,\n \t\t.extra1\t\t= &one,\n \t},\n-\t{\n-\t\t.procname\t= \"tcp_frto\",\n-\t\t.data\t\t= &sysctl_tcp_frto,\n-\t\t.maxlen\t\t= sizeof(int),\n-\t\t.mode\t\t= 0644,\n-\t\t.proc_handler\t= proc_dointvec\n-\t},\n \t{\n \t\t.procname\t= \"tcp_min_rtt_wlen\",\n \t\t.data\t\t= &sysctl_tcp_min_rtt_wlen,\n@@ -1145,6 +1138,13 @@ static struct ctl_table ipv4_net_table[] = {\n \t\t.extra1\t\t= &tcp_adv_win_scale_min,\n \t\t.extra2\t\t= &tcp_adv_win_scale_max,\n \t},\n+\t{\n+\t\t.procname\t= \"tcp_frto\",\n+\t\t.data\t\t= &init_net.ipv4.sysctl_tcp_frto,\n+\t\t.maxlen\t\t= sizeof(int),\n+\t\t.mode\t\t= 0644,\n+\t\t.proc_handler\t= proc_dointvec\n+\t},\n \t{ }\n };\n \ndiff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c\nindex d01f390da23dcd4100271b150bd8bc143f7328cf..24950ea3094288cad8d9cd9eb0e0698d6f50e989 100644\n--- a/net/ipv4/tcp_input.c\n+++ b/net/ipv4/tcp_input.c\n@@ -81,7 +81,6 @@\n int sysctl_tcp_challenge_ack_limit = 1000;\n \n int sysctl_tcp_max_orphans __read_mostly = NR_FILE;\n-int sysctl_tcp_frto __read_mostly = 2;\n int sysctl_tcp_min_rtt_wlen __read_mostly = 300;\n int sysctl_tcp_moderate_rcvbuf __read_mostly = 1;\n int sysctl_tcp_invalid_ratelimit __read_mostly = HZ/2;\n@@ -2024,7 +2023,7 @@ void tcp_enter_loss(struct sock *sk)\n \t * falsely raise the receive window, which results in repeated\n \t * timeouts and stop-and-go behavior.\n \t */\n-\ttp->frto = sysctl_tcp_frto &&\n+\ttp->frto = net->ipv4.sysctl_tcp_frto &&\n \t\t (new_recovery || icsk->icsk_retransmits) &&\n \t\t !inet_csk(sk)->icsk_mtup.probe_size;\n }\ndiff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c\nindex 1fe30fb99308b3e3fd07509b509b0e3727cc5d44..49757c75821111c6d2cf413415be2c1b58482659 100644\n--- a/net/ipv4/tcp_ipv4.c\n+++ b/net/ipv4/tcp_ipv4.c\n@@ -2492,6 +2492,7 @@ static int __net_init tcp_sk_init(struct net *net)\n \tnet->ipv4.sysctl_tcp_dsack = 1;\n \tnet->ipv4.sysctl_tcp_app_win = 31;\n \tnet->ipv4.sysctl_tcp_adv_win_scale = 1;\n+\tnet->ipv4.sysctl_tcp_frto = 2;\n \n \tnet->ipv4.sysctl_tcp_fastopen = TFO_CLIENT_ENABLE;\n \tspin_lock_init(&net->ipv4.tcp_fastopen_ctx_lock);\n","prefixes":["net-next","15/15"]}