{"id":830986,"url":"http://patchwork.ozlabs.org/api/1.2/patches/830986/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171026233526.6155-7-edumazet@google.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171026233526.6155-7-edumazet@google.com>","list_archive_url":null,"date":"2017-10-26T23:35:17","name":"[net-next,06/15] tcp: Namespace-ify sysctl_tcp_stdurg","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"97907cc3db629ef6bb2eee7d02642b7babf114e7","submitter":{"id":13357,"url":"http://patchwork.ozlabs.org/api/1.2/people/13357/?format=json","name":"Eric Dumazet","email":"edumazet@google.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171026233526.6155-7-edumazet@google.com/mbox/","series":[{"id":10461,"url":"http://patchwork.ozlabs.org/api/1.2/series/10461/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=10461","date":"2017-10-26T23:35:11","name":"tcp: move 14 sysctls to namespaces","version":1,"mbox":"http://patchwork.ozlabs.org/series/10461/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/830986/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/830986/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"X25Bwbai\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNNg06rKdz9sxR\n\tfor ;\n\tFri, 27 Oct 2017 10:35:56 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932450AbdJZXfx (ORCPT );\n\tThu, 26 Oct 2017 19:35:53 -0400","from mail-pg0-f68.google.com ([74.125.83.68]:51786 \"EHLO\n\tmail-pg0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932396AbdJZXfr (ORCPT\n\t); Thu, 26 Oct 2017 19:35:47 -0400","by mail-pg0-f68.google.com with SMTP id p9so3884973pgc.8\n\tfor ; Thu, 26 Oct 2017 16:35:47 -0700 (PDT)","from localhost ([2620:15c:2c4:201:c5be:583d:61a8:d070])\n\tby smtp.gmail.com with ESMTPSA id\n\tm10sm10649236pgs.77.2017.10.26.16.35.45\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tThu, 26 Oct 2017 16:35:45 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=qWBQF1lLYBm22ehhFsvgskbtM5UYGwvGr4vfOmpXGzc=;\n\tb=X25Bwbai5M7M11+nCF5PYFkxoXzof4zKAFZrx1Tz42NKP9StkT9nCoO5Z5OQ5MVSdS\n\tdoLe0abXMB+l1p+Sqe0gs2RXo2eXEkbgrl4dVKsP7rdgWOKmn3rn+2J6Pg8sSz5elJgd\n\th4L2bV1RonHFMC4WVNSQWdtx5vmhVRSQGV5bKXe2vYLl8jhj46zzXuk856clRN2Ze7I6\n\tD39mLXYc8dtQ/7jrNAAdPsERxFgHGRQ5Q5JkGeYurJZ03p5VP7Estu2owROSDthPD3pv\n\tO8qcDeoBOmpNBkiOfN26JaTANlNKVozov5CJyvdXikzOlBgg0cgaV42kxl6xjK4coPoU\n\tWihw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=qWBQF1lLYBm22ehhFsvgskbtM5UYGwvGr4vfOmpXGzc=;\n\tb=rElkfc0Ra4XIiQdaclAw5qdSjxpWJs8k+V1o8Aa9NxcoAy50Al2chYPElCwXmB+jer\n\t+V1cv4UUnbvVZxrZjulqv2woAxozHYIyWgq3QKwdaoFutqrGd7rHPWW4SuAvZy70iOyr\n\tfZ5DvPsDbiibNy0YlaeSHWyBZZ49WvpQADl/tI+NpV+EJoLj9eN74RAx2ZNDooPDNv42\n\tug8Cu5QHKj3RnNhUAnsW8s1yBWAfFSl5X+72s/q2KmWjjNlB78Y1sXlJx7cFfzii7q52\n\tbop6xr/oGIO/OAW71bMJ7e8pWTh/X0jxXBdwhBUqOKnA2D3LhTKuBIFNrM1SaR2FIAIJ\n\tuPRg==","X-Gm-Message-State":"AMCzsaVHzueK8rAqrD2iJGrgaP3I2GSlMc9wYc0h1G3zEw9Es/q5dVyE\n\tL37MIB9ZtEbpvmTTrd6RWPqYgw==","X-Google-Smtp-Source":"ABhQp+T3fYkS/wbj/atJ3CWdq6nFiNsk3HWMLAHEM0GTI1z21rU2pcJ8QRhdDgS0g167v7zsdOBAiw==","X-Received":"by 10.98.87.74 with SMTP id l71mr6935515pfb.204.1509060946403;\n\tThu, 26 Oct 2017 16:35:46 -0700 (PDT)","From":"Eric Dumazet ","To":"\"David S . Miller\" ","Cc":"netdev , Eric Dumazet ,\n\tEric Dumazet ","Subject":"[PATCH net-next 06/15] tcp: Namespace-ify sysctl_tcp_stdurg","Date":"Thu, 26 Oct 2017 16:35:17 -0700","Message-Id":"<20171026233526.6155-7-edumazet@google.com>","X-Mailer":"git-send-email 2.15.0.rc2.357.g7e34df9404-goog","In-Reply-To":"<20171026233526.6155-1-edumazet@google.com>","References":"<20171026233526.6155-1-edumazet@google.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Signed-off-by: Eric Dumazet \n---\n include/net/netns/ipv4.h | 1 +\n include/net/tcp.h | 1 -\n net/ipv4/sysctl_net_ipv4.c | 14 +++++++-------\n net/ipv4/tcp_input.c | 3 +--\n 4 files changed, 9 insertions(+), 10 deletions(-)","diff":"diff --git a/include/net/netns/ipv4.h b/include/net/netns/ipv4.h\nindex b28c172b10e497f235b51aae0fc2d3bbf7cc51f3..ffa2cf3dc747ca9443df3927dc7928c18357f872 100644\n--- a/include/net/netns/ipv4.h\n+++ b/include/net/netns/ipv4.h\n@@ -133,6 +133,7 @@ struct netns_ipv4 {\n \tint sysctl_tcp_thin_linear_timeouts;\n \tint sysctl_tcp_slow_start_after_idle;\n \tint sysctl_tcp_retrans_collapse;\n+\tint sysctl_tcp_stdurg;\n \tstruct inet_timewait_death_row tcp_death_row;\n \tint sysctl_max_syn_backlog;\n \tint sysctl_tcp_fastopen;\ndiff --git a/include/net/tcp.h b/include/net/tcp.h\nindex 085848e4de38058bb09f025387c713ade32b263e..0cf9de8506916c67369ce78833207ba648f34a10 100644\n--- a/include/net/tcp.h\n+++ b/include/net/tcp.h\n@@ -240,7 +240,6 @@ void tcp_time_wait(struct sock *sk, int state, int timeo);\n \n \n /* sysctl variables for tcp */\n-extern int sysctl_tcp_stdurg;\n extern int sysctl_tcp_rfc1337;\n extern int sysctl_tcp_abort_on_overflow;\n extern int sysctl_tcp_max_orphans;\ndiff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c\nindex 533b92ad39dd0cada542028fe2f276d9eebcd2c8..a34bb75815c15afc077ba7ff36939b5abc9229f6 100644\n--- a/net/ipv4/sysctl_net_ipv4.c\n+++ b/net/ipv4/sysctl_net_ipv4.c\n@@ -400,13 +400,6 @@ static struct ctl_table ipv4_table[] = {\n \t\t.mode\t\t= 0644,\n \t\t.proc_handler\t= proc_dointvec\n \t},\n-\t{\n-\t\t.procname\t= \"tcp_stdurg\",\n-\t\t.data\t\t= &sysctl_tcp_stdurg,\n-\t\t.maxlen\t\t= sizeof(int),\n-\t\t.mode\t\t= 0644,\n-\t\t.proc_handler\t= proc_dointvec\n-\t},\n \t{\n \t\t.procname\t= \"tcp_rfc1337\",\n \t\t.data\t\t= &sysctl_tcp_rfc1337,\n@@ -1145,6 +1138,13 @@ static struct ctl_table ipv4_net_table[] = {\n \t\t.mode\t\t= 0644,\n \t\t.proc_handler\t= proc_dointvec\n \t},\n+\t{\n+\t\t.procname\t= \"tcp_stdurg\",\n+\t\t.data\t\t= &init_net.ipv4.sysctl_tcp_stdurg,\n+\t\t.maxlen\t\t= sizeof(int),\n+\t\t.mode\t\t= 0644,\n+\t\t.proc_handler\t= proc_dointvec\n+\t},\n \t{ }\n };\n \ndiff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c\nindex 2cc56fd57b751dd6b457c15067aa9309683a04a8..6c3655b538f6b2315af7dc611acc574f7489bde6 100644\n--- a/net/ipv4/tcp_input.c\n+++ b/net/ipv4/tcp_input.c\n@@ -87,7 +87,6 @@ EXPORT_SYMBOL(sysctl_tcp_adv_win_scale);\n /* rfc5961 challenge ack rate limiting */\n int sysctl_tcp_challenge_ack_limit = 1000;\n \n-int sysctl_tcp_stdurg __read_mostly;\n int sysctl_tcp_rfc1337 __read_mostly;\n int sysctl_tcp_max_orphans __read_mostly = NR_FILE;\n int sysctl_tcp_frto __read_mostly = 2;\n@@ -5103,7 +5102,7 @@ static void tcp_check_urg(struct sock *sk, const struct tcphdr *th)\n \tstruct tcp_sock *tp = tcp_sk(sk);\n \tu32 ptr = ntohs(th->urg_ptr);\n \n-\tif (ptr && !sysctl_tcp_stdurg)\n+\tif (ptr && !sock_net(sk)->ipv4.sysctl_tcp_stdurg)\n \t\tptr--;\n \tptr += ntohl(th->seq);\n \n","prefixes":["net-next","06/15"]}