{"id":830233,"url":"http://patchwork.ozlabs.org/api/1.2/patches/830233/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171025105406.GA146659@beast/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171025105406.GA146659@beast>","list_archive_url":null,"date":"2017-10-25T10:54:06","name":"drivers/net: arcnet: Convert timers to use timer_setup()","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"f3b08d0af36c5181921b169ebeee8693cbaa2e2a","submitter":{"id":10641,"url":"http://patchwork.ozlabs.org/api/1.2/people/10641/?format=json","name":"Kees Cook","email":"keescook@chromium.org"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171025105406.GA146659@beast/mbox/","series":[{"id":10142,"url":"http://patchwork.ozlabs.org/api/1.2/series/10142/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=10142","date":"2017-10-25T10:54:06","name":"drivers/net: arcnet: Convert timers to use timer_setup()","version":1,"mbox":"http://patchwork.ozlabs.org/series/10142/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/830233/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/830233/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"l66h/u1j\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yMRps3lgnz9sPm\n\tfor ;\n\tWed, 25 Oct 2017 21:54:29 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932623AbdJYKyP (ORCPT );\n\tWed, 25 Oct 2017 06:54:15 -0400","from mail-pg0-f65.google.com ([74.125.83.65]:43246 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932422AbdJYKyI (ORCPT\n\t); Wed, 25 Oct 2017 06:54:08 -0400","by mail-pg0-f65.google.com with SMTP id s75so16999889pgs.0\n\tfor ; Wed, 25 Oct 2017 03:54:08 -0700 (PDT)","from www.outflux.net\n\t(173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133])\n\tby smtp.gmail.com with ESMTPSA id\n\tc9sm5041134pfj.76.2017.10.25.03.54.06\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 25 Oct 2017 03:54:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google;\n\th=date:from:to:cc:subject:message-id:mime-version:content-disposition;\n\tbh=G9rMCjkkpl8eHPgqpjUqVD3ca3IBGbWxKILziKHwY/I=;\n\tb=l66h/u1jhp1xgOWbfDjEGuNBInIc3obWnv4XrFlawREn77KZe/NBa1O/B/JNkxU0BY\n\taaFHlsPCIsA7UCbdyciKiFHNi3ea08QO3n9mP+wtjF2V4IpQ/hWgAyhnt8AsI2d9Irr7\n\tX84WuWktnJauV8HGI6h+PIzAgxdhRGACcj7DM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version\n\t:content-disposition;\n\tbh=G9rMCjkkpl8eHPgqpjUqVD3ca3IBGbWxKILziKHwY/I=;\n\tb=BXyvlIty5IzgDh/7yZhgoRRXXRjj8gM0PbF810vs0nCw3tmm5Dc17at+SI6z2ByeCa\n\t/AM/LI3rBErnjgi4F+4+rlrGoT2wV8pJAwjUXWiLSUJPmYBuJscSQ9ymK5TACbKt0SRQ\n\tOoMoffYCXEoys56Oq01E/gaFYe+XELl5vsZhUxdytnegFc08RIS9lYGmtRjQepEddcMl\n\t2WJmNo/Mvf2YpdAUVxk2nISOWF90k3Qbsnuu7uyKpWAZ67qtumn+CavNVBP+gXfiseiM\n\tEBQUysOE73G4A5jGUkPAYbzg5ev23BghLTj5qSemqaTIGCvn5NvCUPVOaPg49plsNk0Q\n\tO6+Q==","X-Gm-Message-State":"AMCzsaU6/g4HwPkWUvv0nNPzN1H/1RdPI8teg2u/mw+z+n2DVl7+ZUEE\n\tjRzQE0pPxxZYZK6x/CSCWlT6sA==","X-Google-Smtp-Source":"ABhQp+SDIJbu8HM98VGM3akoDNWT7oi2XS3fyqCpKQEjwV/cTDA2Dzsl5qwzwczzfy6xSvnkQPdZYg==","X-Received":"by 10.99.154.66 with SMTP id e2mr1664189pgo.116.1508928847970;\n\tWed, 25 Oct 2017 03:54:07 -0700 (PDT)","Date":"Wed, 25 Oct 2017 03:54:06 -0700","From":"Kees Cook ","To":"\"David S. Miller\" ","Cc":"Michael Grzeschik ,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"[PATCH] drivers/net: arcnet: Convert timers to use timer_setup()","Message-ID":"<20171025105406.GA146659@beast>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"In preparation for unconditionally passing the struct timer_list pointer to\nall timer callbacks, switch to using the new timer_setup() and from_timer()\nto pass the timer pointer explicitly.\n\nCc: Michael Grzeschik \nCc: netdev@vger.kernel.org\nSigned-off-by: Kees Cook \n---\n drivers/net/arcnet/arcnet.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/net/arcnet/arcnet.c b/drivers/net/arcnet/arcnet.c\nindex 13236b2cdf13..8459115d9d4e 100644\n--- a/drivers/net/arcnet/arcnet.c\n+++ b/drivers/net/arcnet/arcnet.c\n@@ -382,9 +382,10 @@ static void arcdev_setup(struct net_device *dev)\n \tdev->flags = IFF_BROADCAST;\n }\n \n-static void arcnet_timer(unsigned long data)\n+static void arcnet_timer(struct timer_list *t)\n {\n-\tstruct net_device *dev = (struct net_device *)data;\n+\tstruct arcnet_local *lp = from_timer(lp, t, timer);\n+\tstruct net_device *dev = lp->dev;\n \n \tif (!netif_carrier_ok(dev)) {\n \t\tnetif_carrier_on(dev);\n@@ -450,7 +451,7 @@ struct net_device *alloc_arcdev(const char *name)\n \n \t\tlp->dev = dev;\n \t\tspin_lock_init(&lp->lock);\n-\t\tsetup_timer(&lp->timer, arcnet_timer, (unsigned long)dev);\n+\t\ttimer_setup(&lp->timer, arcnet_timer, 0);\n \t}\n \n \treturn dev;\n","prefixes":[]}