{"id":830227,"url":"http://patchwork.ozlabs.org/api/1.2/patches/830227/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171025105158.GA146575@beast/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171025105158.GA146575@beast>","list_archive_url":null,"date":"2017-10-25T10:51:58","name":"drivers/net: nuvoton: Convert timers to use timer_setup()","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"e07c7866db1bcb9648f1c0eff06f8304a4e82d11","submitter":{"id":10641,"url":"http://patchwork.ozlabs.org/api/1.2/people/10641/?format=json","name":"Kees Cook","email":"keescook@chromium.org"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171025105158.GA146575@beast/mbox/","series":[{"id":10136,"url":"http://patchwork.ozlabs.org/api/1.2/series/10136/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=10136","date":"2017-10-25T10:51:58","name":"drivers/net: nuvoton: Convert timers to use timer_setup()","version":1,"mbox":"http://patchwork.ozlabs.org/series/10136/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/830227/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/830227/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"WTG4dFwo\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yMRmJ2Dmfz9sNx\n\tfor ;\n\tWed, 25 Oct 2017 21:52:16 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932606AbdJYKwF (ORCPT );\n\tWed, 25 Oct 2017 06:52:05 -0400","from mail-pg0-f65.google.com ([74.125.83.65]:56218 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932422AbdJYKwB (ORCPT\n\t); Wed, 25 Oct 2017 06:52:01 -0400","by mail-pg0-f65.google.com with SMTP id 15so12319872pgc.12\n\tfor ; Wed, 25 Oct 2017 03:52:00 -0700 (PDT)","from www.outflux.net\n\t(173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133])\n\tby smtp.gmail.com with ESMTPSA id\n\tt78sm3794588pgb.93.2017.10.25.03.51.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 25 Oct 2017 03:51:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google;\n\th=date:from:to:cc:subject:message-id:mime-version:content-disposition;\n\tbh=mzyJYKpioZw2bzNq5RFLp1u6Xvr8VRR9Dgthh5r5hmk=;\n\tb=WTG4dFwo/2L5P0XnevVUVZmHAaKlBQMvFRZgKuavG5jtfNcbNDtquey+tnrMPstdh9\n\t2QE5QKq+14DM6xdJ6sLiGoLg7QutV57b24usL0I6r4cS7qgC0EXleGWnKaXurkIsNBF8\n\tcX2xPBHnDTtSTrZrvkfBaQdUhSk9HHw3Ec48I=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version\n\t:content-disposition;\n\tbh=mzyJYKpioZw2bzNq5RFLp1u6Xvr8VRR9Dgthh5r5hmk=;\n\tb=rGAZ6z3LGEFgyo+noDTx2ziHmjJ3v3IBJciG4JdHQnY3K2QvZxqzG/TH+JBvyBNFM5\n\txmzb44JDoZbw9KY7AE6/tdSYcgymC2MX2nIkcXif4DaArBuoxVxbP5kke25zTOWaSuf3\n\tfBMrTYtYnUHJ0IZbdvzMjArT3RBhdRV+NzO+kP7DazmlViTWShnfQzG76i4K8d9oD2LA\n\tGgWkxSGh1O0FHTlQD6iGLDR8rytVLQ0CCRUORy+2DAIQ0foeRecrdLWtvRoTDHL/N+tf\n\tQIzPJAFyg2u/eHNTxRUHkDT3Pstc5ws7zMwaihgOCENL4gu8tKuJrtpOhlsJMaPafv+r\n\tZxhg==","X-Gm-Message-State":"AMCzsaX0sYwyzGUDGvB9ZvBNe4IdOj6BN6wShKJXcqQjDjp3TAnmTuqI\n\tBzoliqAMkixwfRVrA2yFAWZ8/g==","X-Google-Smtp-Source":"ABhQp+SpHmfdzj3rnFeKnCt1KPGPauWX+2f3V0rJWBCzq0Mr8sTUuK4MiOgZ+jj9nJiNWnc5ufx4lA==","X-Received":"by 10.98.211.220 with SMTP id z89mr1790353pfk.99.1508928720525; \n\tWed, 25 Oct 2017 03:52:00 -0700 (PDT)","Date":"Wed, 25 Oct 2017 03:51:58 -0700","From":"Kees Cook ","To":"\"David S. Miller\" ","Cc":"Wan ZongShun ,\n\tlinux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH] drivers/net: nuvoton: Convert timers to use timer_setup()","Message-ID":"<20171025105158.GA146575@beast>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"In preparation for unconditionally passing the struct timer_list pointer to\nall timer callbacks, switch to using the new timer_setup() and from_timer()\nto pass the timer pointer explicitly.\n\nCc: Wan ZongShun \nCc: linux-arm-kernel@lists.infradead.org\nCc: netdev@vger.kernel.org\nSigned-off-by: Kees Cook \n---\n drivers/net/ethernet/nuvoton/w90p910_ether.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)","diff":"diff --git a/drivers/net/ethernet/nuvoton/w90p910_ether.c b/drivers/net/ethernet/nuvoton/w90p910_ether.c\nindex 4a67c55aa9f1..052b3d2c07a1 100644\n--- a/drivers/net/ethernet/nuvoton/w90p910_ether.c\n+++ b/drivers/net/ethernet/nuvoton/w90p910_ether.c\n@@ -253,10 +253,10 @@ static void update_linkspeed(struct net_device *dev)\n \tnetif_carrier_on(dev);\n }\n \n-static void w90p910_check_link(unsigned long dev_id)\n+static void w90p910_check_link(struct timer_list *t)\n {\n-\tstruct net_device *dev = (struct net_device *) dev_id;\n-\tstruct w90p910_ether *ether = netdev_priv(dev);\n+\tstruct w90p910_ether *ether = from_timer(ether, t, check_timer);\n+\tstruct net_device *dev = ether->mii.dev;\n \n \tupdate_linkspeed(dev);\n \tmod_timer(ðer->check_timer, jiffies + msecs_to_jiffies(1000));\n@@ -957,8 +957,7 @@ static int w90p910_ether_setup(struct net_device *dev)\n \tether->mii.mdio_read = w90p910_mdio_read;\n \tether->mii.mdio_write = w90p910_mdio_write;\n \n-\tsetup_timer(ðer->check_timer, w90p910_check_link,\n-\t\t\t\t\t\t(unsigned long)dev);\n+\ttimer_setup(ðer->check_timer, w90p910_check_link, 0);\n \n \treturn 0;\n }\n","prefixes":[]}