{"id":830224,"url":"http://patchwork.ozlabs.org/api/1.2/patches/830224/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20171025105120.GA146533@beast/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171025105120.GA146533@beast>","list_archive_url":null,"date":"2017-10-25T10:51:20","name":"drivers/net: hamradio/yam: Convert timers to use timer_setup()","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"fed5fc892fa79060db5c4af20ae858f0b6444681","submitter":{"id":10641,"url":"http://patchwork.ozlabs.org/api/1.2/people/10641/?format=json","name":"Kees Cook","email":"keescook@chromium.org"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20171025105120.GA146533@beast/mbox/","series":[{"id":10133,"url":"http://patchwork.ozlabs.org/api/1.2/series/10133/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=10133","date":"2017-10-25T10:51:20","name":"drivers/net: hamradio/yam: Convert timers to use timer_setup()","version":1,"mbox":"http://patchwork.ozlabs.org/series/10133/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/830224/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/830224/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"br2Cx8bS\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yMRlT0mSrz9sNx\n\tfor ;\n\tWed, 25 Oct 2017 21:51:33 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932553AbdJYKvb (ORCPT );\n\tWed, 25 Oct 2017 06:51:31 -0400","from mail-pf0-f196.google.com ([209.85.192.196]:44741 \"EHLO\n\tmail-pf0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932441AbdJYKvX (ORCPT\n\t); Wed, 25 Oct 2017 06:51:23 -0400","by mail-pf0-f196.google.com with SMTP id x7so21952964pfa.1\n\tfor ; Wed, 25 Oct 2017 03:51:23 -0700 (PDT)","from www.outflux.net\n\t(173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133])\n\tby smtp.gmail.com with ESMTPSA id\n\tu9sm6261289pfa.40.2017.10.25.03.51.21\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 25 Oct 2017 03:51:21 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google;\n\th=date:from:to:cc:subject:message-id:mime-version:content-disposition;\n\tbh=2b/cN40edw7iFzfR/F/luZQqr9fLYdxfnVO6teNQilM=;\n\tb=br2Cx8bSqoQiqsM/SbDTCUgYSR44NAgPF33iqHQ0JTnuRSmmLBnTL7To9SUs60xMbu\n\tfRsvZHPaidVh1g0REQSbaUr1sDSNv1M8aJLxsyNmEGcd9yAvjw1POqfYa5MwEWbiLU+3\n\tpLWUYoWKDSLrfabktnmEEI1invruO20IZin8g=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version\n\t:content-disposition;\n\tbh=2b/cN40edw7iFzfR/F/luZQqr9fLYdxfnVO6teNQilM=;\n\tb=IZj+jRTRPWCfmwZMLIRHGo6kFxVHlGiytkpihhBekjdp42HYiKr0ZRk6UA8fef+TBD\n\tahV4m/m0nm2N7noLGZbDaWSin1VbLHJjCE0pME74zIQLVGIpRn+k3YXMNmu1MgeiZUJN\n\tRCeUyXK3+IUIC5NZ/mbvctJuswrs4QTKYBVo+LpAtL3ZQPoHmeyBdfa2BzNulh+eFcNm\n\tdCm4zNTTu2xN+khmo7Srj1KsvpRI2rvSAS0ZoLo9BWNtQfiQK7ySVChGQZPfoUpwT4Sr\n\tPez663lH/0VaWY2cqYEW9YBsp/n9jG76ARh3r2cUd/3Kl6wkEj59YHSYw+qYo0syLgW/\n\tct1Q==","X-Gm-Message-State":"AMCzsaWEBLpIKvCXr131rH7JWCeiHyVaF2gHACF/SjgKOjyILdE08oVf\n\tmvULhvXqw1mKKoKUYg3Mrc7swU+KmNg=","X-Google-Smtp-Source":"ABhQp+Q8C82YdhxQTG78fpp6NQIgTiGmXzRazsJBT8p+zzkq1dIRVzQLQKstrhCVL3CyMx35Y5Qubg==","X-Received":"by 10.84.140.131 with SMTP id 3mr1414174plt.348.1508928682840;\n\tWed, 25 Oct 2017 03:51:22 -0700 (PDT)","Date":"Wed, 25 Oct 2017 03:51:20 -0700","From":"Kees Cook ","To":"\"David S. Miller\" ","Cc":"Jean-Paul Roubelat , linux-hams@vger.kernel.org,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"[PATCH] drivers/net: hamradio/yam: Convert timers to use\n\ttimer_setup()","Message-ID":"<20171025105120.GA146533@beast>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"In preparation for unconditionally passing the struct timer_list pointer to\nall timer callbacks, switch to using the new timer_setup() and from_timer()\nto pass the timer pointer explicitly. Initialization was entirely missing.\n\nCc: Jean-Paul Roubelat \nCc: linux-hams@vger.kernel.org\nCc: netdev@vger.kernel.org\nSigned-off-by: Kees Cook \n---\n drivers/net/hamradio/yam.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c\nindex 7a7c5224a336..b88c5cc00a63 100644\n--- a/drivers/net/hamradio/yam.c\n+++ b/drivers/net/hamradio/yam.c\n@@ -647,7 +647,7 @@ static void yam_arbitrate(struct net_device *dev)\n \tyam_start_tx(dev, yp);\n }\n \n-static void yam_dotimer(unsigned long dummy)\n+static void yam_dotimer(struct timer_list *unused)\n {\n \tint i;\n \n@@ -1164,7 +1164,7 @@ static int __init yam_init_driver(void)\n \n \t}\n \n-\tyam_timer.function = yam_dotimer;\n+\ttimer_setup(&yam_timer, yam_dotimer, 0);\n \tyam_timer.expires = jiffies + HZ / 100;\n \tadd_timer(&yam_timer);\n \n","prefixes":[]}