{"id":829953,"url":"http://patchwork.ozlabs.org/api/1.2/patches/829953/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20171024152415.22864-7-jack@suse.cz/","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/1.2/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171024152415.22864-7-jack@suse.cz>","list_archive_url":null,"date":"2017-10-24T15:24:03","name":"[06/17] dax: Create local variable for vmf->flags & FAULT_FLAG_WRITE test","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"888829ec297bb61f7742bb2e2cad2c9753ed1b2c","submitter":{"id":363,"url":"http://patchwork.ozlabs.org/api/1.2/people/363/?format=json","name":"Jan Kara","email":"jack@suse.cz"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20171024152415.22864-7-jack@suse.cz/mbox/","series":[{"id":10008,"url":"http://patchwork.ozlabs.org/api/1.2/series/10008/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/list/?series=10008","date":"2017-10-24T15:23:57","name":"dax, ext4, xfs: Synchronous page faults","version":5,"mbox":"http://patchwork.ozlabs.org/series/10008/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/829953/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/829953/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yLxvZ39Xqz9t3p\n\tfor ;\n\tWed, 25 Oct 2017 02:26:50 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932537AbdJXP0s (ORCPT );\n\tTue, 24 Oct 2017 11:26:48 -0400","from mx2.suse.de ([195.135.220.15]:36102 \"EHLO mx2.suse.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S932197AbdJXPZb (ORCPT );\n\tTue, 24 Oct 2017 11:25:31 -0400","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx2.suse.de (Postfix) with ESMTP id 10188AC6B;\n\tTue, 24 Oct 2017 15:25:28 +0000 (UTC)","by quack2.suse.cz (Postfix, from userid 1000)\n\tid 5CEC41E35C8; Tue, 24 Oct 2017 17:25:27 +0200 (CEST)"],"X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","From":"Jan Kara ","To":"Dan Williams ","Cc":"Ross Zwisler ,\n\tChristoph Hellwig ,\n\t, linux-nvdimm@lists.01.org,\n\t, ,\n\tlinux-api@vger.kernel.org, , Jan Kara ","Subject":"[PATCH 06/17] dax: Create local variable for vmf->flags &\n\tFAULT_FLAG_WRITE test","Date":"Tue, 24 Oct 2017 17:24:03 +0200","Message-Id":"<20171024152415.22864-7-jack@suse.cz>","X-Mailer":"git-send-email 2.12.3","In-Reply-To":"<20171024152415.22864-1-jack@suse.cz>","References":"<20171024152415.22864-1-jack@suse.cz>","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"},"content":"There are already two users and more are coming.\n\nReviewed-by: Christoph Hellwig \nReviewed-by: Ross Zwisler \nSigned-off-by: Jan Kara \n---\n fs/dax.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/fs/dax.c b/fs/dax.c\nindex c09465884bbe..5ea71381dba0 100644\n--- a/fs/dax.c\n+++ b/fs/dax.c\n@@ -1116,6 +1116,7 @@ static int dax_iomap_pte_fault(struct vm_fault *vmf,\n \tstruct iomap iomap = { 0 };\n \tunsigned flags = IOMAP_FAULT;\n \tint error, major = 0;\n+\tbool write = vmf->flags & FAULT_FLAG_WRITE;\n \tint vmf_ret = 0;\n \tvoid *entry;\n \n@@ -1130,7 +1131,7 @@ static int dax_iomap_pte_fault(struct vm_fault *vmf,\n \t\tgoto out;\n \t}\n \n-\tif ((vmf->flags & FAULT_FLAG_WRITE) && !vmf->cow_page)\n+\tif (write && !vmf->cow_page)\n \t\tflags |= IOMAP_WRITE;\n \n \tentry = grab_mapping_entry(mapping, vmf->pgoff, 0);\n@@ -1207,7 +1208,7 @@ static int dax_iomap_pte_fault(struct vm_fault *vmf,\n \t\tbreak;\n \tcase IOMAP_UNWRITTEN:\n \tcase IOMAP_HOLE:\n-\t\tif (!(vmf->flags & FAULT_FLAG_WRITE)) {\n+\t\tif (!write) {\n \t\t\tvmf_ret = dax_load_hole(mapping, entry, vmf);\n \t\t\tgoto finish_iomap;\n \t\t}\n","prefixes":["06/17"]}