{"id":816169,"url":"http://patchwork.ozlabs.org/api/1.2/patches/816169/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170920115813.63745-4-ubraun@linux.vnet.ibm.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170920115813.63745-4-ubraun@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-20T11:58:06","name":"[net-next,03/10] net/smc: take RCU read lock for routing cache lookup","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"6f1b942f0138aca6ea3313ad3fbcb705d520bfa6","submitter":{"id":2266,"url":"http://patchwork.ozlabs.org/api/1.2/people/2266/?format=json","name":"Ursula Braun","email":"ubraun@linux.vnet.ibm.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170920115813.63745-4-ubraun@linux.vnet.ibm.com/mbox/","series":[{"id":4092,"url":"http://patchwork.ozlabs.org/api/1.2/series/4092/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4092","date":"2017-09-20T11:58:04","name":"net/smc: updates 2017-09-20","version":1,"mbox":"http://patchwork.ozlabs.org/series/4092/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816169/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816169/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxyvt4Y3Yz9t2Q\n\tfor ;\n\tWed, 20 Sep 2017 21:59:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752001AbdITL7T (ORCPT );\n\tWed, 20 Sep 2017 07:59:19 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:33896 \"EHLO\n\tmx0a-001b2d01.pphosted.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1751768AbdITL62 (ORCPT\n\t); Wed, 20 Sep 2017 07:58:28 -0400","from pps.filterd (m0098414.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8KBsYn5028383\n\tfor ; Wed, 20 Sep 2017 07:58:27 -0400","from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d3q46b3nv-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 20 Sep 2017 07:58:27 -0400","from localhost\n\tby e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 20 Sep 2017 12:58:26 +0100","from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194)\n\tby e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tWed, 20 Sep 2017 12:58:23 +0100","from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com\n\t[9.149.105.59])\n\tby b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8KBwNeb21430444; Wed, 20 Sep 2017 11:58:23 GMT","from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 3F715A404D;\n\tWed, 20 Sep 2017 12:54:24 +0100 (BST)","from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id E5F65A4040;\n\tWed, 20 Sep 2017 12:54:23 +0100 (BST)","from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9])\n\tby d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS;\n\tWed, 20 Sep 2017 12:54:23 +0100 (BST)"],"From":"Ursula Braun ","To":"davem@davemloft.net","Cc":"netdev@vger.kernel.org, linux-rdma@vger.kernel.org,\n\tlinux-s390@vger.kernel.org, jwi@linux.vnet.ibm.com,\n\tschwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,\n\traspl@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com","Subject":"[PATCH net-next 03/10] net/smc: take RCU read lock for routing\n\tcache lookup","Date":"Wed, 20 Sep 2017 13:58:06 +0200","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170920115813.63745-1-ubraun@linux.vnet.ibm.com>","References":"<20170920115813.63745-1-ubraun@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17092011-0040-0000-0000-000003FBA385","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092011-0041-0000-0000-0000209CD9A9","Message-Id":"<20170920115813.63745-4-ubraun@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-20_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709200163","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"smc_netinfo_by_tcpsk() looks up the routing cache. Such a lookup requires\nprotection by an RCU read lock.\n\nSigned-off-by: Ursula Braun \n---\n net/smc/af_smc.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c\nindex 8c6d24b2995d..2e8d2dabac0c 100644\n--- a/net/smc/af_smc.c\n+++ b/net/smc/af_smc.c\n@@ -282,6 +282,7 @@ int smc_netinfo_by_tcpsk(struct socket *clcsock,\n \t\t\t __be32 *subnet, u8 *prefix_len)\n {\n \tstruct dst_entry *dst = sk_dst_get(clcsock->sk);\n+\tstruct in_device *in_dev;\n \tstruct sockaddr_in addr;\n \tint rc = -ENOENT;\n \tint len;\n@@ -298,14 +299,17 @@ int smc_netinfo_by_tcpsk(struct socket *clcsock,\n \t/* get address to which the internal TCP socket is bound */\n \tkernel_getsockname(clcsock, (struct sockaddr *)&addr, &len);\n \t/* analyze IPv4 specific data of net_device belonging to TCP socket */\n-\tfor_ifa(dst->dev->ip_ptr) {\n-\t\tif (ifa->ifa_address != addr.sin_addr.s_addr)\n+\trcu_read_lock();\n+\tin_dev = __in_dev_get_rcu(dst->dev);\n+\tfor_ifa(in_dev) {\n+\t\tif (!inet_ifa_match(addr.sin_addr.s_addr, ifa))\n \t\t\tcontinue;\n \t\t*prefix_len = inet_mask_len(ifa->ifa_mask);\n \t\t*subnet = ifa->ifa_address & ifa->ifa_mask;\n \t\trc = 0;\n \t\tbreak;\n-\t} endfor_ifa(dst->dev->ip_ptr);\n+\t} endfor_ifa(in_dev);\n+\trcu_read_unlock();\n \n out_rel:\n \tdst_release(dst);\n","prefixes":["net-next","03/10"]}