{"id":816164,"url":"http://patchwork.ozlabs.org/api/1.2/patches/816164/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170920115813.63745-11-ubraun@linux.vnet.ibm.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170920115813.63745-11-ubraun@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-20T11:58:13","name":"[net-next,10/10] net/smc: no close wait in case of process shut down","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"0277bb3f00d3f1ffe87165561d2b3841a05bec04","submitter":{"id":2266,"url":"http://patchwork.ozlabs.org/api/1.2/people/2266/?format=json","name":"Ursula Braun","email":"ubraun@linux.vnet.ibm.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170920115813.63745-11-ubraun@linux.vnet.ibm.com/mbox/","series":[{"id":4092,"url":"http://patchwork.ozlabs.org/api/1.2/series/4092/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4092","date":"2017-09-20T11:58:04","name":"net/smc: updates 2017-09-20","version":1,"mbox":"http://patchwork.ozlabs.org/series/4092/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816164/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816164/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxyvF05Qbz9t2Q\n\tfor ;\n\tWed, 20 Sep 2017 21:58:49 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751982AbdITL6q (ORCPT );\n\tWed, 20 Sep 2017 07:58:46 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:59792 \"EHLO\n\tmx0a-001b2d01.pphosted.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751974AbdITL6n (ORCPT\n\t); Wed, 20 Sep 2017 07:58:43 -0400","from pps.filterd (m0098394.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8KBvXP3090728\n\tfor ; Wed, 20 Sep 2017 07:58:43 -0400","from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d3p3gyhh6-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 20 Sep 2017 07:58:36 -0400","from localhost\n\tby e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 20 Sep 2017 12:58:34 +0100","from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198)\n\tby e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tWed, 20 Sep 2017 12:58:33 +0100","from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com\n\t[9.149.105.59])\n\tby b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8KBwW1m19988698; Wed, 20 Sep 2017 11:58:32 GMT","from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id B88F2A4055;\n\tWed, 20 Sep 2017 12:54:33 +0100 (BST)","from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 6D6E6A4040;\n\tWed, 20 Sep 2017 12:54:33 +0100 (BST)","from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9])\n\tby d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS;\n\tWed, 20 Sep 2017 12:54:33 +0100 (BST)"],"From":"Ursula Braun ","To":"davem@davemloft.net","Cc":"netdev@vger.kernel.org, linux-rdma@vger.kernel.org,\n\tlinux-s390@vger.kernel.org, jwi@linux.vnet.ibm.com,\n\tschwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,\n\traspl@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com","Subject":"[PATCH net-next 10/10] net/smc: no close wait in case of process\n\tshut down","Date":"Wed, 20 Sep 2017 13:58:13 +0200","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170920115813.63745-1-ubraun@linux.vnet.ibm.com>","References":"<20170920115813.63745-1-ubraun@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17092011-0008-0000-0000-00000498A4BC","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092011-0009-0000-0000-00001E29DADA","Message-Id":"<20170920115813.63745-11-ubraun@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-20_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709200163","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Usually socket closing is delayed if there is still data available in\nthe send buffer to be transmitted. If a process is killed, the delay\nshould be avoided.\n\nSigned-off-by: Ursula Braun \n---\n net/smc/smc_close.c | 15 ++++++++-------\n 1 file changed, 8 insertions(+), 7 deletions(-)","diff":"diff --git a/net/smc/smc_close.c b/net/smc/smc_close.c\nindex 5201bc103bd8..f0d16fb825f7 100644\n--- a/net/smc/smc_close.c\n+++ b/net/smc/smc_close.c\n@@ -174,15 +174,15 @@ int smc_close_active(struct smc_sock *smc)\n {\n \tstruct smc_cdc_conn_state_flags *txflags =\n \t\t&smc->conn.local_tx_ctrl.conn_state_flags;\n-\tlong timeout = SMC_MAX_STREAM_WAIT_TIMEOUT;\n \tstruct smc_connection *conn = &smc->conn;\n \tstruct sock *sk = &smc->sk;\n \tint old_state;\n+\tlong timeout;\n \tint rc = 0;\n \n-\tif (sock_flag(sk, SOCK_LINGER) &&\n-\t !(current->flags & PF_EXITING))\n-\t\ttimeout = sk->sk_lingertime;\n+\ttimeout = current->flags & PF_EXITING ?\n+\t\t 0 : sock_flag(sk, SOCK_LINGER) ?\n+\t\t sk->sk_lingertime : SMC_MAX_STREAM_WAIT_TIMEOUT;\n \n again:\n \told_state = sk->sk_state;\n@@ -413,13 +413,14 @@ void smc_close_sock_put_work(struct work_struct *work)\n int smc_close_shutdown_write(struct smc_sock *smc)\n {\n \tstruct smc_connection *conn = &smc->conn;\n-\tlong timeout = SMC_MAX_STREAM_WAIT_TIMEOUT;\n \tstruct sock *sk = &smc->sk;\n \tint old_state;\n+\tlong timeout;\n \tint rc = 0;\n \n-\tif (sock_flag(sk, SOCK_LINGER))\n-\t\ttimeout = sk->sk_lingertime;\n+\ttimeout = current->flags & PF_EXITING ?\n+\t\t 0 : sock_flag(sk, SOCK_LINGER) ?\n+\t\t sk->sk_lingertime : SMC_MAX_STREAM_WAIT_TIMEOUT;\n \n again:\n \told_state = sk->sk_state;\n","prefixes":["net-next","10/10"]}