{"id":815114,"url":"http://patchwork.ozlabs.org/api/1.2/patches/815114/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170918191822.65142-7-jwi@linux.vnet.ibm.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918191822.65142-7-jwi@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-18T19:18:19","name":"[net-next,6/9] s390/qeth: simplify L3 sysfs group management","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"276864d7d5c67d23658fab6a4e9296e0ad29a99b","submitter":{"id":71397,"url":"http://patchwork.ozlabs.org/api/1.2/people/71397/?format=json","name":"Julian Wiedmann","email":"jwi@linux.vnet.ibm.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170918191822.65142-7-jwi@linux.vnet.ibm.com/mbox/","series":[{"id":3715,"url":"http://patchwork.ozlabs.org/api/1.2/series/3715/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3715","date":"2017-09-18T19:18:13","name":"s390/qeth: updates 2017-09-18","version":1,"mbox":"http://patchwork.ozlabs.org/series/3715/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815114/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815114/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwwmh6VJwz9s7p\n\tfor ;\n\tTue, 19 Sep 2017 05:19:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751340AbdIRTTa (ORCPT );\n\tMon, 18 Sep 2017 15:19:30 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43940 \"EHLO\n\tmx0a-001b2d01.pphosted.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1750921AbdIRTT3 (ORCPT\n\t); Mon, 18 Sep 2017 15:19:29 -0400","from pps.filterd (m0098414.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8IJJJjZ024375\n\tfor ; Mon, 18 Sep 2017 15:19:28 -0400","from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d2ex14u9y-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 18 Sep 2017 15:19:28 -0400","from localhost\n\tby e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 18 Sep 2017 20:19:27 +0100","from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198)\n\tby e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tMon, 18 Sep 2017 20:19:25 +0100","from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com\n\t[9.149.105.232])\n\tby b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8IJJPLs7340172; Mon, 18 Sep 2017 19:19:25 GMT","from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 011EF52041;\n\tMon, 18 Sep 2017 19:14:26 +0100 (BST)","from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9])\n\tby d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id B8CDF5203F; \n\tMon, 18 Sep 2017 19:14:25 +0100 (BST)"],"From":"Julian Wiedmann ","To":"David Miller ","Cc":", ,\n\tMartin Schwidefsky ,\n\tHeiko Carstens ,\n\tStefan Raspl ,\n\tUrsula Braun ,\n\tJulian Wiedmann ","Subject":"[PATCH net-next 6/9] s390/qeth: simplify L3 sysfs group management","Date":"Mon, 18 Sep 2017 21:18:19 +0200","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170918191822.65142-1-jwi@linux.vnet.ibm.com>","References":"<20170918191822.65142-1-jwi@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17091819-0008-0000-0000-00000497DBEC","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091819-0009-0000-0000-00001E2909CA","Message-Id":"<20170918191822.65142-7-jwi@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-18_08:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709180272","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use the right helpers to create/remove all attribute groups in one go.\n\nSuggested-by: Hans Wippel \nSigned-off-by: Julian Wiedmann \nReviewed-by: Ursula Braun \n---\n drivers/s390/net/qeth_l3_sys.c | 45 +++++++++++-------------------------------\n 1 file changed, 12 insertions(+), 33 deletions(-)","diff":"diff --git a/drivers/s390/net/qeth_l3_sys.c b/drivers/s390/net/qeth_l3_sys.c\nindex e8bcc314cc5f..0ad0f7f4b23f 100644\n--- a/drivers/s390/net/qeth_l3_sys.c\n+++ b/drivers/s390/net/qeth_l3_sys.c\n@@ -1028,52 +1028,31 @@ static const struct attribute_group qeth_device_rxip_group = {\n \t.attrs = qeth_rxip_device_attrs,\n };\n \n+static const struct attribute_group *qeth_l3_only_attr_groups[] = {\n+\t&qeth_l3_device_attr_group,\n+\t&qeth_device_ipato_group,\n+\t&qeth_device_vipa_group,\n+\t&qeth_device_rxip_group,\n+\tNULL,\n+};\n+\n int qeth_l3_create_device_attributes(struct device *dev)\n {\n-\tint ret;\n-\n-\tret = sysfs_create_group(&dev->kobj, &qeth_l3_device_attr_group);\n-\tif (ret)\n-\t\treturn ret;\n-\n-\tret = sysfs_create_group(&dev->kobj, &qeth_device_ipato_group);\n-\tif (ret) {\n-\t\tsysfs_remove_group(&dev->kobj, &qeth_l3_device_attr_group);\n-\t\treturn ret;\n-\t}\n-\n-\tret = sysfs_create_group(&dev->kobj, &qeth_device_vipa_group);\n-\tif (ret) {\n-\t\tsysfs_remove_group(&dev->kobj, &qeth_l3_device_attr_group);\n-\t\tsysfs_remove_group(&dev->kobj, &qeth_device_ipato_group);\n-\t\treturn ret;\n-\t}\n-\n-\tret = sysfs_create_group(&dev->kobj, &qeth_device_rxip_group);\n-\tif (ret) {\n-\t\tsysfs_remove_group(&dev->kobj, &qeth_l3_device_attr_group);\n-\t\tsysfs_remove_group(&dev->kobj, &qeth_device_ipato_group);\n-\t\tsysfs_remove_group(&dev->kobj, &qeth_device_vipa_group);\n-\t\treturn ret;\n-\t}\n-\treturn 0;\n+\treturn sysfs_create_groups(&dev->kobj, qeth_l3_only_attr_groups);\n }\n \n void qeth_l3_remove_device_attributes(struct device *dev)\n {\n-\tsysfs_remove_group(&dev->kobj, &qeth_l3_device_attr_group);\n-\tsysfs_remove_group(&dev->kobj, &qeth_device_ipato_group);\n-\tsysfs_remove_group(&dev->kobj, &qeth_device_vipa_group);\n-\tsysfs_remove_group(&dev->kobj, &qeth_device_rxip_group);\n+\tsysfs_remove_groups(&dev->kobj, qeth_l3_only_attr_groups);\n }\n \n const struct attribute_group *qeth_l3_attr_groups[] = {\n \t&qeth_device_attr_group,\n \t&qeth_device_blkt_group,\n-\t/* l3 specific, see l3_{create,remove}_device_attributes(): */\n+\t/* l3 specific, see qeth_l3_only_attr_groups: */\n \t&qeth_l3_device_attr_group,\n \t&qeth_device_ipato_group,\n \t&qeth_device_vipa_group,\n \t&qeth_device_rxip_group,\n-NULL,\n+\tNULL,\n };\n","prefixes":["net-next","6/9"]}