{"id":815073,"url":"http://patchwork.ozlabs.org/api/1.2/patches/815073/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170918183043.8028-1-clabbe.montjoie@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918183043.8028-1-clabbe.montjoie@gmail.com>","list_archive_url":null,"date":"2017-09-18T18:30:43","name":"[v2] net: stmmac: dwmac-sun8i: Use reset exclusive","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"c8648ea07da3206d39ad9766df6ad2218e6c7096","submitter":{"id":64152,"url":"http://patchwork.ozlabs.org/api/1.2/people/64152/?format=json","name":"Corentin Labbe","email":"clabbe.montjoie@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170918183043.8028-1-clabbe.montjoie@gmail.com/mbox/","series":[{"id":3703,"url":"http://patchwork.ozlabs.org/api/1.2/series/3703/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3703","date":"2017-09-18T18:30:43","name":"[v2] net: stmmac: dwmac-sun8i: Use reset exclusive","version":2,"mbox":"http://patchwork.ozlabs.org/series/3703/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815073/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815073/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Z/yvWszU\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwvlH2Y9gz9s7v\n\tfor ;\n\tTue, 19 Sep 2017 04:33:15 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755609AbdIRSdD (ORCPT );\n\tMon, 18 Sep 2017 14:33:03 -0400","from mail-wm0-f67.google.com ([74.125.82.67]:33272 \"EHLO\n\tmail-wm0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753928AbdIRSdB (ORCPT\n\t); Mon, 18 Sep 2017 14:33:01 -0400","by mail-wm0-f67.google.com with SMTP id m127so1736216wmm.0;\n\tMon, 18 Sep 2017 11:33:00 -0700 (PDT)","from Red.local (LFbn-MAR-1-580-96.w90-118.abo.wanadoo.fr.\n\t[90.118.159.96]) by smtp.googlemail.com with ESMTPSA id\n\tv5sm7183996wmb.0.2017.09.18.11.32.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 18 Sep 2017 11:32:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=Vk9qsmQwPg0W7dP69KngWGL9NnjbTA2fncWis5TdAdg=;\n\tb=Z/yvWszUATwx2QueTZPmD7elife67mzsMAb78R0RuM68W61VId6LfXtQc3P/5OBTB1\n\t8jXgxcRcaxZ94DVKD2GNLLFI1szoCbS8LZQGPIDllGMcyZXQwZf169BpTo0yO21/J4cK\n\tPM6uOc+LgdHaDYkGvF69gIH7jfd3KmWNNBL5xnP8Mo6pkmafFDzfwancFb0n6kAbXuVh\n\tDYhizF230C+7/A7fOJlKxVBeRfHll0671YbxXVni4aMVOH8jAHIsqS+zDXPQPvLVSfR2\n\t3n0wF4wA1cIDfBSqYou5hMuVW/W+j9LYIOo8wkoAaTX7stxIMi14lci657RRjS//wjO+\n\tz9VQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=Vk9qsmQwPg0W7dP69KngWGL9NnjbTA2fncWis5TdAdg=;\n\tb=l6EnQBoT7rU/Ofva0oN3BlJJtsHKgXdX7hS9eYlusThNpcIu9hFyezWjA0DbbC7tb/\n\tdw0/eBWCoNi+Buvl4De50UZqhHvR9uje283FM8zSGpqsoPBbwNzKSYFs7uYE4QsKeDhM\n\t7++zJQRze6CYyQjtxHYCPUGOF/UCVR4tFz86ZcAlRZk8ZvKldbTeNoTscK3z3wbJbGB4\n\tllxUMXIzkQKNdIwTJmw68Qvd/QsLthxwdu8fOwNFQtclOL5OJGV4cyJZmiUGkptjeyza\n\tzSbDYD9tBuE1KgiBtJ/mJ9fpV03Otcd2ROR2HEAG1krR0eDH+/LFS+2BDlcp/0jrK1F2\n\tX7tQ==","X-Gm-Message-State":"AHPjjUhLFrOE+pjdjIrj4z0qUGvPRnQWgU8L9PaBhc3kLFPls46umaEf\n\tteMIH2068uCZHX4hYZvrw2Y=","X-Google-Smtp-Source":"AOwi7QBagAzNtyoNA3/w6HCMJKl9qrkHkShwglERbA4zWd0KAU0Wp8U/XFlo5AmPlxZqVCQP4EB3Pw==","X-Received":"by 10.28.131.13 with SMTP id f13mr3004210wmd.157.1505759580096; \n\tMon, 18 Sep 2017 11:33:00 -0700 (PDT)","From":"Corentin Labbe ","To":"peppe.cavallaro@st.com, alexandre.torgue@st.com,\n\tmaxime.ripard@free-electrons.com, wens@csie.org","Cc":"netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-kernel@vger.kernel.org, Corentin Labbe ","Subject":"[PATCH v2] net: stmmac: dwmac-sun8i: Use reset exclusive","Date":"Mon, 18 Sep 2017 20:30:43 +0200","Message-Id":"<20170918183043.8028-1-clabbe.montjoie@gmail.com>","X-Mailer":"git-send-email 2.13.5","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"The current dwmac_sun8i module cannot be rmmod/modprobe due to that\nthe reset controller was not released when removed.\n\nThis patch remove ambiguity, by using of_reset_control_get_exclusive and\nadd the missing reset_control_put().\n\nNote that we cannot use devm_reset_control_get, since the reset is not\nin the device node.\n\nSigned-off-by: Corentin Labbe \n---\nChanges since v1:\n- added a note about devm_reset_control_get in commit message\n\n drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c\nindex 57bb6dd7b401..1736d7cb0d96 100644\n--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c\n+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c\n@@ -854,6 +854,7 @@ static int sun8i_dwmac_unpower_internal_phy(struct sunxi_priv_data *gmac)\n \n \tclk_disable_unprepare(gmac->ephy_clk);\n \treset_control_assert(gmac->rst_ephy);\n+\treset_control_put(gmac->rst_ephy);\n \treturn 0;\n }\n \n@@ -1010,7 +1011,7 @@ static int sun8i_dwmac_probe(struct platform_device *pdev)\n \t\t\treturn -EINVAL;\n \t\t}\n \n-\t\tgmac->rst_ephy = of_reset_control_get(plat_dat->phy_node, NULL);\n+\t\tgmac->rst_ephy = of_reset_control_get_exclusive(plat_dat->phy_node, NULL);\n \t\tif (IS_ERR(gmac->rst_ephy)) {\n \t\t\tret = PTR_ERR(gmac->rst_ephy);\n \t\t\tif (ret == -EPROBE_DEFER)\n","prefixes":["v2"]}