{"id":814797,"url":"http://patchwork.ozlabs.org/api/1.2/patches/814797/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/alpine.LSU.2.20.1709180935380.26836@zhemvz.fhfr.qr/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.2/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-09-18T07:37:45","name":"[GRAPHITE] Enhance handled data-refs","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6e489a0feca5ca983621d05c765cb5c575458d24","submitter":{"id":4338,"url":"http://patchwork.ozlabs.org/api/1.2/people/4338/?format=json","name":"Richard Biener","email":"rguenther@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/alpine.LSU.2.20.1709180935380.26836@zhemvz.fhfr.qr/mbox/","series":[{"id":3572,"url":"http://patchwork.ozlabs.org/api/1.2/series/3572/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=3572","date":"2017-09-18T07:37:45","name":"[GRAPHITE] Enhance handled data-refs","version":1,"mbox":"http://patchwork.ozlabs.org/series/3572/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814797/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814797/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462352-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"On613ynX\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwdC9614Pz9s72\n\tfor ;\n\tMon, 18 Sep 2017 17:37:56 +1000 (AEST)","(qmail 51069 invoked by alias); 18 Sep 2017 07:37:49 -0000","(qmail 50718 invoked by uid 89); 18 Sep 2017 07:37:48 -0000","from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tMon, 18 Sep 2017 07:37:47 +0000","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\tby\n\tmx1.suse.de (Postfix) with ESMTP id 8374FAAC5\tfor\n\t; Mon, 18 Sep 2017 07:37:45 +0000 (UTC)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:subject:message-id:mime-version:content-type; q=dns; s=\n\tdefault; b=JY8iXRTASO0NbWtd4iDi3ZthMstz7Y3ylLoLXmYcXoEnKkrjiZ15m\n\tDryDzI0IjRjVTJnMXWyPOzyhF53ky4xvzz2jK9wI4wFR6J8Uk80xPSE+la409Fuj\n\t9F5CKCuA7yfmHDLzpuPB9OrfQczghsUjkGzwz7INuLRfo3uGM9I37k=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:subject:message-id:mime-version:content-type; s=\n\tdefault; bh=MGEoStqba3jwlxHuzPpXful7Fws=; b=On613ynXNcVTtAdTQ7Rj\n\tFlJqRRNyzP3ez8fM8nS34R2wqxaGFzb5O10dsrAtv5NCroxSoXnlmEc6SmgmXS36\n\t/6hybIwckzcqAmHOuLHeVuIEVI8Kx541cdJLrIZBgILTqWDcWrd6UIoFaHcp0tDK\n\tESfeZoaiBHCbzxLW29bl3SU=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2,\n\tGIT_PATCH_3, RP_MATCHES_RCVD,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.suse.de","Date":"Mon, 18 Sep 2017 09:37:45 +0200 (CEST)","From":"Richard Biener ","To":"gcc-patches@gcc.gnu.org","Subject":"[PATCH][GRAPHITE] Enhance handled data-refs","Message-ID":"","User-Agent":"Alpine 2.20 (LSU 67 2015-01-07)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII"},"content":"The following removes odd restrictions from data-ref handling, resulting\nin 15% more optimized loop nests in SPEC CPU 2006. We're now also\nrunning into existing PRs when building 481.wrf, I'll have a second\nlook into the respective PRs as a followup.\n\nBootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk.\n\nRichard.\n\n2017-09-18 Richard Biener \n\n\t* graphite-scop-detection.c (scop_detection::stmt_has_simple_data_ref):\n\tSimplify.\n\t(build_alias_set): Reject aliases with no access function.","diff":"Index: gcc/graphite-scop-detection.c\n===================================================================\n--- gcc/graphite-scop-detection.c\t(revision 252905)\n+++ gcc/graphite-scop-detection.c\t(working copy)\n@@ -1338,40 +1338,23 @@ scop_detection::stmt_has_simple_data_ref\n {\n loop_p nest = outermost_loop_in_sese (scop, gimple_bb (stmt));\n loop_p loop = loop_containing_stmt (stmt);\n- vec drs = vNULL;\n+ if (!loop_in_sese_p (loop, scop))\n+ loop = nest;\n \n- graphite_find_data_references_in_stmt (nest, loop, stmt, &drs);\n+ auto_vec drs;\n+ if (! graphite_find_data_references_in_stmt (nest, loop, stmt, &drs))\n+ return false;\n \n int j;\n data_reference_p dr;\n FOR_EACH_VEC_ELT (drs, j, dr)\n {\n- int nb_subscripts = DR_NUM_DIMENSIONS (dr);\n-\n- if (nb_subscripts < 1)\n-\t{\n-\t free_data_refs (drs);\n+ for (unsigned i = 0; i < DR_NUM_DIMENSIONS (dr); ++i)\n+\tif (! graphite_can_represent_scev (DR_ACCESS_FN (dr, i)))\n \t return false;\n-\t}\n-\n- tree ref = DR_REF (dr);\n-\n- for (int i = nb_subscripts - 1; i >= 0; i--)\n-\t{\n-\t if (!graphite_can_represent_scev (DR_ACCESS_FN (dr, i))\n-\t || (TREE_CODE (ref) != ARRAY_REF && TREE_CODE (ref) != MEM_REF\n-\t\t && TREE_CODE (ref) != COMPONENT_REF))\n-\t {\n-\t free_data_refs (drs);\n-\t return false;\n-\t }\n-\n-\t ref = TREE_OPERAND (ref, 0);\n-\t}\n }\n \n- free_data_refs (drs);\n- return true;\n+ return true;\n }\n \n /* GIMPLE_ASM and GIMPLE_CALL may embed arbitrary side effects.\n@@ -1875,7 +1858,8 @@ build_alias_set (scop_p scop)\n \t{\n \t /* Dependences in the same alias set need to be handled\n \t by just looking at DR_ACCESS_FNs. */\n-\t if (DR_NUM_DIMENSIONS (dr1->dr) != DR_NUM_DIMENSIONS (dr2->dr)\n+\t if (DR_NUM_DIMENSIONS (dr1->dr) == 0\n+\t || DR_NUM_DIMENSIONS (dr1->dr) != DR_NUM_DIMENSIONS (dr2->dr)\n \t || ! operand_equal_p (DR_BASE_OBJECT (dr1->dr),\n \t\t\t\t DR_BASE_OBJECT (dr2->dr),\n \t\t\t\t OEP_ADDRESS_OF)\n","prefixes":["GRAPHITE"]}