{"id":814796,"url":"http://patchwork.ozlabs.org/api/1.2/patches/814796/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1505720138-14416-1-git-send-email-tariqt@mellanox.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505720138-14416-1-git-send-email-tariqt@mellanox.com>","list_archive_url":null,"date":"2017-09-18T07:35:38","name":"[v2,ethtool] ethtool: Remove UDP Fragmentation Offload error prints","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"0da0ee4579ad4dae2ecbd6f5638d77078e551dd1","submitter":{"id":68926,"url":"http://patchwork.ozlabs.org/api/1.2/people/68926/?format=json","name":"Tariq Toukan","email":"tariqt@mellanox.com"},"delegate":{"id":61071,"url":"http://patchwork.ozlabs.org/api/1.2/users/61071/?format=json","username":"linville","first_name":"John","last_name":"Linville","email":"linville@tuxdriver.com"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1505720138-14416-1-git-send-email-tariqt@mellanox.com/mbox/","series":[{"id":3571,"url":"http://patchwork.ozlabs.org/api/1.2/series/3571/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3571","date":"2017-09-18T07:35:38","name":"[v2,ethtool] ethtool: Remove UDP Fragmentation Offload error prints","version":2,"mbox":"http://patchwork.ozlabs.org/series/3571/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814796/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814796/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwd9H2C0sz9ryQ\n\tfor ;\n\tMon, 18 Sep 2017 17:36:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752602AbdIRHgR (ORCPT );\n\tMon, 18 Sep 2017 03:36:17 -0400","from mail-il-dmz.mellanox.com ([193.47.165.129]:60376 \"EHLO\n\tmellanox.co.il\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1752600AbdIRHgP (ORCPT\n\t); Mon, 18 Sep 2017 03:36:15 -0400","from Internal Mail-Server by MTLPINE1 (envelope-from\n\ttariqt@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 18 Sep 2017 10:36:10 +0300","from dev-l-vrt-206-006.mtl.labs.mlnx\n\t(dev-l-vrt-206-006.mtl.labs.mlnx [10.134.206.6])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v8I7aAV2032496;\n\tMon, 18 Sep 2017 10:36:10 +0300"],"From":"Tariq Toukan ","To":"\"John W. Linville\" ","Cc":"netdev@vger.kernel.org, Eran Ben Elisha ,\n\tMichal Kubecek , Eric Dumazet ,\n\t\"David S. Miller\" ,\n\tShaker Daibes , Tariq Toukan ","Subject":"[PATCH v2 ethtool] ethtool: Remove UDP Fragmentation Offload error\n\tprints","Date":"Mon, 18 Sep 2017 10:35:38 +0300","Message-Id":"<1505720138-14416-1-git-send-email-tariqt@mellanox.com>","X-Mailer":"git-send-email 1.8.3.1","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Shaker Daibes \n\nUFO was removed in kernel, here we remove UFO error prints when using\n\"ethtool -k\" command.\n\nFixes the following issue:\nFeatures for ens8:\nCannot get device udp-fragmentation-offload settings: Operation not\nsupported\n\nSigned-off-by: Shaker Daibes \nSigned-off-by: Tariq Toukan \n---\n ethtool.c | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/ethtool.c b/ethtool.c\nindex ad18704e7c5f..aeeef65e7ef3 100644\n--- a/ethtool.c\n+++ b/ethtool.c\n@@ -2186,6 +2186,10 @@ get_features(struct cmd_context *ctx, const struct feature_defs *defs)\n \t\teval.cmd = off_flag_def[i].get_cmd;\n \t\terr = send_ioctl(ctx, &eval);\n \t\tif (err) {\n+\t\t\tif (errno == EOPNOTSUPP &&\n+\t\t\t off_flag_def[i].get_cmd == ETHTOOL_GUFO)\n+\t\t\t\tcontinue;\n+\n \t\t\tfprintf(stderr,\n \t\t\t\t\"Cannot get device %s settings: %m\\n\",\n \t\t\t\toff_flag_def[i].long_name);\n","prefixes":["v2","ethtool"]}