{"id":814782,"url":"http://patchwork.ozlabs.org/api/1.2/patches/814782/?format=json","web_url":"http://patchwork.ozlabs.org/project/openbmc/patch/20170918054905.16470-5-andrew@aj.id.au/","project":{"id":56,"url":"http://patchwork.ozlabs.org/api/1.2/projects/56/?format=json","name":"OpenBMC development","link_name":"openbmc","list_id":"openbmc.lists.ozlabs.org","list_email":"openbmc@lists.ozlabs.org","web_url":"http://github.com/openbmc/","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918054905.16470-5-andrew@aj.id.au>","list_archive_url":null,"date":"2017-09-18T05:49:05","name":"[4/4] watchdog: aspeed: Move init to arch_initcall","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"6d4462f9cd0b3f56b9821e5090d73289d9f6ca1f","submitter":{"id":68332,"url":"http://patchwork.ozlabs.org/api/1.2/people/68332/?format=json","name":"Andrew Jeffery","email":"andrew@aj.id.au"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openbmc/patch/20170918054905.16470-5-andrew@aj.id.au/mbox/","series":[{"id":3562,"url":"http://patchwork.ozlabs.org/api/1.2/series/3562/?format=json","web_url":"http://patchwork.ozlabs.org/project/openbmc/list/?series=3562","date":"2017-09-18T05:49:01","name":"watchdog: aspeed: Retain enabled state and move to","version":1,"mbox":"http://patchwork.ozlabs.org/series/3562/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814782/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814782/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwZv04h9vz9s7F\n\tfor ;\n\tMon, 18 Sep 2017 15:53:48 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xwZv03VSqzDrcJ\n\tfor ;\n\tMon, 18 Sep 2017 15:53:48 +1000 (AEST)","from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xwZq03kFRzDrZx;\n\tMon, 18 Sep 2017 15:50:20 +1000 (AEST)","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id D76B820A4D;\n\tMon, 18 Sep 2017 01:50:17 -0400 (EDT)","from frontend1 ([10.202.2.160])\n\tby compute4.internal (MEProxy); Mon, 18 Sep 2017 01:50:17 -0400","from keelia.au.ibm.com (ppp14-2-0-125.bras21.adl4.internode.on.net\n\t[14.2.0.125])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 5A1407E183;\n\tMon, 18 Sep 2017 01:50:14 -0400 (EDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"uaJp86SA\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"M441g2t1\"; \n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"uaJp86SA\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"M441g2t1\"; \n\tdkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=aj.id.au\n\t(client-ip=66.111.4.25; helo=out1-smtp.messagingengine.com;\n\tenvelope-from=andrew@aj.id.au; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"uaJp86SA\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"M441g2t1\"; dkim-atps=neutral"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc\n\t:date:from:in-reply-to:message-id:references:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=BgM0nG\n\tRIWOykUxBASDdRHsLpvjv/DxPAGMjLrhip/08=; b=uaJp86SAZez2ASPo+Ia/LL\n\tStZb2sC78dF50s8ns7/OiiWoY7MbeBC/D8l3i8B21cm5cdVfZVQBtb3Kjz0Lpe2J\n\tV8Gow4GzzNUHYZMITt7DbhF5G2KrcYg6U4INIUjdRgjrq0Jjx84P60i2GUHqDkIn\n\tmCS5qVk3IKeAp+kbXu2dcSqWk1h9u6B38oPubhP7NuTgl1jXoUCZA790ijSO4yPD\n\tUGuRLkFlrew8OEFNlPMxryCU9RsmyN28lJFns7NyPkBY5I3b0DeHxLlAz2N7SvJB\n\t7MfWYfyKSgK9nzo95la3lSD5LadTorBEmKozq8lxyPrGKnhnzfwNQSRzelqUS3sw\n\t==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:date:from:in-reply-to:message-id\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc\n\t:x-sasl-enc; s=fm1; bh=BgM0nGRIWOykUxBASDdRHsLpvjv/DxPAGMjLrhip/\n\t08=; b=M441g2t1bZhJcTWxe78G5VTp37LmoG58qzuGZioEc6+MHoL2bKwp11wOH\n\tAionsRwS2tYj/jbACqMHsnNrtatPDvOICZXunWWVtPrZgu1hCMp4QhHWAQEDnbrO\n\t0qtzg9Sv3JIrJIrbXZJO+Hh3ezYd2LpjiMbgq306eWfB2iVG/hBIVKN/NUsNMyky\n\tIXLcnOJi1BjmYIz6fivtOppXOdcqR6Ip2Oq26mEEuFI7gr4TAomC/K280YKODJhn\n\tDOsmXWDHIN/f4m8zZ+vK3UVZ+LllZllrJ+vY/BpAZlEleJwghrsr3BlkVSjY0kp+\n\t4IHl1JD3liSIvwDyHsnzOsuPDZbkQ=="],"X-ME-Sender":"","X-Sasl-enc":"LtH+odbAc08lmuOZoOK3teUwjtETKE0RdbBXLTadCQWR 1505713817","From":"Andrew Jeffery ","To":"linux-watchdog@vger.kernel.org","Subject":"[PATCH 4/4] watchdog: aspeed: Move init to arch_initcall","Date":"Mon, 18 Sep 2017 15:19:05 +0930","Message-Id":"<20170918054905.16470-5-andrew@aj.id.au>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170918054905.16470-1-andrew@aj.id.au>","References":"<20170918054905.16470-1-andrew@aj.id.au>","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Development list for OpenBMC ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"ryan_chen@aspeedtech.com, linux-aspeed@lists.ozlabs.org,\n\tAndrew Jeffery , openbmc@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org, wim@iguana.be, linux@roeck-us.net","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t"},"content":"Probing at device_initcall time lead to perverse cases where the\nwatchdog was probed after, say, I2C, which then leaves a potentially\nrunning watchdog at the mercy of I2C device behaviour and bus\nconditions.\n\nLoad the watchdog driver early to ensure that the kernel is patting it\nwell before initialising peripherals.\n\nSigned-off-by: Andrew Jeffery \n---\n drivers/watchdog/Kconfig | 6 ++----\n drivers/watchdog/aspeed_wdt.c | 7 ++++++-\n 2 files changed, 8 insertions(+), 5 deletions(-)","diff":"diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig\nindex a1b92ebe74b6..6103185983ed 100644\n--- a/drivers/watchdog/Kconfig\n+++ b/drivers/watchdog/Kconfig\n@@ -741,8 +741,9 @@ config RENESAS_RZAWDT\n \t Renesas RZ/A SoCs. These watchdogs can be used to reset a system.\n \n config ASPEED_WATCHDOG\n-\ttristate \"Aspeed BMC watchdog support\"\n+\tbool \"Aspeed BMC watchdog support\"\n \tdepends on ARCH_ASPEED || COMPILE_TEST\n+\tdefault y if ARCH_ASPEED\n \tselect WATCHDOG_CORE\n \thelp\n \t Say Y here to include support for the watchdog timer\n@@ -750,9 +751,6 @@ config ASPEED_WATCHDOG\n \n \t This driver is required to reboot the SoC.\n \n-\t To compile this driver as a module, choose M here: the\n-\t module will be called aspeed_wdt.\n-\n config ZX2967_WATCHDOG\n \ttristate \"ZTE zx2967 SoCs watchdog support\"\n \tdepends on ARCH_ZX\ndiff --git a/drivers/watchdog/aspeed_wdt.c b/drivers/watchdog/aspeed_wdt.c\nindex 99bc6fbd8852..679c35abadc4 100644\n--- a/drivers/watchdog/aspeed_wdt.c\n+++ b/drivers/watchdog/aspeed_wdt.c\n@@ -313,7 +313,12 @@ static struct platform_driver aspeed_watchdog_driver = {\n \t\t.of_match_table = of_match_ptr(aspeed_wdt_of_table),\n \t},\n };\n-module_platform_driver(aspeed_watchdog_driver);\n+\n+static int __init aspeed_wdt_init(void)\n+{\n+\treturn platform_driver_register(&aspeed_watchdog_driver);\n+}\n+arch_initcall(aspeed_wdt_init);\n \n MODULE_DESCRIPTION(\"Aspeed Watchdog Driver\");\n MODULE_LICENSE(\"GPL\");\n","prefixes":["4/4"]}