{"id":814766,"url":"http://patchwork.ozlabs.org/api/1.2/patches/814766/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1505708164-10270-3-git-send-email-roid@mellanox.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.2/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505708164-10270-3-git-send-email-roid@mellanox.com>","list_archive_url":null,"date":"2017-09-18T04:16:02","name":"[ovs-dev,V2,2/4] odp-util: Expose ovs flow key attr len table for reuse","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"c65f3ea69a04e74f07f22b41b00740ffe23237df","submitter":{"id":70307,"url":"http://patchwork.ozlabs.org/api/1.2/people/70307/?format=json","name":"Roi Dayan","email":"roid@mellanox.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1505708164-10270-3-git-send-email-roid@mellanox.com/mbox/","series":[{"id":3557,"url":"http://patchwork.ozlabs.org/api/1.2/series/3557/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=3557","date":"2017-09-18T04:16:00","name":"Add offload support for action set","version":2,"mbox":"http://patchwork.ozlabs.org/series/3557/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814766/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814766/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwXlH1C4Hz9s7G\n\tfor ;\n\tMon, 18 Sep 2017 14:16:59 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 9E347A5E;\n\tMon, 18 Sep 2017 04:16:20 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 4D205941\n\tfor ; Mon, 18 Sep 2017 04:16:18 +0000 (UTC)","from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTP id 4798AD3\n\tfor ; Mon, 18 Sep 2017 04:16:16 +0000 (UTC)","from Internal Mail-Server by MTLPINE1 (envelope-from\n\troid@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 18 Sep 2017 07:16:11 +0300","from dev-r-vrt-189.mtr.labs.mlnx (dev-r-vrt-189.mtr.labs.mlnx\n\t[10.212.189.1])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v8I4GBDS001186;\n\tMon, 18 Sep 2017 07:16:11 +0300"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","From":"Roi Dayan ","To":"dev@openvswitch.org","Date":"Mon, 18 Sep 2017 07:16:02 +0300","Message-Id":"<1505708164-10270-3-git-send-email-roid@mellanox.com>","X-Mailer":"git-send-email 2.7.5","In-Reply-To":"<1505708164-10270-1-git-send-email-roid@mellanox.com>","References":"<1505708164-10270-1-git-send-email-roid@mellanox.com>","X-Spam-Status":"No, score=0.0 required=5.0 tests=RP_MATCHES_RCVD,\n\tUNPARSEABLE_RELAY autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"Simon Horman ","Subject":"[ovs-dev] [PATCH V2 2/4] odp-util: Expose ovs flow key attr len\n\ttable for reuse","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"From: Paul Blakey \n\nMake ovs_flow_key_attr_lens() public to be reused by other modules.\n\nSigned-off-by: Paul Blakey \nReviewed-by: Roi Dayan \n---\n lib/odp-util.c | 11 +----------\n lib/odp-util.h | 11 +++++++++++\n 2 files changed, 12 insertions(+), 10 deletions(-)","diff":"diff --git a/lib/odp-util.c b/lib/odp-util.c\nindex 4f1499e..d2facde 100644\n--- a/lib/odp-util.c\n+++ b/lib/odp-util.c\n@@ -56,15 +56,6 @@ VLOG_DEFINE_THIS_MODULE(odp_util);\n static const char *delimiters = \", \\t\\r\\n\";\n static const char *delimiters_end = \", \\t\\r\\n)\";\n \n-struct attr_len_tbl {\n- int len;\n- const struct attr_len_tbl *next;\n- int next_max;\n-};\n-#define ATTR_LEN_INVALID -1\n-#define ATTR_LEN_VARIABLE -2\n-#define ATTR_LEN_NESTED -3\n-\n static int parse_odp_key_mask_attr(const char *, const struct simap *port_names,\n struct ofpbuf *, struct ofpbuf *);\n static void format_odp_key_attr(const struct nlattr *a,\n@@ -2198,7 +2189,7 @@ static const struct attr_len_tbl ovs_tun_key_attr_lens[OVS_TUNNEL_KEY_ATTR_MAX +\n [OVS_TUNNEL_KEY_ATTR_IPV6_DST] = { .len = 16 },\n };\n \n-static const struct attr_len_tbl ovs_flow_key_attr_lens[OVS_KEY_ATTR_MAX + 1] = {\n+const struct attr_len_tbl ovs_flow_key_attr_lens[OVS_KEY_ATTR_MAX + 1] = {\n [OVS_KEY_ATTR_ENCAP] = { .len = ATTR_LEN_NESTED },\n [OVS_KEY_ATTR_PRIORITY] = { .len = 4 },\n [OVS_KEY_ATTR_SKB_MARK] = { .len = 4 },\ndiff --git a/lib/odp-util.h b/lib/odp-util.h\nindex 27c2ab4..72a3c30 100644\n--- a/lib/odp-util.h\n+++ b/lib/odp-util.h\n@@ -344,4 +344,15 @@ void odp_put_push_eth_action(struct ofpbuf *odp_actions,\n const struct eth_addr *eth_src,\n const struct eth_addr *eth_dst);\n \n+struct attr_len_tbl {\n+ int len;\n+ const struct attr_len_tbl *next;\n+ int next_max;\n+};\n+\n+#define ATTR_LEN_INVALID -1\n+#define ATTR_LEN_VARIABLE -2\n+#define ATTR_LEN_NESTED -3\n+\n+extern const struct attr_len_tbl ovs_flow_key_attr_lens[OVS_KEY_ATTR_MAX + 1];\n #endif /* odp-util.h */\n","prefixes":["ovs-dev","V2","2/4"]}