{"id":814763,"url":"http://patchwork.ozlabs.org/api/1.2/patches/814763/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170918032815.25626-2-anarsoul@gmail.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170918032815.25626-2-anarsoul@gmail.com>","list_archive_url":null,"date":"2017-09-18T03:28:14","name":"[U-Boot,2/3] video: pwm_backlight: make regulator optional","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2c9301fee1c58de1e35232bfd767aeb2395b1a38","submitter":{"id":6930,"url":"http://patchwork.ozlabs.org/api/1.2/people/6930/?format=json","name":"Vasily Khoruzhick","email":"anarsoul@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170918032815.25626-2-anarsoul@gmail.com/mbox/","series":[{"id":3556,"url":"http://patchwork.ozlabs.org/api/1.2/series/3556/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=3556","date":"2017-09-18T03:28:13","name":"[U-Boot,1/3] pwm: sunxi: add support for PWM found on Allwinner A64 and H3","version":1,"mbox":"http://patchwork.ozlabs.org/series/3556/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814763/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814763/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"MfIUyUx3\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwWh92Gnyz9ryr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 13:29:13 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1306EC21D80; Mon, 18 Sep 2017 03:28:49 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 47F31C21EC5;\n\tMon, 18 Sep 2017 03:28:24 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 03B65C21D57; Mon, 18 Sep 2017 03:28:22 +0000 (UTC)","from mail-pg0-f66.google.com (mail-pg0-f66.google.com\n\t[74.125.83.66])\n\tby lists.denx.de (Postfix) with ESMTPS id 6F31CC21D19\n\tfor <u-boot@lists.denx.de>; Mon, 18 Sep 2017 03:28:22 +0000 (UTC)","by mail-pg0-f66.google.com with SMTP id i130so4597820pgc.0\n\tfor <u-boot@lists.denx.de>; Sun, 17 Sep 2017 20:28:22 -0700 (PDT)","from anarsoul-thinkpad.lan (216-71-193-140.dyn.novuscom.net.\n\t[216.71.193.140]) by smtp.gmail.com with ESMTPSA id\n\t22sm10554080pfb.31.2017.09.17.20.28.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 17 Sep 2017 20:28:20 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=D7NwXHbccM3ulMattqZNPEq1eTXYbi6TkTha+rC2n4M=;\n\tb=MfIUyUx3YSnVQbrgFdFkp1mZGHW2//Fk1owss/Np4pSfG2NGxmwuF1ltK7hQfRkm5z\n\tjf6XdONuRuD9acoVQi+WHHGhkjEhAi3TUzCf/X5ss2zQF/PnlbaYJc4YG+jtExV1eArc\n\tZcjkbzQfERRAjploBomus2fL6eBan+TToPwSEHPX9CgqVM7M26+xFREkeQPvRBD4KPBZ\n\tRhvG2x/EFOFh+lJCr/LSpyLE++O9VxJiW0E+LKKpJzPiepZCNK5SkpKEu9cH7Y7GZuq2\n\tLxVdN+MWO5g0aQmSJKXhSMeOB1aobawnukrNp+4C2TnAGxoHE8f21rop7gTYR9Qt6xk4\n\tJnHA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=D7NwXHbccM3ulMattqZNPEq1eTXYbi6TkTha+rC2n4M=;\n\tb=lU4LwUwpi9N97EHXfugxLZ6zR5+tqgv7lOuGvLkv1060rP2DvRsrdmNdJFKo2nV6KA\n\tODcd9nJvBN5oAGYNlaR7bfcg51OiAvqL3jA6cChZUce3YSjH9sNqQh84ZJzApe+/g1iR\n\tX4ZAXSGf1LNk6qWszEVkbuBRPMt5kcWVFf8Qe4g/eMAE638DzAPWhB4/vx6Pj/4Gg8Mh\n\t4FZhGYzb79Ke3CgPfCtswno1i/1R3iDtk3iudcVLz0IkJfeba1XE1BO7GerfPR95O94C\n\t+FbFzl+28UZh8+V049iYqh78j6VPdaSxGiC56Ur4Bqts1JUdryBAoOBF2E+8/BaBrk5K\n\tA53w==","X-Gm-Message-State":"AHPjjUgVYz7cM3bFbkqBqA90ztJeI5Vpp/06WPaqR38oicgF14PbxPN2\n\t5OdS/KmkuFOyH7QYHqc=","X-Google-Smtp-Source":"ADKCNb7TM9IYRrruW2a2pD+TvDnlqDOpHwjpv/0arct+3GKuP/vvZheSWLLpCINrwvTk0KXr4Bu5gA==","X-Received":"by 10.99.186.89 with SMTP id l25mr31545848pgu.212.1505705300934; \n\tSun, 17 Sep 2017 20:28:20 -0700 (PDT)","From":"Vasily Khoruzhick <anarsoul@gmail.com>","To":"u-boot@lists.denx.de,\n\ticenowy@aosc.io","Date":"Sun, 17 Sep 2017 20:28:14 -0700","Message-Id":"<20170918032815.25626-2-anarsoul@gmail.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170918032815.25626-1-anarsoul@gmail.com>","References":"<20170918032815.25626-1-anarsoul@gmail.com>","Subject":"[U-Boot] [PATCH 2/3] video: pwm_backlight: make regulator optional","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"},"content":"u-boot doesn't have dummy regulators, so pwm_backlight probe\nwill fail if regulator is missing. Make it optional to get this\ndriver working on platforms where there's no backlight regultor.\n\nSigned-off-by: Vasily Khoruzhick <anarsoul@gmail.com>\n---\n drivers/video/pwm_backlight.c | 28 ++++++++++++++++------------\n 1 file changed, 16 insertions(+), 12 deletions(-)","diff":"diff --git a/drivers/video/pwm_backlight.c b/drivers/video/pwm_backlight.c\nindex fbd7bf7838..05e56ffead 100644\n--- a/drivers/video/pwm_backlight.c\n+++ b/drivers/video/pwm_backlight.c\n@@ -32,16 +32,21 @@ static int pwm_backlight_enable(struct udevice *dev)\n \tuint duty_cycle;\n \tint ret;\n \n-\tplat = dev_get_uclass_platdata(priv->reg);\n-\tdebug(\"%s: Enable '%s', regulator '%s'/'%s'\\n\", __func__, dev->name,\n-\t      priv->reg->name, plat->name);\n-\tret = regulator_set_enable(priv->reg, true);\n-\tif (ret) {\n-\t\tdebug(\"%s: Cannot enable regulator for PWM '%s'\\n\", __func__,\n-\t\t      dev->name);\n-\t\treturn ret;\n+\tif (priv->reg) {\n+\t\tplat = dev_get_uclass_platdata(priv->reg);\n+\t\tdebug(\"%s: Enable '%s', regulator '%s'/'%s'\\n\", __func__, dev->name,\n+\t\t      priv->reg->name, plat->name);\n+\t\tret = regulator_set_enable(priv->reg, true);\n+\t\tif (ret) {\n+\t\t\tdebug(\"%s: Cannot enable regulator for PWM '%s'\\n\", __func__,\n+\t\t\t      dev->name);\n+\t\t\treturn ret;\n+\t\t}\n+\t\tmdelay(120);\n \t}\n-\tmdelay(120);\n+\n+\tdebug(\"%s: default: %d, min: %d, max: %d\\n\", __func__,\n+\t\tpriv->default_level, priv->min_level, priv->max_level);\n \n \tduty_cycle = priv->period_ns * (priv->default_level - priv->min_level) /\n \t\t(priv->max_level - priv->min_level + 1);\n@@ -68,10 +73,9 @@ static int pwm_backlight_ofdata_to_platdata(struct udevice *dev)\n \tdebug(\"%s: start\\n\", __func__);\n \tret = uclass_get_device_by_phandle(UCLASS_REGULATOR, dev,\n \t\t\t\t\t   \"power-supply\", &priv->reg);\n-\tif (ret) {\n+\tif (ret)\n \t\tdebug(\"%s: Cannot get power supply: ret=%d\\n\", __func__, ret);\n-\t\treturn ret;\n-\t}\n+\n \tret = gpio_request_by_name(dev, \"enable-gpios\", 0, &priv->enable,\n \t\t\t\t   GPIOD_IS_OUT);\n \tif (ret) {\n","prefixes":["U-Boot","2/3"]}